[Windows] Remove global OF_None flag for Windows in ToolOutputFiles

[abhina.sreeskantharajan]

Summary

Since we have created a new OF_TextWithCRLF flag, we no longer need to worry about OF_Text flag turning on CRLF translation. I can remove this workaround I added to globally open all ToolOutputFiles as binary on Windows.

[rnk]

This change isn't NFC, there are many places we use OF_TextWithCRLF with ToolOutputFile:
https://github.com/llvm/llvm-project/blob/main/llvm/tools/llvm-dis/llvm-dis.cpp#L206

In any case, this is my preferred future direction, so let's just make the code change and fix any fallout.

[abhina.sreeskantharajan]

In D100034#2674519, @rnk wrote:

This change isn't NFC, there are many places we use OF_TextWithCRLF with ToolOutputFile:
https://github.com/llvm/llvm-project/blob/main/llvm/tools/llvm-dis/llvm-dis.cpp#L206

In any case, this is my preferred future direction, so let's just make the code change and fix any fallout.

So I added this workaround in https://reviews.llvm.org/D97785. All ToolOutputFiles that were marked with OF_Text after this workaround are still OF_Text and shouldn't turn on CRLF translation. Therefore I don't think there will be any fallout on Windows. Any ToolOutputFile prior to this workaround that was marked as OF_Text was changed to OF_TextWithCRLF like the one in llvm-dis.cpp. My follow-up question is should we change those back to OF_Text or leave them as OF_TextWithCRLF?

llvm/lib/Support/ToolOutputFile.cpp

 ToolOutputFile::ToolOutputFile(StringRef Filename, std::error_code &EC,
                                sys::fs::OpenFlags Flags)
     : Installer(Filename) {
   if (isStdout(Filename)) {
     OS = &outs();
     EC = std::error_code();
     return;
   }
-
-  // On Windows, we set the OF_None flag even for text files to avoid
-  // CRLF translation.
-  OSHolder.emplace(
-      Filename, EC,
-      llvm::Triple(LLVM_HOST_TRIPLE).isOSWindows() ? sys::fs::OF_None : Flags);
+  OSHolder.emplace(Filename, EC, Flags);
   OS = OSHolder.getPointer();
   // If open fails, no cleanup is needed.
   if (EC)
     Installer.Keep = true;
 }
 
 ToolOutputFile::ToolOutputFile(StringRef Filename, int FD)
     : Installer(Filename) {
   OSHolder.emplace(FD, true);
   OS = OSHolder.getPointer();
 }