Page MenuHomePhabricator

[InstCombine] remove incompatible attribute when simplifying some lib calls
ClosedPublic

Authored by zequanwu on Jan 22 2021, 5:14 PM.

Details

Summary

I try to enable attributor module pass to build chrome, and found another crash
(crbug.com/1166273). So, we might want to do the same as D95088 to remove
incompatible attribute in more lib calls.

Diff Detail

Event Timeline

zequanwu created this revision.Jan 22 2021, 5:14 PM
zequanwu requested review of this revision.Jan 22 2021, 5:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 22 2021, 5:14 PM
jdoerfert accepted this revision.Jan 22 2021, 5:16 PM

LGTM. Thanks for following up on this!

llvm/test/Transforms/InstCombine/strncpy-1.ll
184

newline.

This revision is now accepted and ready to land.Jan 22 2021, 5:16 PM
zequanwu edited the summary of this revision. (Show Details)Jan 22 2021, 5:18 PM
This revision was landed with ongoing or failed builds.Jan 22 2021, 5:28 PM
This revision was automatically updated to reflect the committed changes.