Page MenuHomePhabricator

jyknight (James Y Knight)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 27 2015, 11:23 AM (287 w, 2 h)

Recent Activity

Yesterday

jyknight accepted D88195: Remove stale assert..

Clarify commit message.

Phabricator unfortunately won't amend the review description when the commit message is updated; you'll need to manually edit the description via phab's UI for other reviewers to observe the update. :(

Thu, Sep 24, 1:53 PM · Restricted Project
jyknight added inline comments to D88195: Remove stale assert..
Thu, Sep 24, 7:31 AM · Restricted Project

Wed, Sep 23

jyknight added inline comments to D88195: Remove stale assert..
Wed, Sep 23, 8:08 PM · Restricted Project
jyknight added inline comments to D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .
Wed, Sep 23, 7:57 PM · Restricted Project
jyknight added a comment to D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .

I'm happy with this now, but please update the commit message to match the updated change.

Wed, Sep 23, 4:35 PM · Restricted Project
jyknight added inline comments to D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .
Wed, Sep 23, 4:17 PM · Restricted Project

Fri, Sep 18

jyknight committed rGf7a53d82c090: PR47468: Fix findPHICopyInsertPoint, so that copies aren't incorrectly inserted… (authored by jyknight).
PR47468: Fix findPHICopyInsertPoint, so that copies aren't incorrectly inserted…
Fri, Sep 18, 11:14 AM
jyknight closed D87865: PR47468: Fix findPHICopyInsertPoint, so that copies aren't incorrectly inserted after an INLINEASM_BR..
Fri, Sep 18, 11:14 AM · Restricted Project
jyknight added inline comments to D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .
Fri, Sep 18, 9:55 AM · Restricted Project
jyknight updated the diff for D87865: PR47468: Fix findPHICopyInsertPoint, so that copies aren't incorrectly inserted after an INLINEASM_BR..

Comment nits.

Fri, Sep 18, 9:42 AM · Restricted Project
jyknight added inline comments to D87865: PR47468: Fix findPHICopyInsertPoint, so that copies aren't incorrectly inserted after an INLINEASM_BR..
Fri, Sep 18, 9:33 AM · Restricted Project

Thu, Sep 17

jyknight published D87865: PR47468: Fix findPHICopyInsertPoint, so that copies aren't incorrectly inserted after an INLINEASM_BR. for review.
Thu, Sep 17, 3:44 PM · Restricted Project

Fri, Sep 11

jyknight added a comment to D86881: Make -fvisibility-inlines-hidden apply to static local variables in inline functions on Darwin.

But this (re-)breaks the functionality of -fvisibility-inlines-hidden on Darwin. That seems bad? I'd've liked to see more of an explanation as to why this was considered a necessary breakage.

Fri, Sep 11, 11:31 AM · Restricted Project

Thu, Sep 3

jyknight added a comment to D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .

Do you have open questions on whether some callsites passing "false" here, should be switched to true? Given what's here, I would say that it definitely does not makes sense to add this parameter everywhere.

Thu, Sep 3, 1:50 PM · Restricted Project

Mon, Aug 31

jyknight added inline comments to D86815: [LangRef] Adjust guarantee for llvm.memcpy to also allow equal arguments..
Mon, Aug 31, 5:49 PM · Restricted Project

Sun, Aug 30

jyknight requested review of D86855: Convert __m64 intrinsics to unconditionally use SSE2 instead of MMX instructions..
Sun, Aug 30, 3:29 PM · Restricted Project

Sat, Aug 29

jyknight added inline comments to D86260: [CodeGen] Postprocess PHI nodes for callbr.
Sat, Aug 29, 3:35 PM · Restricted Project

Fri, Aug 28

jyknight added a comment to D85225: [Target][AArch64] Allow for char as int8_t in AArch64AsmParser.cpp.

ro: In this case, I would say to defer to Paul, although I wish that he would change his mind.

Fri, Aug 28, 3:35 PM · Restricted Project

Aug 25 2020

jyknight added a comment to D82777: Clang Driver: Use Apple ld64's new @response-file support..

BTW, to the apple folks here, it'd sure be awesome if this could be backported into XCode 12's clang. :) (c.f. FB7037642).

Aug 25 2020, 4:52 PM · Restricted Project

Aug 24 2020

jyknight added a comment to D86142: [LLD] Search archives for non-tentative defintions..

Given that BFD supports this behaviour but Gold and LLD do not I suspect that the risk of breaking existing programs is small, especially as LLD tends to be used with more recent programs where -fno-common is the default. However I think we should be cautious and perhaps enable under a command line option, especially as it looks like this is a convention rather than part of a specification. If anyone has better references, then I'm happy to retract.

I agree the new behavior needs an option to enable it and disable it. Initially I considered having the Fortran driver pass the option to LLD, but after discussing it offline with @rzurob I think it might be best to enable the behavior by default. The consumer of these libraries aren't necessarily Fortran programs, and as you mentioned its likely to be lower risk because we are adopting a behavior already implemented in ld.bfd.

There are 4 combinations: (ArchiveFile,LazyObjFile) x (ELF, BitcodeFile). LazyObjFile is for --start-lib/--end-lib. Do you think whether it is worth making LazyObjFile or BitcodeFile consistent with ArchiveFile x ELF behavior? If we add an option (say, --fortran-linking, the Dec 1999 binutils thread suggested but did not adopt), we will have better justification that we don't make LazyObjFile or BitcodeFile consistent.

Aug 24 2020, 5:20 PM · Restricted Project, Restricted Project
jyknight added inline comments to D85225: [Target][AArch64] Allow for char as int8_t in AArch64AsmParser.cpp.
Aug 24 2020, 1:51 PM · Restricted Project

Aug 20 2020

jyknight added a comment to D86260: [CodeGen] Postprocess PHI nodes for callbr.

The commit message is confusing for this -- this isn't a correctness fix, but a minor optimization, right?

I'm not convinced it's just an optimization, but I could be swayed. It seems to me that the value coming into the PHI shouldn't rely upon the semantics of the asm block. So for instance would this be incorrect?

Aug 20 2020, 3:57 PM · Restricted Project
jyknight added a comment to D86260: [CodeGen] Postprocess PHI nodes for callbr.

The commit message is confusing for this -- this isn't a correctness fix, but a minor optimization, right?

Aug 20 2020, 3:22 PM · Restricted Project
jyknight added a comment to D85044: Add __atomic_is_lock_free to compiler-rt.

There is going to be a bunch more complexity required here, I'm afraid.

Aug 20 2020, 12:47 PM · Restricted Project, Restricted Project

Aug 18 2020

jyknight added inline comments to D85225: [Target][AArch64] Allow for char as int8_t in AArch64AsmParser.cpp.
Aug 18 2020, 2:49 PM · Restricted Project
jyknight added inline comments to D85225: [Target][AArch64] Allow for char as int8_t in AArch64AsmParser.cpp.
Aug 18 2020, 8:52 AM · Restricted Project

Aug 17 2020

jyknight added a comment to D85630: [cmake] Don't build with -O3 -fPIC on Solaris/sparcv9.

Presumably this is a bug in something -- either the solaris linker, in g++, or in the llvm code being mis-compiled? It seems unfortunate to put in place a hacky workaround like this, without a bug reference to the responsible component.

Aug 17 2020, 2:28 PM · Restricted Project

Aug 10 2020

jyknight added a comment to D71726: Let clang atomic builtins fetch add/sub support floating point types.

Oh, one more note, C11 has -- and clang already supports -- _Atomic long double x; x += 4; via lowering to a cmpxchg loop. Now that we have an LLVM IR representation for atomicrmw fadd/fsub, clang should be lowering the _Atomic += to that, too. (Doesn't need to be in this patch, but it should be done.)

Aug 10 2020, 9:13 AM
jyknight added a comment to D71726: Let clang atomic builtins fetch add/sub support floating point types.
In D71726#2182667, @tra wrote:

If a target would like to treat single and double fp atomics as unsupported, it can override the default behavior in its own TargetInfo.

Aug 10 2020, 9:11 AM

Jul 29 2020

jyknight added inline comments to D83465: Encode alignment attribute for `atomicrmw`.
Jul 29 2020, 3:38 PM · Restricted Project

Jul 27 2020

jyknight added a comment to D83533: [Alignment][NFC] Update Bitcodewriter to use Align.

I think this new header ought to go in include/llvm/Bitcode/, not Bitstream?

Jul 27 2020, 1:01 PM · Restricted Project

Jul 21 2020

jyknight added a comment to D84200: Disable trivial weak_ptr test on ARM because it is not expected to work..

Right, the trivial_abi attribute doesn't guarantee that you pass an object in registers, it just gives permission for the implementation to treat the struct as-if it was a trivial struct. On ARM32, since the ABI specifies that trivial structs > 4 bytes are returned indirectly by passing a hidden pointer to a pre-allocated return struct, that's what you get.

Jul 21 2020, 3:52 PM · Restricted Project
jyknight added a comment to D71726: Let clang atomic builtins fetch add/sub support floating point types.

Why not have clang always emit atomicrmw for floats, and let AtomicExpandPass handle legalizing that into integer atomics if necessary, rather than adding a target hook in clang?

Not all targets can legalize fp atomics by AtomicExpandPass. Some targets need library support.

Jul 21 2020, 3:41 PM
jyknight added a comment to D71726: Let clang atomic builtins fetch add/sub support floating point types.

Why not have clang always emit atomicrmw for floats, and let AtomicExpandPass handle legalizing that into integer atomics if necessary, rather than adding a target hook in clang?

Jul 21 2020, 3:05 PM

Jul 20 2020

jyknight accepted D84183: [libcxx] Skip tests on GCC.

This kind of change is usually ok to just push, with a note on the original review that you had to push a followup fix.

Jul 20 2020, 9:55 AM · Restricted Project

Jul 17 2020

jyknight committed rG8a438096ffa4: Remove TwoAddressInstructionPass::sink3AddrInstruction. (authored by jyknight).
Remove TwoAddressInstructionPass::sink3AddrInstruction.
Jul 17 2020, 1:31 PM

Jul 16 2020

jyknight committed rG60433c63acb7: Remove TwoAddressInstructionPass::sink3AddrInstruction. (authored by jyknight).
Remove TwoAddressInstructionPass::sink3AddrInstruction.
Jul 16 2020, 7:03 AM
jyknight closed D83708: Remove TwoAddressInstructinoPass::sink3AddrInstruction..
Jul 16 2020, 7:03 AM · Restricted Project

Jul 14 2020

jyknight added inline comments to D83708: Remove TwoAddressInstructinoPass::sink3AddrInstruction..
Jul 14 2020, 11:50 AM · Restricted Project

Jul 13 2020

jyknight added inline comments to D83708: Remove TwoAddressInstructinoPass::sink3AddrInstruction..
Jul 13 2020, 1:53 PM · Restricted Project
jyknight updated the diff for D83708: Remove TwoAddressInstructinoPass::sink3AddrInstruction..

Improve commit message wording
Simplify added test a bit

Jul 13 2020, 1:53 PM · Restricted Project
jyknight added inline comments to D83708: Remove TwoAddressInstructinoPass::sink3AddrInstruction..
Jul 13 2020, 1:26 PM · Restricted Project
jyknight added a comment to D83704: [llvm-readobj] Print error when executed with no input files.

FWIW, it rather bugs me when tools print their entire (long) help upon command-line syntax error. Simply printing an error is generally better. (E.g. "error: no input files specified.")

Jul 13 2020, 12:23 PM · Restricted Project
jyknight updated the summary of D83708: Remove TwoAddressInstructinoPass::sink3AddrInstruction..
Jul 13 2020, 12:01 PM · Restricted Project
jyknight added a comment to D83523: MachineSink: permit sinking into INLINEASM_BR indirect targets.

INLINEASM_BR already returns true for hasUnmodeledSideEffects(), so the diff above doesn't change anything.

Jul 13 2020, 11:53 AM · Restricted Project
Herald added a project to D83708: Remove TwoAddressInstructinoPass::sink3AddrInstruction.: Restricted Project.
Jul 13 2020, 11:51 AM · Restricted Project

Jul 10 2020

jyknight added a comment to D83523: MachineSink: permit sinking into INLINEASM_BR indirect targets.

It looks like the issue shown in this test-case appears in Two-Address instruction pass, not Machine Sink.

Jul 10 2020, 3:15 PM · Restricted Project

Jul 6 2020

jyknight added a comment to D82490: [libcxx] Put clang::trivial_abi on std::unique_ptr.

Of course, running into the problem also requires an asserts-enabled build of clang, because this change has triggered a Clang bug, which will need to be fixed before this can be recommitted.

Jul 6 2020, 1:12 PM · Restricted Project
jyknight added a comment to D83015: [Driver] Add --ld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path.

BTW, I just noticed recently that we have a -mlinker-version= flag, too, which is only used on darwin at the moment. That's another instance of "we need to condition behavior based on what linker we're invoking", but in this case, between multiple versions of apple's linker, rather than which brand of linker. That doesn't impact this directly, but just thought I'd mention it as it's in the same area of concern.

Jul 6 2020, 1:04 PM · Restricted Project
jyknight accepted D83136: [NFC] Adding the align attribute on Atomic{CmpXchg|RMW}Inst.

It's odd to have CreateAtomicCmpXchg and CreateAtomicRMW not have Align as an argument when the constructors do, but as long as the migration is finished in an upcoming commit, this seems fine as a step on the path.

Jul 6 2020, 12:55 PM · Restricted Project

Jul 1 2020

jyknight added a comment to D81369: [Alignment][NFC] Migrate AtomicExpandPass to Align.

Thanks for the cleanup!

Jul 1 2020, 3:41 PM · Restricted Project
jyknight added a comment to D82923: introducing llvm-libtool-darwin.

I suggest removing the extraneous level of directory "Darwin" -- just put the files in "llvm/tools/llvm-libtool-darwin", name the source "llvm-libtool-darwin.cpp", and say you're adding "llvm-libtool-darwin" in the commit message.

Jul 1 2020, 12:27 PM · Restricted Project
jyknight committed rG4b0aa5724fea: Change the INLINEASM_BR MachineInstr to be a non-terminating instruction. (authored by jyknight).
Change the INLINEASM_BR MachineInstr to be a non-terminating instruction.
Jul 1 2020, 10:16 AM
jyknight closed D79794: Change the INLINEASM_BR MachineInstr to be a non-terminating instruction..
Jul 1 2020, 10:16 AM · Restricted Project

Jun 29 2020

jyknight added inline comments to D79794: Change the INLINEASM_BR MachineInstr to be a non-terminating instruction..
Jun 29 2020, 4:22 PM · Restricted Project
jyknight updated the diff for D79794: Change the INLINEASM_BR MachineInstr to be a non-terminating instruction..

Minor fixups.

Jun 29 2020, 4:22 PM · Restricted Project
jyknight committed rG4772b99dffec: Clang Driver: refactor support for writing response files to be specified at… (authored by jyknight).
Clang Driver: refactor support for writing response files to be specified at…
Jun 29 2020, 3:33 PM
jyknight closed D82782: Clang Driver: refactor support for writing response files to be specified at Command creation, rather than as part of the Tool..
Jun 29 2020, 3:33 PM · Restricted Project
jyknight committed rG381df1653c92: Clang Driver: Use Apple ld64's new @response-file support. (authored by jyknight).
Clang Driver: Use Apple ld64's new @response-file support.
Jun 29 2020, 3:33 PM
jyknight closed D82777: Clang Driver: Use Apple ld64's new @response-file support..
Jun 29 2020, 3:33 PM · Restricted Project
Herald added a reviewer for D82782: Clang Driver: refactor support for writing response files to be specified at Command creation, rather than as part of the Tool.: DavidTruby.
Jun 29 2020, 9:10 AM · Restricted Project
jyknight created D82777: Clang Driver: Use Apple ld64's new @response-file support..
Jun 29 2020, 9:10 AM · Restricted Project

Jun 26 2020

jyknight added a comment to D79794: Change the INLINEASM_BR MachineInstr to be a non-terminating instruction..

After working on the previously mentioned unreachable-block-end cleanup for a bit (not done yet), and thinking about this patch more, I actually think it's okay to go ahead with this change now. The potential problem I was worried about is that the code may think that if you have INLINEASM_BR in a basic-block, where the block-end is unreachable, and the block is followed by a basic-block which is one of the indirect targets of the INLINEASM_BR, the code will think the first block falls through, when it does not.

Jun 26 2020, 4:38 PM · Restricted Project
jyknight updated the diff for D79794: Change the INLINEASM_BR MachineInstr to be a non-terminating instruction..

Differences in new patch, since previous one:

  • Folded in void's change (but I made it in the isSchedulingBoundary() functions, rather than the two callers.
  • Marked the INLINEASM_BR instruction as always having unmodeled side-effects, rather than only if it's marked thus. (not to fix any known miscompilation -- clang always marked it as such anyhow.)
  • Removed FIXME comments, per review comments.
Jun 26 2020, 4:38 PM · Restricted Project

Jun 17 2020

jyknight added inline comments to D81348: [compiler-rt][builtins] Add tests for atomic builtins support functions.
Jun 17 2020, 12:24 PM · Restricted Project

Jun 15 2020

jyknight added inline comments to D81348: [compiler-rt][builtins] Add tests for atomic builtins support functions.
Jun 15 2020, 1:46 PM · Restricted Project

Jun 12 2020

jyknight created D81772: Reduce -Wregister from DefaultError to a default-on warning..
Jun 12 2020, 3:58 PM · Restricted Project
jyknight added a comment to D81607: BreakCriticalEdges for callbr indirect dests.

Disclaimer: I don't plan to rework callbr's operands before landing this. Was that a conditional LGTM?

Wasn't intended to be conditional on any code changes. Just that we don't plan to ever allow jumping to blockaddresses passed in as register operands.

I assume there's something important @fhahn was alluding to, but I'm not sure precisely what, and I would like to make sure everyone's happy with this.

The reason we can't split edges coming out of indirectbr instructions is that in general, there is no way to fix the related blockaddresses in functions that contain multiple indirectbrs. We can't rename the successor in one indirectbr without renaming it in all of them. And if we rename it in all of them, the edge is still critical after the transform.

We want to be sure the same issue doesn't apply to callbr instructions. If it does, then we would need to fix the callers of SplitCriticalEdge, not SplitCriticalEdge itself.

Jun 12 2020, 2:49 PM · Restricted Project
jyknight committed rGca77aa03fef7: Add GNU idutils tag filename to .gitignore. (authored by kaz7).
Add GNU idutils tag filename to .gitignore.
Jun 12 2020, 1:10 PM
jyknight closed D81331: Add GNU idutils tag information file to .gitignore for monorepo..
Jun 12 2020, 1:09 PM · Restricted Project
jyknight updated the diff for D79794: Change the INLINEASM_BR MachineInstr to be a non-terminating instruction..

Just rebase. (Doesn't address review comments)

Jun 12 2020, 1:08 PM · Restricted Project

Jun 9 2020

jyknight added a comment to D81348: [compiler-rt][builtins] Add tests for atomic builtins support functions.

This isn't sufficient to verify that atomic.c actually works properly (which, BTW, it does not). But at least verifying that the basic single-threaded functionality semantics hold is a good start.

Jun 9 2020, 9:52 AM · Restricted Project

Jun 8 2020

jyknight added a comment to D81432: Add #includes so that ROCm.h is compilable stand-alone..

LGTM.

Jun 8 2020, 3:33 PM · Restricted Project

Jun 6 2020

jyknight committed rG748d92b4d314: Simplify MachineVerifier's block-successor verification. (authored by jyknight).
Simplify MachineVerifier's block-successor verification.
Jun 6 2020, 7:44 PM
jyknight committed rG1978309db1f9: MachineBasicBlock::updateTerminator now requires an explicit layout successor. (authored by jyknight).
MachineBasicBlock::updateTerminator now requires an explicit layout successor.
Jun 6 2020, 7:44 PM
jyknight closed D79605: MachineBasicBlock::updateTerminator now requires an explicit layout successor..
Jun 6 2020, 7:44 PM · Restricted Project
jyknight closed D79793: Simplify MachineVerifier's block-successor verification..
Jun 6 2020, 7:44 PM · Restricted Project
jyknight added inline comments to D79605: MachineBasicBlock::updateTerminator now requires an explicit layout successor..
Jun 6 2020, 6:40 PM · Restricted Project
jyknight accepted D81331: Add GNU idutils tag information file to .gitignore for monorepo..
Jun 6 2020, 6:22 AM · Restricted Project

Jun 5 2020

jyknight created D81313: Fix handling of constinit thread_locals with a forward-declared type..
Jun 5 2020, 3:43 PM · Restricted Project

May 27 2020

jyknight added a comment to D80099: [llvm-objcopy][MachO] Add support for removing Swift symbols.

The current state doesn't appear to block it or prevent it in any way

May 27 2020, 12:29 PM · Restricted Project
jyknight committed rGaca3d067efe1: Fix Darwin 'constinit thread_local' variables. (authored by jyknight).
Fix Darwin 'constinit thread_local' variables.
May 27 2020, 9:12 AM
jyknight closed D80417: Fix Darwin 'constinit thread_local' variables..
May 27 2020, 9:12 AM · Restricted Project
jyknight added a comment to D80099: [llvm-objcopy][MachO] Add support for removing Swift symbols.

We already _aren't_ and _cannot_ be compatible with cctools strip's command-line, because cctools strip already has a bunch of one-letter option choices which actively conflict with existing options in llvm-strip (and GNU strip from which we copied them). There's at least -s -R -d -N with conflicting meanings.

May 27 2020, 7:00 AM · Restricted Project

May 26 2020

jyknight added a comment to D80099: [llvm-objcopy][MachO] Add support for removing Swift symbols.

Isn't this potentially problematic from a compatibility point-of-view, since it squats a single-letter command-line argument for a mach-o-specific feature, while llvm-strip is generally trying to be compatible to GNU strip?

May 26 2020, 8:42 PM · Restricted Project

May 24 2020

jyknight accepted D80436: [clang][docs] Document additional bits of libc that -ffreestanding envs must provide.
May 24 2020, 7:28 AM · Restricted Project

May 21 2020

jyknight created D80417: Fix Darwin 'constinit thread_local' variables..
May 21 2020, 4:48 PM · Restricted Project
jyknight added a comment to D79794: Change the INLINEASM_BR MachineInstr to be a non-terminating instruction..

In the review on the prerequisite patch, it turned out there's another thing that needs to be fixed first before this -- disambiguating whether the end of a block falls through, or is actually unreachable.

May 21 2020, 3:11 PM · Restricted Project
jyknight added a comment to D80225: [Driver] Recognize -fuse-ld={bfd,gold,lld} but don't prepend "ld." or "ld64." for other values.

It's worrying to me that there number of places in LLVM that at the exact argument value of "-fuse-ld=". E.g. in the windows and PS4 toolchains. We already claim to support arbitrary values and full paths, but if you specify "-fuse-ld=/path/to/lld-link" on Windows today, you end up with different behavior than "-fuse-ld=lld" (which gets translated to searching for an "lld-link" binary, but also triggers other conditions).

May 21 2020, 10:48 AM · Restricted Project

May 20 2020

jyknight added a comment to D79719: [AIX] Implement AIX special alignment rule about double/long double.

In the commit message, you refer to the preferred alignemtn as the "true" alignment, but that's misleading. As discussed on the mailing list thread, it's not true alignment at all.

May 20 2020, 5:07 PM · Restricted Project, Restricted Project

May 15 2020

jyknight updated the diff for D79793: Simplify MachineVerifier's block-successor verification..

Oops, actually upload changed version. :)

May 15 2020, 8:05 PM · Restricted Project
jyknight added inline comments to D79793: Simplify MachineVerifier's block-successor verification..
May 15 2020, 8:05 PM · Restricted Project
jyknight updated the diff for D79793: Simplify MachineVerifier's block-successor verification..

Fix nits.

May 15 2020, 8:05 PM · Restricted Project
jyknight updated the diff for D79605: MachineBasicBlock::updateTerminator now requires an explicit layout successor..

Handle the case where the apparent fallthrough is not actually a
fallthrough, because the end of the block is unreachable.

May 15 2020, 7:33 PM · Restricted Project
jyknight added inline comments to D79605: MachineBasicBlock::updateTerminator now requires an explicit layout successor..
May 15 2020, 5:24 PM · Restricted Project
jyknight added inline comments to D79793: Simplify MachineVerifier's block-successor verification..
May 15 2020, 1:03 PM · Restricted Project

May 13 2020

jyknight added a comment to D79605: MachineBasicBlock::updateTerminator now requires an explicit layout successor..

Are you planning to land this or D79793 is the alternative approach?

May 13 2020, 9:44 AM · Restricted Project

May 12 2020

jyknight accepted D79511: [ObjC] Add compatibility mode for type checking of qualified id block parameters..

It looks like you didn't squash your two commits before uploading, so the diff for review now only includes the changes for the comment, not the complete patch. Other than needing to squash the commits, LGTM.

May 12 2020, 9:00 PM · Restricted Project
jyknight added a comment to D79605: MachineBasicBlock::updateTerminator now requires an explicit layout successor..

Is the endgame here that we relax the restriction that updateTerminator() requires an analyzable branch?

May 12 2020, 1:27 PM · Restricted Project
jyknight updated the summary of D79793: Simplify MachineVerifier's block-successor verification..
May 12 2020, 10:11 AM · Restricted Project