Page MenuHomePhabricator

rnk (Reid Kleckner)
User

Projects

User Details

User Since
Jan 2 2013, 4:34 PM (464 w, 3 d)

Recent Activity

Wed, Nov 24

rnk added inline comments to D114536: [X86][MS] Fix the wrong alignment of vector variable arguments on Win32.
Wed, Nov 24, 1:50 PM · Restricted Project

Tue, Nov 23

rnk updated subscribers of D114082: [WIP] Normalize String Attributes.

it is possible to list all internal keys in one place

Tue, Nov 23, 12:49 PM · Restricted Project, Restricted Project
rnk updated subscribers of D114394: Compile-time computation of string attribute hashes.

I think @aeubanks might be a good reviewer for this.

Tue, Nov 23, 12:39 PM · Restricted Project, Restricted Project

Mon, Nov 22

rnk added a comment to D111457: [clang][test] Add lit helper for windows paths.

These seem like generic substitutions that would be useful to anyone writing lit tests. We already have %{pathsep}:
https://llvm.org/docs/CommandGuide/lit.html#substitutions

Mon, Nov 22, 11:29 AM · Restricted Project
rnk accepted D114340: [COFF] [ARM64] Create symbols with regular intervals for relocations against temporary symbols.

Just nits

Mon, Nov 22, 11:11 AM · Restricted Project
rnk accepted D113490: [NFC] Let Microsoft mangler accept GlobalDecl.

lgtm

Mon, Nov 22, 8:03 AM · Restricted Project

Tue, Nov 16

rnk added a comment to D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas.

So you won't articulate or document the new invariant and you think there's a llvm-dev discussion that says we can't verify the invariant which you won't reference, but means you won't add this to the verifier.

Request changes doesn't really work after you've applied the patch.

@rnk do you object to me reverting this? I don't think we can add an invariant to IR which is undocumented and unverified/unverifiable and the patch author seems opposed to fixing either omission.

Tue, Nov 16, 9:13 AM · Restricted Project

Mon, Nov 15

rnk accepted D113866: [LLD] [COFF] Omit IMAGE_SYM_CLASS_LABEL symbols from the PE symbol table.

lgtm

Mon, Nov 15, 3:15 PM · Restricted Project
rnk added a comment to D113707: [clang] Make -masm=intel affect inline asm style.

Fairly big update. I'd like to punt on the pragma for now since this became a lot more involved than expected already (see dependent patches; several of them have already landed).

Mon, Nov 15, 2:28 PM · Restricted Project
rnk added a comment to D113866: [LLD] [COFF] Omit IMAGE_SYM_CLASS_LABEL symbols from the PE symbol table.

Seems reasonable, just style nits

Mon, Nov 15, 2:11 PM · Restricted Project
rnk added a comment to D113865: [COFF] Keep temporary symbols in object files on ARM64, as IMAGE_SYM_CLASS_LABEL.

This roughly matches what MSVC does, where the produced object files
contain lots of temporary label symbols named like $LN<n>.

Mon, Nov 15, 10:52 AM · Restricted Project
rnk added a comment to D113027: [libcxx] Remove nonstandard _FilesystemClock::{to,from}_time_t.

How do you handle this with other C++ libraries, do they provide to_sys/from_sys even before C++20, or do they use some other nonstandard method, or were you only using this setup on libc++?

Mon, Nov 15, 10:43 AM · Restricted Project
rnk added inline comments to D92695: [X86ISelLowering] don't emit frame pointers for eflags intrinsics..
Mon, Nov 15, 10:07 AM · Restricted Project

Fri, Nov 12

rnk added a comment to D113707: [clang] Make -masm=intel affect inline asm style.

One alternative would be to control this setting with a pragma stack, like we do for warnings, struct packing, etc. Something like:

Fri, Nov 12, 12:56 PM · Restricted Project
rnk added a comment to D112921: [clang] Enable sized deallocation by default in C++14 onwards.

Let's not bring back the weak function thunk approach. That approach caused problems described in my commit, D8467, which is why the code was removed.

Fri, Nov 12, 9:36 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Nov 11

rnk updated subscribers of D113610: [cmake] Add option LLVM_ENABLE_VISIBILITY_MACROS.

+@tstellar @serge-sans-paille for the recent LLVM_EXTERNAL_VISIBILITY changes
+@compnerd @MaskRay for our discussions about the shared library build

Thu, Nov 11, 1:47 PM · Restricted Project
rnk added a comment to D113707: [clang] Make -masm=intel affect inline asm style.

This seems reasonable, but I worry about headers that contain AT&T style inline asm blobs, such as clang's own intrinsic headers. As you say, the directive is local. I would hate to end up in a place where we have to prefix every asm blob in clang/lib/Headers/*mmintrin.h with ".att_syntax on;".

Thu, Nov 11, 1:19 PM · Restricted Project
rnk added a comment to D8467: C++14: Disable sized deallocation by default due to ABI breakage.

Conceptually, this is (and will always be) a platform decision. On Apple platforms, we have a formalized concept of deployment target, where specific minimum OS versions support sized deallocation and others do not. On most other platforms, this is much vaguer — basically down to what C++ libraries you've got installed — and probably has to be controlled by a flag. Enabling that flag by default on any particular Linux distribution release is something I'm not sure we can do unconditionally.

Thu, Nov 11, 11:59 AM
rnk updated subscribers of D106585: Fix clang debug info irgen of i128 enums.

It seems to have been fixed in rG3c47c5ca13b8a502de3272e8105548715947b7a8.

Thu, Nov 11, 10:59 AM · Restricted Project, Restricted Project

Wed, Nov 10

rnk accepted D113576: [AArch64] [COFF] Move jump tables back to the readonly section.

lgtm

Wed, Nov 10, 10:26 AM · Restricted Project
rnk added a comment to D112492: [CUDA][HIP] Allow comdat for kernels.

I think the key is the self-reference in the LEA instruction:

Wed, Nov 10, 10:25 AM · Restricted Project

Tue, Nov 9

rnk added a comment to D112492: [CUDA][HIP] Allow comdat for kernels.

Yes, we do need to merge identical functions with identical names for templates.

The comdat-folding issue is different. IIUIC, it allows merging two functions with identical code and different names, into one function with two names. That will break CUDA as we do need to have each stub to have a unique address as we use it to find the matching GPU-side kernel.

Tue, Nov 9, 3:27 PM · Restricted Project
rnk added inline comments to D113490: [NFC] Let Microsoft mangler accept GlobalDecl.
Tue, Nov 9, 12:39 PM · Restricted Project
rnk accepted D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas.

I believe you have addressed John's comments, and I think the IR changes mainly affect AMDGPU users, so I don't think this will be too disruptive.

Tue, Nov 9, 11:44 AM · Restricted Project
rnk added inline comments to D112492: [CUDA][HIP] Allow comdat for kernels.
Tue, Nov 9, 11:34 AM · Restricted Project
rnk updated subscribers of D112492: [CUDA][HIP] Allow comdat for kernels.
Tue, Nov 9, 11:31 AM · Restricted Project
rnk accepted D113142: [CodeView] Properly handle a DISubprogram in getScopeIndex..

Looks good

Tue, Nov 9, 10:02 AM · Restricted Project

Mon, Nov 8

rnk added inline comments to D113142: [CodeView] Properly handle a DISubprogram in getScopeIndex..
Mon, Nov 8, 1:21 PM · Restricted Project

Fri, Nov 5

rnk added a comment to D106585: Fix clang debug info irgen of i128 enums.

Reviewing the code, I don't see any obvious sources of non-determinism (hash iteration). The only source I can imagine is uninitialized memory usage in the APInt. Let me know if this can be repro'd somehow.

Fri, Nov 5, 1:21 PM · Restricted Project, Restricted Project
rnk accepted D113265: [DebugInfo] [PDB] Force injected source paths to use backslashes.

lgtm

Fri, Nov 5, 10:37 AM · Restricted Project

Thu, Nov 4

rnk added inline comments to D113142: [CodeView] Properly handle a DISubprogram in getScopeIndex..
Thu, Nov 4, 10:28 AM · Restricted Project

Wed, Nov 3

rnk accepted D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation.

Sorry for the delay

Wed, Nov 3, 3:06 PM · Restricted Project
rnk added a comment to D113142: [CodeView] Properly handle a DISubprogram in getScopeIndex..

Please note that before this patch, getScopeIndex would emit a LF_STRING_ID when given a DISubprogram. That's not only incorrect, but would also cause link-time error with the linker from a more recent version (Aug. 20219) of VS2019.

Wed, Nov 3, 2:45 PM · Restricted Project

Tue, Nov 2

rnk accepted D112859: [X86][VARARG] Assign MMO earlier to avoid prolog insert point been sunk across VASTART_SAVE_XMM_REGS.

lgtm

Tue, Nov 2, 3:29 PM · Restricted Project
rnk accepted D112921: [clang] Enable sized deallocation by default in C++14 onwards.

Looks good from my end.

Tue, Nov 2, 12:32 PM · Restricted Project, Restricted Project, Restricted Project
rnk accepted D112826: [CodeView] Fortran debug info emission in Code View..

Regarding the Windows build, if it isn't reverted or fixed soon, I think the LLVM tests are sufficient. You could disable MLIR and test LLVM in isolation.

Tue, Nov 2, 10:00 AM · Restricted Project

Mon, Nov 1

rnk updated subscribers of D111879: [Support] Add a new path style for Windows with forward slashes.

I am a bit busy at the moment.

Mon, Nov 1, 3:26 PM · Restricted Project
rnk updated subscribers of D112942: target ABI: improve call parameters extensions handling.

Seems reasonable to me. +@aeubanks, can you review this? I think you ran into these issues with SystemZ extension attributes when you made that change to only look at call site ABI attributes.

Mon, Nov 1, 3:17 PM · Restricted Project
rnk added inline comments to D112826: [CodeView] Fortran debug info emission in Code View..
Mon, Nov 1, 1:40 PM · Restricted Project
rnk accepted D112898: [lld] Add test suite mode for running LLD main twice.

lgtm

Mon, Nov 1, 12:44 PM · Restricted Project, Restricted Project
rnk added inline comments to D112399: Get Bazel building `//clang` on Windows with clang-cl..
Mon, Nov 1, 11:01 AM · Restricted Project
rnk added a comment to D112890: headers: optionalise some generated resource headers.

I think this seems reasonable.

Mon, Nov 1, 10:44 AM · Restricted Project
rnk updated subscribers of D107049: [clang-repl] Re-implement clang-interpreter as a test case..

So, to back up a bit, do I understand correctly that this change adds tests to the check-clang test suite that JIT compiles C++ code for the host and throws C++ exceptions? Can we reconsider that?

Mon, Nov 1, 10:37 AM · Restricted Project
rnk added a comment to D112921: [clang] Enable sized deallocation by default in C++14 onwards.

Please add a note to clang/docs/ReleaseNotes.rst about the behavior change.

Mon, Nov 1, 10:26 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Oct 29

rnk added a comment to D8467: C++14: Disable sized deallocation by default due to ABI breakage.

Hi, I am wondering could -fsized-deallocation this be enabled by default nowadays in 2021?

Fri, Oct 29, 11:20 AM

Oct 28 2021

rnk added inline comments to D112399: Get Bazel building `//clang` on Windows with clang-cl..
Oct 28 2021, 3:12 PM · Restricted Project
rnk added inline comments to D112288: Support: Expose sys::path::is_style_{posix,windows,native}().
Oct 28 2021, 2:58 PM · Restricted Project

Oct 27 2021

rnk added a comment to D111875: [Support] [Windows] Manually clean up temp files on network shares.

Thanks for working on this, this was quite the rewrite.

Oct 27 2021, 2:56 PM · Restricted Project

Oct 26 2021

rnk added a comment to D112376: [Support] [Windows] Use the regular RemoveFileOnSignal() mechanism on Windows too.

I think on Windows the RemoveFileOnSignal path doesn't always work when the process is killed, which causes temp files to be left sometimes (see https://reviews.llvm.org/D102736)

Oct 26 2021, 12:33 PM · Restricted Project

Oct 21 2021

rnk added a comment to D112016: [IR] Introduce load assume operand bundle.

Aside from the cost modeling, I think there is value in having a more compact representation for this concept. It is nice to be able to turn four instructions (cast, load, icmp, assume) into one (assume). OK, maybe opaque pointers will remove the cast, but the point stands. This feature also has applications besides C++ devirtualization, so I think it's worth the added maintenance cost.

Oct 21 2021, 10:08 AM · Restricted Project

Oct 20 2021

rnk added inline comments to D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation.
Oct 20 2021, 11:16 AM · Restricted Project
rnk accepted D112157: [clang] Disallow mixing SEH and Objective-C exceptions.

lgtm

Oct 20 2021, 10:52 AM · Restricted Project
rnk added a comment to D112093: Fixes majorOSVersion and majorSubsystemVersion being set into too large values.

I don't think the default of the main COFF linker should be lowered.

But I guess one could argue whether the mingw frontend should set the default target lower - then one doesn't have to change the main default in lld/COFF/Config.h, but tweak the logic in lld/MinGW/Driver.cpp. It currently has to keep a hardcoded default version for some cases, but defaults to the COFF linker's default in some cases. We could make it always pass a version number.

What do @mati865 or @jeremyd2019 think about this?

Oct 20 2021, 10:47 AM · Restricted Project
rnk added a reviewer for D111875: [Support] [Windows] Manually clean up temp files on network shares: akhuang.
Oct 20 2021, 10:32 AM · Restricted Project

Oct 19 2021

rnk updated subscribers of D111875: [Support] [Windows] Manually clean up temp files on network shares.

I think this is reasonable

Oct 19 2021, 2:19 PM · Restricted Project
rnk accepted D112081: Define __STDC_NO_THREADS__ when targeting windows-msvc (PR48704).

lgtm

Oct 19 2021, 8:56 AM · Restricted Project

Oct 18 2021

rnk added a comment to D111875: [Support] [Windows] Manually clean up temp files on network shares.

Well there's a couple uses in TempFile::keep() too. Then again, with a bit more changes, we could stop calling them too, if we aren't using the delete disposition for this file altogether.

Oct 18 2021, 1:58 PM · Restricted Project
rnk added a comment to D112016: [IR] Introduce load assume operand bundle.

happy to change the name if there's a better alternative

Oct 18 2021, 1:51 PM · Restricted Project
rnk added a comment to D111875: [Support] [Windows] Manually clean up temp files on network shares.

Here's an idea to try to make this a bit cleaner. Maybe setDeleteDisposition should return an error code when the path is on a network drive. That return value would be propagated back up to the caller who sets OF_Delete. In this case, that is TempFile::create. At that point, TempFile can retry temporary file creation without OF_Delete.

Hmm... It would indeed be cleaner in the sense that setDeleteDisposition doesn't lie about whether it succeeded or not - but that would require using a specific error code for it that the caller would look for (so we don't retry without the flag for any random error) and hope that we don't map other real system errors to that error code.

Oct 18 2021, 1:37 PM · Restricted Project
rnk added a comment to D111875: [Support] [Windows] Manually clean up temp files on network shares.

Here's an idea to try to make this a bit cleaner. Maybe setDeleteDisposition should return an error code when the path is on a network drive. That return value would be propagated back up to the caller who sets OF_Delete. In this case, that is TempFile::create. At that point, TempFile can retry temporary file creation without OF_Delete.

Oct 18 2021, 12:57 PM · Restricted Project
rnk accepted D111715: [WIP] [lldb] change name demangling to be consistent between windows and linx.

This flag seems reasonable. Microsoft's UnDecorateName API has quite a few of these kinds of things:
https://docs.microsoft.com/en-us/windows/win32/api/dbghelp/nf-dbghelp-undecoratesymbolname

Oct 18 2021, 12:26 PM · Restricted Project, Restricted Project

Oct 15 2021

rnk updated subscribers of D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation.

So, after reading through Build(Unary|Bin)Op, I think the duplication of logic between TreeTransform is intentional, and the better fix is to generalize the existing logic for placeholder handling. If you enter into the Build*Op codepaths, you will re-run a lot of redundant checks. Maybe +@rjmccall can provide a second opinion.

Oct 15 2021, 12:35 PM · Restricted Project

Oct 14 2021

rnk committed rGaeeefe97c686: [bazel] Move MC header usage from Support to tblgen (authored by rnk).
[bazel] Move MC header usage from Support to tblgen
Oct 14 2021, 1:53 PM
rnk closed D111835: [bazel] Move MC header usage from Support to tblgen.
Oct 14 2021, 1:53 PM · Restricted Project
rnk updated the diff for D111835: [bazel] Move MC header usage from Support to tblgen.
  • elaborate
Oct 14 2021, 1:52 PM · Restricted Project
rnk added a comment to D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation.

There are some invariants about what family of APIs TreeTransform methods should call, and I've forgotten what they are, so I'm hesitant to approve this. Test case looks good, though.

Oct 14 2021, 1:41 PM · Restricted Project
rnk requested review of D111835: [bazel] Move MC header usage from Support to tblgen.
Oct 14 2021, 1:37 PM · Restricted Project
rnk accepted D111682: [TableGen][PGO] Disable profile instrumentation for printInstruction function.

lgtm, thanks!

Oct 14 2021, 1:04 PM · Restricted Project
rnk added inline comments to D111682: [TableGen][PGO] Disable profile instrumentation for printInstruction function.
Oct 14 2021, 11:55 AM · Restricted Project
rnk added inline comments to D111682: [TableGen][PGO] Disable profile instrumentation for printInstruction function.
Oct 14 2021, 10:42 AM · Restricted Project

Oct 13 2021

rnk requested changes to D111682: [TableGen][PGO] Disable profile instrumentation for printInstruction function.

Conceptually, it seems fine. As is, this will break the MSVC build, right? It doesn't support __attribute__. You need to add a portability macro in Compiler.h, or use ifdefs inline.

Oct 13 2021, 10:36 AM · Restricted Project

Oct 8 2021

rnk committed rG955dc3449acd: Fix TargetRegistry shlib build, clang edition (authored by rnk).
Fix TargetRegistry shlib build, clang edition
Oct 8 2021, 3:44 PM
rnk committed rGb3a6d096d7c3: Fix shlib builds for all lib/Target/*/TargetInfo libs (authored by rnk).
Fix shlib builds for all lib/Target/*/TargetInfo libs
Oct 8 2021, 3:22 PM
rnk committed rG2827b1b89d0d: Fix shared library build after TargetRegistry move (authored by rnk).
Fix shared library build after TargetRegistry move
Oct 8 2021, 3:12 PM
rnk committed rG89b57061f7b7: Move TargetRegistry.(h|cpp) from Support to MC (authored by rnk).
Move TargetRegistry.(h|cpp) from Support to MC
Oct 8 2021, 2:54 PM
rnk closed D111454: Move TargetRegistry.(h|cpp) from Support to MC.
Oct 8 2021, 2:53 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
rnk updated the diff for D111454: Move TargetRegistry.(h|cpp) from Support to MC.
  • fix formatting issues
Oct 8 2021, 2:40 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
rnk added a comment to D111454: Move TargetRegistry.(h|cpp) from Support to MC.

Thanks for the review! I uploaded it a bit quickly because I wanted to kick off Bazel presubmit testing, since I haven't replicated that locally.

Oct 8 2021, 1:27 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
rnk requested review of D111454: Move TargetRegistry.(h|cpp) from Support to MC.
Oct 8 2021, 12:00 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
rnk committed rG46ef2e0bf995: Update polly for removal of CallInst::arg_operands/getNumArgOperands (authored by rnk).
Update polly for removal of CallInst::arg_operands/getNumArgOperands
Oct 8 2021, 10:46 AM

Oct 6 2021

rnk added a comment to D111195: [clang][Tooling] Use Windows command lines on all Windows, except Cygwin.

This looks ok to me I guess. Technically in this case, this is pretty much equivalent to #ifdef _WIN32, i.e. any form when running on windows, where the process considers itself windows (cygwin doesn't define _WIN32), but I guess keeping it based on getProcessTriple() is fine too.

I'll leave it open for discussion for a while, but if there's no further opinions I can accept it later.

@rnk Do you happen to have any experience here?

Oct 6 2021, 9:47 AM · Restricted Project

Oct 5 2021

rnk added a comment to D109967: Simplify handling of builtin with inline redefinition.

Thanks for doing this, this approach looks like it incorporated my feedback on the previous approach.

Oct 5 2021, 8:44 PM · Restricted Project
rnk accepted D110782: Mark PassBuilder::addPass() as minsize.

It feels a little bit like a micro-optimization, but it's worth 12%.

Oct 5 2021, 8:08 PM · Restricted Project
rnk added a comment to D110885: [NFC][AttributeList] Replace index_begin/end with an iterator.

I had another idle thought on this matter: The unsigned overflow here really isn't that weird. It's the same thing as iterating over the range [-1, 0, #args+1]. We could update all these APIs to traffic in plain signed ints, and then there would be no wrapping, just normal index math.

Oct 5 2021, 3:25 PM · Restricted Project, Restricted Project
rnk accepted D109966: [X86][NFC] structure-return simplificiation.

would you prefer anonymous namespace, or stick with the static fn?

Oct 5 2021, 10:58 AM · Restricted Project

Sep 30 2021

rnk accepted D110885: [NFC][AttributeList] Replace index_begin/end with an iterator.

lgtm

Sep 30 2021, 7:18 PM · Restricted Project, Restricted Project
rnk accepted D110775: Instantiate fewer templates in PassManager::addPass().

I think I understand what's going on: these push_back instantiations are all common instantiations. They are pushing back std::unique_ptr<ZZZConceptT> objects. The emplace_back calls were all unique instantiations depending on the exact pass pointer type.

Sep 30 2021, 9:24 AM · Restricted Project
rnk added a comment to D110782: Mark PassBuilder::addPass() as minsize.

Surely this won't compile with MSVC, though?

Sep 30 2021, 9:15 AM · Restricted Project
rnk accepted D110784: Manually create unique_ptr in various pass adaptors.

This seems relevant:
https://twitter.com/reidkleckner/status/1198108401177251840

Sep 30 2021, 9:13 AM · Restricted Project

Sep 29 2021

rnk added inline comments to D110665: [clang] Don't use the AST to display backend diagnostics.
Sep 29 2021, 11:58 AM · Restricted Project
rnk committed rG2dd883439c78: [Mangler] Calculate the argument list byte count suffix correctly when… (authored by wesleywiser).
[Mangler] Calculate the argument list byte count suffix correctly when…
Sep 29 2021, 11:42 AM
rnk closed D110719: [Mangler] Calculate the argument list byte count suffix correctly when returning large values.
Sep 29 2021, 11:42 AM · Restricted Project
rnk added a comment to D110719: [Mangler] Calculate the argument list byte count suffix correctly when returning large values.

Should I go ahead and push this for you? I will include your email in the commit Author record unless you ask me not to.

That would be great, thank you!

Sep 29 2021, 11:39 AM · Restricted Project
rnk added a comment to D110719: [Mangler] Calculate the argument list byte count suffix correctly when returning large values.

Should I go ahead and push this for you? I will include your email in the commit Author record unless you ask me not to.

Sep 29 2021, 10:49 AM · Restricted Project
rnk accepted D110719: [Mangler] Calculate the argument list byte count suffix correctly when returning large values.

For what it's worth, this issue is not observable from clang because clang does this mangling in the frontend. See https://godbolt.org/z/GM1Evjj3Y, it produces the function name \01_return_large@0. Looking at the code suggests that this is just an accident. It works because it is driven by the AST, which doesn't have the implicit sret parameter.

Sep 29 2021, 10:48 AM · Restricted Project

Sep 28 2021

rnk accepted D110413: [X86] Fix handling of i128<->fp on Windows.

I remember looking at this code and thinking that there must be a better way to do this, but I guess it would entail making i128 legal somehow. Anyway, I don't have a suggestion ready, and this seems like a reasonable extension of the existing approach.

Sep 28 2021, 12:45 PM · Restricted Project

Sep 27 2021

rnk accepted D110419: [TargetLibraryInfo] Pick new/delete calls by target.

lgtm

Sep 27 2021, 3:20 PM · Restricted Project

Sep 24 2021

rnk added inline comments to D110419: [TargetLibraryInfo] Pick new/delete calls by target.
Sep 24 2021, 10:47 AM · Restricted Project
rnk added inline comments to D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas.
Sep 24 2021, 9:23 AM · Restricted Project

Sep 23 2021

rnk accepted D110330: [CodeView] Recognize Fortran95 as Fortran instead of MASM.

lgtm, thanks!

Sep 23 2021, 1:06 PM · Restricted Project