Page MenuHomePhabricator

xbolva00 (Dávid Bolvanský)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 5 2018, 5:18 PM (128 w, 12 h)

Recent Activity

Today

xbolva00 added a comment to D84951: [LV] Try to sink users recursively for first-order recurrences..

Does this patch improve some public benchmarks?

Fri, Sep 18, 12:40 AM · Restricted Project

Yesterday

xbolva00 added a comment to D28907: [SLP] Fix for PR30787: Failure to beneficially vectorize 'copyable' elements in integer binary ops..

Reping

Thu, Sep 17, 2:53 AM · Restricted Project

Wed, Sep 16

xbolva00 added a comment to D86019: [SLC] Optimize mempcpy_chk to mempcpy.

ping

Wed, Sep 16, 12:43 PM · Restricted Project
xbolva00 requested changes to D87326: [ADT] Fix reference invalidation when self referencing a SmallVector.

Tested the newest version of this patch and I'm still seeing massive regressions, even larger than before.

Wed, Sep 16, 1:26 AM · Restricted Project

Sat, Sep 12

xbolva00 updated the diff for D86019: [SLC] Optimize mempcpy_chk to mempcpy.

Updated.

Sat, Sep 12, 7:08 AM · Restricted Project
xbolva00 added a comment to D87479: [InstCombine] Don't sink the fdiv from (fmul (fdiv 1.0, %x), %y) if the fdiv isn't in the same basic block as the fmul.

Ouch, sorry

Sat, Sep 12, 6:35 AM · Restricted Project

Fri, Sep 11

xbolva00 added a comment to D87479: [InstCombine] Don't sink the fdiv from (fmul (fdiv 1.0, %x), %y) if the fdiv isn't in the same basic block as the fmul.

Maybe PR4268 is similar issue..

Fri, Sep 11, 11:11 AM · Restricted Project

Thu, Sep 10

xbolva00 added a comment to D87326: [ADT] Fix reference invalidation when self referencing a SmallVector.
Thu, Sep 10, 2:21 PM · Restricted Project
xbolva00 added inline comments to D86395: [InstCombine] transform pattern "(~A & B) ^ A -> (A | B)" added.
Thu, Sep 10, 1:19 PM · Restricted Project
xbolva00 added a comment to D86395: [InstCombine] transform pattern "(~A & B) ^ A -> (A | B)" added.
Thu, Sep 10, 12:52 PM · Restricted Project

Wed, Sep 9

xbolva00 accepted D87163: [DSE] Switch to MemorySSA-backed DSE by default..

Thanks, amazing work!

Wed, Sep 9, 6:53 AM · Restricted Project, Restricted Project

Mon, Sep 7

xbolva00 added a comment to D87183: [SCCP] Compute ranges for supported intrinsics.

@okura @uenoku Can we copy this logic into AAConstantRange too?

Mon, Sep 7, 3:18 PM · Restricted Project
xbolva00 added inline comments to rG8b300679192b: [InstCombine] improve fold of pointer differences.
Mon, Sep 7, 1:27 PM

Sun, Sep 6

xbolva00 added a comment to D57779: [SLP] Add support for throttling..

Good enough for initial implementation?

Sun, Sep 6, 7:35 AM · Restricted Project
xbolva00 updated the diff for D86019: [SLC] Optimize mempcpy_chk to mempcpy.
Sun, Sep 6, 2:10 AM · Restricted Project
xbolva00 updated the diff for D86019: [SLC] Optimize mempcpy_chk to mempcpy.

Fixed.

Sun, Sep 6, 2:08 AM · Restricted Project

Fri, Sep 4

xbolva00 added inline comments to D87163: [DSE] Switch to MemorySSA-backed DSE by default..
Fri, Sep 4, 2:19 PM · Restricted Project, Restricted Project

Wed, Sep 2

xbolva00 added a comment to D86967: [PassManager] Move load/store motion pass after DSE in LTO pipeline..

. I don't think it's worth adding new options to print the LPM pipelines for a minor change such as this one.

Wed, Sep 2, 4:26 AM · Restricted Project

Tue, Sep 1

xbolva00 updated subscribers of D86967: [PassManager] Move load/store motion pass after DSE in LTO pipeline..

cc @tejohnson

Tue, Sep 1, 1:53 PM · Restricted Project
xbolva00 added a comment to D86967: [PassManager] Move load/store motion pass after DSE in LTO pipeline..

Seems reasonable.

Tue, Sep 1, 1:09 PM · Restricted Project
xbolva00 added a comment to D86815: [LangRef] Adjust guarantee for llvm.memcpy to also allow equal arguments..

Clang/LLVM accepts memcpy(NULL, NULL, 0) while GCC assumes dst/src pointers are not null. LLVM is conservative here.

Tue, Sep 1, 12:27 PM · Restricted Project
xbolva00 retitled D86815: [LangRef] Adjust guarantee for llvm.memcpy to also allow equal arguments. from [LangRef] Adjust guarantee for llvm.memcyp to also allow equal arguments. to [LangRef] Adjust guarantee for llvm.memcpy to also allow equal arguments..
Tue, Sep 1, 12:02 PM · Restricted Project

Sat, Aug 29

xbolva00 added a comment to D37821: [SimplifyCfg] Don't sink loads/stores to geps of allocas.

Since you work with rust-lang, maybe you are interested in this patch. (Patch mentions improvements for rust code).

Sat, Aug 29, 1:11 PM
xbolva00 added a comment to D86395: [InstCombine] transform pattern "(~A & B) ^ A -> (A | B)" added.

No furher comments from me. If possible, commit new tests and rebase this patch.

Sat, Aug 29, 9:25 AM · Restricted Project
xbolva00 added inline comments to D86395: [InstCombine] transform pattern "(~A & B) ^ A -> (A | B)" added.
Sat, Aug 29, 9:01 AM · Restricted Project
xbolva00 added reviewers for D37821: [SimplifyCfg] Don't sink loads/stores to geps of allocas: nikic, jdoerfert, efriedma.
Sat, Aug 29, 8:10 AM
xbolva00 added inline comments to D86395: [InstCombine] transform pattern "(~A & B) ^ A -> (A | B)" added.
Sat, Aug 29, 7:45 AM · Restricted Project
xbolva00 updated subscribers of rG3e69871ab5a6: [InstCombine] Take 2: Perform trivial PHI CSE.

Atleast @spatel @efriedma should really look at it..

Sat, Aug 29, 4:09 AM
xbolva00 added a comment to rG3e69871ab5a6: [InstCombine] Take 2: Perform trivial PHI CSE.

No review?

Sat, Aug 29, 4:05 AM
xbolva00 added a comment to D86815: [LangRef] Adjust guarantee for llvm.memcpy to also allow equal arguments..

Why would we change this? What's the point of having separate memcpy and memmove intrinsics?

I'm reading this as clang mis-uses llvm.memcpy when it probably should be using llvm.memmove

Sat, Aug 29, 1:33 AM · Restricted Project

Fri, Aug 28

xbolva00 added inline comments to D86725: [MemLoc] Support memcmp in MemoryLocation::getForArgument..
Fri, Aug 28, 3:51 AM · Restricted Project

Thu, Aug 27

xbolva00 added a comment to D84108: [SimplifyCFG][LoopRotate] SimplifyCFG: disable common instruction hoisting by default, enable late in pipeline.

But according to https://reviews.llvm.org/D65060#1596212 , the hoinsting should be done..

Thu, Aug 27, 4:23 PM · Restricted Project
xbolva00 added inline comments to D86724: [BuildLibCalls] Add argmemonly to more lib calls..
Thu, Aug 27, 10:18 AM · Restricted Project
xbolva00 added inline comments to D86724: [BuildLibCalls] Add argmemonly to more lib calls..
Thu, Aug 27, 10:04 AM · Restricted Project
xbolva00 added inline comments to D86724: [BuildLibCalls] Add argmemonly to more lib calls..
Thu, Aug 27, 10:00 AM · Restricted Project
xbolva00 added inline comments to D86687: [DAGCombiner] Enhance (zext(setcc)).
Thu, Aug 27, 1:24 AM · Restricted Project

Wed, Aug 26

xbolva00 added a comment to rG71f3169e1bae: [X86] Default to -mtune=generic unless -march is passed to the driver. Add….

Maybe unexpected compile time regression?

Wed, Aug 26, 3:41 PM
xbolva00 added inline comments to D86661: Use properlyDominates in RDFLiveness when sorting on dominance..
Wed, Aug 26, 2:53 PM · Restricted Project
xbolva00 added a comment to D63060: [InstCombine] usub.sat(a, b) + b => umax(a, b) (PR42178).

Thanks!

Wed, Aug 26, 2:06 PM · Restricted Project
xbolva00 added a comment to D86364: [ValueTracking] Interpret GEPs as a series of adds multiplied by the related scaling factor.

Does this (and follow-up patches) improve any public/private benchmarks? Any data?

Wed, Aug 26, 10:49 AM · Restricted Project

Mon, Aug 24

xbolva00 added inline comments to D86487: [DSE,MemorySSA] Check if DomAccess is valid for elimination first..
Mon, Aug 24, 2:24 PM · Restricted Project
xbolva00 retitled D86449: [SelectionDAG] Handle non-power-of-2 bitwidths in expandROT from Summary: [SelectionDAG] Handle non-power-of-2 bitwidths in expandROT to [SelectionDAG] Handle non-power-of-2 bitwidths in expandROT.
Mon, Aug 24, 5:38 AM · Restricted Project

Sun, Aug 23

xbolva00 added inline comments to D77152: [SelectionDAG] Better legalization for FSHL and FSHR.
Sun, Aug 23, 5:40 PM · Restricted Project

Sat, Aug 22

xbolva00 added inline comments to D85097: [Sema] add warning for comparisons like 'x<=y<=z'.
Sat, Aug 22, 4:22 PM · Restricted Project
xbolva00 added a reviewer for D84951: [LV] Try to sink users recursively for first-order recurrences.: bmahjour.
Sat, Aug 22, 8:27 AM · Restricted Project
xbolva00 added inline comments to D86363: InstCombine transform pattern "(A ^ B) | ~(A | B) -> ~(A & B)" added.
Sat, Aug 22, 5:31 AM · Restricted Project
xbolva00 added inline comments to D86395: [InstCombine] transform pattern "(~A & B) ^ A -> (A | B)" added.
Sat, Aug 22, 5:27 AM · Restricted Project
xbolva00 added a comment to D84108: [SimplifyCFG][LoopRotate] SimplifyCFG: disable common instruction hoisting by default, enable late in pipeline.

loops not rotated due to the header size

Sat, Aug 22, 4:39 AM · Restricted Project

Fri, Aug 21

xbolva00 added a comment to D86364: [ValueTracking] Interpret GEPs as a series of adds multiplied by the related scaling factor.

Can your add also IR testcase from that PR? (To show that Instcombine can fold it)

Fri, Aug 21, 12:43 PM · Restricted Project
xbolva00 updated subscribers of D86363: InstCombine transform pattern "(A ^ B) | ~(A | B) -> ~(A & B)" added.
Fri, Aug 21, 12:41 PM · Restricted Project

Thu, Aug 20

xbolva00 added a comment to D85583: [MemDep] Use BatchAA when computing pointer dependencies.

Reverse ping

Thu, Aug 20, 4:11 AM · Restricted Project

Wed, Aug 19

xbolva00 added a comment to D86243: [InstCombine] canonicalize 'not' ops before logical shifts.

Some SCEV/pipeline tests?

Wed, Aug 19, 1:30 PM · Restricted Project

Aug 18 2020

xbolva00 added a comment to D66004: [X86][SSE] SimplifyDemandedVectorEltsForTargetNode - add general shuffle combining support.

Amazing work Simon!

Aug 18 2020, 8:21 AM · Restricted Project

Aug 17 2020

xbolva00 added a comment to D86019: [SLC] Optimize mempcpy_chk to mempcpy.

Eh, copy paste error from memcpy.

Aug 17 2020, 12:21 PM · Restricted Project
xbolva00 updated subscribers of D85781: [BPI] Improve static heuristics for integer comparisons.

No. But I got mails from Eli or Tom.

Aug 17 2020, 12:13 PM · Restricted Project
xbolva00 committed rG0f14b2e6cbb5: Revert "[BPI] Improve static heuristics for integer comparisons" (authored by xbolva00).
Revert "[BPI] Improve static heuristics for integer comparisons"
Aug 17 2020, 11:45 AM
xbolva00 added a reverting change for rG50c743fa7130: [BPI] Improve static heuristics for integer comparisons: rG0f14b2e6cbb5: Revert "[BPI] Improve static heuristics for integer comparisons".
Aug 17 2020, 11:45 AM
xbolva00 added a reverting change for D85781: [BPI] Improve static heuristics for integer comparisons: rG0f14b2e6cbb5: Revert "[BPI] Improve static heuristics for integer comparisons".
Aug 17 2020, 11:45 AM · Restricted Project
xbolva00 added a comment to D85781: [BPI] Improve static heuristics for integer comparisons.

I suggest the following steps to commit this patch:

  1. add an internal option to turn on the new heuristics with default to

false;

  1. commit the patch with minimal test changes;
  1. for each target affected, explicitly modify the tests with the option

turned on and ask the target owner to examine the changes

  1. once all tests are fixed (with option explicitly turned on), flip the

option on by default;

  1. remove the explicit option added in step 3).
Aug 17 2020, 11:39 AM · Restricted Project
xbolva00 added a comment to D85781: [BPI] Improve static heuristics for integer comparisons.

Feedback arrived after things landed. Should I revert everything and split it to many patches and reland?

Aug 17 2020, 11:31 AM · Restricted Project
xbolva00 updated the diff for D86017: [BPI] Improve static heuristics for integer comparisons with CST and non-CST.
Aug 17 2020, 6:05 AM · Restricted Project
xbolva00 added inline comments to rGe6b6787d01e9: [InstCombine] fold abs(X)/X to cmp+select.
Aug 17 2020, 5:22 AM
xbolva00 added a comment to D86017: [BPI] Improve static heuristics for integer comparisons with CST and non-CST.

(I will update all codegen tests after we all agree with direction of this patch)

Aug 17 2020, 2:25 AM · Restricted Project
xbolva00 added inline comments to D86017: [BPI] Improve static heuristics for integer comparisons with CST and non-CST.
Aug 17 2020, 2:25 AM · Restricted Project
xbolva00 updated the diff for D86017: [BPI] Improve static heuristics for integer comparisons with CST and non-CST.

New logic

Aug 17 2020, 2:24 AM · Restricted Project
xbolva00 added inline comments to D86017: [BPI] Improve static heuristics for integer comparisons with CST and non-CST.
Aug 17 2020, 1:52 AM · Restricted Project
xbolva00 added a comment to D85781: [BPI] Improve static heuristics for integer comparisons.

Missed. Some files were adjusted to be regenerated with update scripts, so some changes are bigger than needed.

Aug 17 2020, 1:48 AM · Restricted Project
xbolva00 added inline comments to D86017: [BPI] Improve static heuristics for integer comparisons with CST and non-CST.
Aug 17 2020, 12:53 AM · Restricted Project
xbolva00 added a comment to D85781: [BPI] Improve static heuristics for integer comparisons.

How your last commit differs from the approved one? Why you have so many additional changes in the tests?

Aug 17 2020, 12:31 AM · Restricted Project
xbolva00 added inline comments to D86017: [BPI] Improve static heuristics for integer comparisons with CST and non-CST.
Aug 17 2020, 12:29 AM · Restricted Project

Aug 16 2020

xbolva00 added inline comments to D57779: [SLP] Add support for throttling..
Aug 16 2020, 10:23 AM · Restricted Project

Aug 15 2020

xbolva00 added a comment to D85932: [UpdateTestChecks] Match 'attributes #' at the end.

This is cool!

Aug 15 2020, 2:09 PM · Restricted Project
xbolva00 retitled D86019: [SLC] Optimize mempcpy_chk to mempcpy from [SLC] Optimize _mempcpy_chk to direct call to mempcpy to [SLC] Optimize mempcpy_chk to mempcpy.
Aug 15 2020, 10:09 AM · Restricted Project
xbolva00 added inline comments to D86019: [SLC] Optimize mempcpy_chk to mempcpy.
Aug 15 2020, 9:11 AM · Restricted Project
xbolva00 requested review of D86019: [SLC] Optimize mempcpy_chk to mempcpy.
Aug 15 2020, 9:04 AM · Restricted Project
xbolva00 added a reviewer for D84951: [LV] Try to sink users recursively for first-order recurrences.: ebrevnov.
Aug 15 2020, 6:28 AM · Restricted Project
xbolva00 added a comment to D84951: [LV] Try to sink users recursively for first-order recurrences..

This should help to vectorize this code as well, or?

Aug 15 2020, 6:28 AM · Restricted Project
xbolva00 requested review of D86017: [BPI] Improve static heuristics for integer comparisons with CST and non-CST.
Aug 15 2020, 3:31 AM · Restricted Project
xbolva00 committed rGf134fc4f1b8c: Reland "[SLC] sprintf(dst, "%s", str) -> strcpy(dst, str)" (authored by xbolva00).
Reland "[SLC] sprintf(dst, "%s", str) -> strcpy(dst, str)"
Aug 15 2020, 3:15 AM

Aug 14 2020

xbolva00 committed rGf62de7c9c711: [SLC] Transform strncpy(dst, "text", C) to memcpy(dst, "text\0\0\0", C) for C… (authored by xbolva00).
[SLC] Transform strncpy(dst, "text", C) to memcpy(dst, "text\0\0\0", C) for C…
Aug 14 2020, 4:54 PM
xbolva00 closed D86004: [SLC] Transform strncpy(dst, "text", C) to memcpy(dst, "text\0\0\0", C) for C <= 128 only.
Aug 14 2020, 4:53 PM · Restricted Project
xbolva00 added a reviewer for D86000: Add an unsigned shift base sanitizer: lebedev.ri.
Aug 14 2020, 4:26 PM · Restricted Project, Restricted Project, Restricted Project
xbolva00 requested review of D86004: [SLC] Transform strncpy(dst, "text", C) to memcpy(dst, "text\0\0\0", C) for C <= 128 only.
Aug 14 2020, 4:10 PM · Restricted Project
xbolva00 committed rG6dbf0cfcf789: [SLC] sprintf(dst, "%s", str) -> strcpy(dst, str) (authored by xbolva00).
[SLC] sprintf(dst, "%s", str) -> strcpy(dst, str)
Aug 14 2020, 2:49 PM
xbolva00 closed D85963: [SLC] sprintf(dst, "%s", str) -> strcpy(dst, str).
Aug 14 2020, 2:49 PM · Restricted Project
xbolva00 added a comment to D85963: [SLC] sprintf(dst, "%s", str) -> strcpy(dst, str).

Thank you

Aug 14 2020, 2:47 PM · Restricted Project
xbolva00 added inline comments to D85963: [SLC] sprintf(dst, "%s", str) -> strcpy(dst, str).
Aug 14 2020, 9:18 AM · Restricted Project
xbolva00 added a comment to D85963: [SLC] sprintf(dst, "%s", str) -> strcpy(dst, str).

In the case where we need the return value, there are a couple possible modifications:

  1. Maybe worth checking if the length of the string is a known constant.
  2. We could consider using stpcpy on targets where it's available.
Aug 14 2020, 9:14 AM · Restricted Project
xbolva00 added inline comments to D85963: [SLC] sprintf(dst, "%s", str) -> strcpy(dst, str).
Aug 14 2020, 9:14 AM · Restricted Project
xbolva00 updated the diff for D85963: [SLC] sprintf(dst, "%s", str) -> strcpy(dst, str).

Implemented suggested transformations.

Aug 14 2020, 9:13 AM · Restricted Project
xbolva00 retitled D85963: [SLC] sprintf(dst, "%s", str) -> strcpy(dst, str) from SLC] sprintf(dst, "%s", str) -> strcpy(dst, str) to [SLC] sprintf(dst, "%s", str) -> strcpy(dst, str).
Aug 14 2020, 6:34 AM · Restricted Project
xbolva00 added a reviewer for D85963: [SLC] sprintf(dst, "%s", str) -> strcpy(dst, str): tstellar.
Aug 14 2020, 3:28 AM · Restricted Project
xbolva00 updated the summary of D85963: [SLC] sprintf(dst, "%s", str) -> strcpy(dst, str).
Aug 14 2020, 3:07 AM · Restricted Project
xbolva00 requested review of D85963: [SLC] sprintf(dst, "%s", str) -> strcpy(dst, str).
Aug 14 2020, 2:58 AM · Restricted Project

Aug 13 2020

xbolva00 added a comment to D79485: [BPI] Improve static heuristics for "cold" paths..
Aug 13 2020, 3:50 PM · Restricted Project
xbolva00 committed rGab9fc8bae805: [SLC] sprintf(dst, "%s", str) -> strcpy(dst, str) (authored by xbolva00).
[SLC] sprintf(dst, "%s", str) -> strcpy(dst, str)
Aug 13 2020, 3:08 PM
xbolva00 committed rG18910c4cb5d4: [Tests] Update strncpy tests (authored by xbolva00).
[Tests] Update strncpy tests
Aug 13 2020, 1:38 PM
xbolva00 committed rG5ef2287d36f9: [SLC] Optimize strncpy(a, a, C) to memcpy(a, a000, C) (authored by xbolva00).
[SLC] Optimize strncpy(a, a, C) to memcpy(a, a000, C)
Aug 13 2020, 1:23 PM
xbolva00 added a comment to D85545: [Diagnostics] Diagnose missing comma in string array initialization.

Dňa 13. 8. 2020 o 7:29 užívateľ Arthur Eubanks via Phabricator <reviews@reviews.llvm.org> napísal:

aeubanks added a comment.

It still seems to trigger on structs at head:

$ cat /tmp/a.cc
struct A {

const char *a;
const char *b;
const char *c;

};

static A a = {"",

""
"",
""};

$ ./build/bin/clang++ -Wstring-concatenation -o /dev/null -c /tmp/a.cc
C:/src/tmp/a.cc:10:15: warning: suspicious concatenation of string literals in an array initialization; did you mean to separate the elements with a comma? [-Wstring-concatenation]

"",
^

C:/src/tmp/a.cc:9:15: note: place parentheses around the string literal to silence warning

""
^

1 warning generated.

Repository:
rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85545/new/

https://reviews.llvm.org/D85545

Aug 13 2020, 11:23 AM · Restricted Project
xbolva00 committed rG3944d3df4f06: [Tests] Removed debug copy command (authored by xbolva00).
[Tests] Removed debug copy command
Aug 13 2020, 11:21 AM