Page MenuHomePhabricator

bogner (Justin Bogner)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 12 2014, 3:00 PM (404 w, 4 h)

Recent Activity

Sep 29 2021

bogner accepted D110747: [NFC] Restore magic and magicu to a globally visible location.

LGTM with a nitpick

Sep 29 2021, 11:47 AM · Restricted Project

Jul 21 2021

bogner added a comment to D103935: Add Twine support for std::string_view..

Just ran into this issue (we were a bit behind on integrating upstream) - glad to see it's already fixed. Regarding the following:

Jul 21 2021, 7:15 PM · Restricted Project

Jun 8 2021

bogner committed rG7e976cd45685: [FuzzMutate] Fix getWeight of InstDeleterIRStrategy (authored by bogner).
[FuzzMutate] Fix getWeight of InstDeleterIRStrategy
Jun 8 2021, 11:17 AM
bogner closed D96207: [FuzzMutate] Fix getWeight of InstDeleterIRStrategy.
Jun 8 2021, 11:17 AM · Restricted Project
bogner committed rG4271e1d2c522: [GlobalISel] Handle non-multiples of the base type in narrowScalarAddSub (authored by bogner).
[GlobalISel] Handle non-multiples of the base type in narrowScalarAddSub
Jun 8 2021, 10:14 AM
bogner committed rG2a7e75973498: [GlobalISel] Handle non-multiples of the base type in narrowScalarInsert (authored by bogner).
[GlobalISel] Handle non-multiples of the base type in narrowScalarInsert
Jun 8 2021, 10:14 AM
bogner accepted D103866: GlobalISel: Avoid use of G_INSERT in insertParts.

Some of the test case updates show a lot more code coming out of the legalizer, which is a little bit concerning, but it looks like that's mostly with very unusual types like s112 (though it looks like it comes up a bit for things like s24 as well). That's probably okay though, as I'm guessing later passes will see all the constants and clean this up without too much trouble. Most of the cases with more normal types look like strict improvements I think.

Jun 8 2021, 10:14 AM · Restricted Project
bogner closed D97811: [GlobalISel] Handle non-multiples of the base type in narrowScalarAddSub.
Jun 8 2021, 10:14 AM · Restricted Project
bogner closed D97791: [GlobalISel] Handle non-multiples of the base type in narrowScalarInsert.
Jun 8 2021, 10:14 AM · Restricted Project
bogner added a comment to D96207: [FuzzMutate] Fix getWeight of InstDeleterIRStrategy.

Oh sorry, I missed the comments asking for someone to commit this. I'll commit it for you later today.

Jun 8 2021, 9:37 AM · Restricted Project

Jun 1 2021

bogner accepted D103352: [globalisel][legalizer] Separate the deprecated LegalizerInfo from the current one.

How much work is left to just remove this completely?

Jun 1 2021, 10:39 AM · Restricted Project

May 27 2021

bogner added a comment to D97791: [GlobalISel] Handle non-multiples of the base type in narrowScalarInsert.

@arsenm Other than the high level "we should probably move away from G_EXTRACT/G_INSERT" in legalization" point, do you have any other concerns here? Can we get this in and deal with that more general problem later?

May 27 2021, 11:12 AM · Restricted Project

May 25 2021

bogner added a comment to D102788: [OpaquePtr] Make atomicrmw work with opaque pointers.

Looks like you've already reverted this, but I happened to bugpoint a test case for the failure if you happen to need it. The issue is with the call to popValue if the value the atomicrmw is using hasn't been seen by the parser yet.

May 25 2021, 12:02 PM · Restricted Project

May 24 2021

bogner added inline comments to D102732: [CMake] Don't LTO optimize targets that aren't part of any distribution.
May 24 2021, 8:05 PM · Restricted Project
bogner added inline comments to D102732: [CMake] Don't LTO optimize targets that aren't part of any distribution.
May 24 2021, 3:57 PM · Restricted Project

May 12 2021

bogner committed rGe7d26aceca07: Change the context instruction for computeKnownBits in LoadStoreVectorizer pass (authored by bogner).
Change the context instruction for computeKnownBits in LoadStoreVectorizer pass
May 12 2021, 3:30 PM
bogner closed D101680: Change the context instruction for computeKnownBits in LoadStoreVectorizer pass.
May 12 2021, 3:30 PM · Restricted Project
bogner accepted D101680: Change the context instruction for computeKnownBits in LoadStoreVectorizer pass.

lg. I'll merge this for you shortly

May 12 2021, 2:41 PM · Restricted Project

Apr 30 2021

bogner closed D101576: Add support for llvm.assume intrinsic to the LoadStoreVectorizer pass.

Pushed "954272108587 Add support for llvm.assume intrinsic to the LoadStoreVectorizer pass"

Apr 30 2021, 1:40 PM · Restricted Project
bogner committed rG954272108587: Add support for llvm.assume intrinsic to the LoadStoreVectorizer pass (authored by bogner).
Add support for llvm.assume intrinsic to the LoadStoreVectorizer pass
Apr 30 2021, 1:40 PM
bogner accepted D101576: Add support for llvm.assume intrinsic to the LoadStoreVectorizer pass.
Apr 30 2021, 10:09 AM · Restricted Project

Apr 29 2021

bogner added inline comments to D101576: Add support for llvm.assume intrinsic to the LoadStoreVectorizer pass.
Apr 29 2021, 3:48 PM · Restricted Project

Apr 19 2021

bogner added a comment to D100797: Reset NextFnNum in MachineModuleInfo::initialize.

Probably better to switch all of these to C++11 style default member initializers and remove initialize() entirely. This is obviously correct either way though.

Apr 19 2021, 3:07 PM · Restricted Project
bogner accepted D100797: Reset NextFnNum in MachineModuleInfo::initialize.

Probably better to switch all of these to C++11 style default member initializers and remove initialize() entirely. This is obviously correct either way though.

Apr 19 2021, 2:54 PM · Restricted Project

Mar 31 2021

bogner accepted D99692: [globalisel][unittests] Make it a compiler error to not call setUp() to avoid future rotten green tests.

The title/summary seems a bit confusing. The interesting part of this change is having the set up function return a target machine so it's impossible to miss - IMO renaming it is incidental. This seems reasonable to do, but I think it'd be better titled something along the lines of "Return a target machine from the test setup so that it's structurally required"

Mar 31 2021, 4:54 PM · Restricted Project

Mar 26 2021

bogner added inline comments to D97811: [GlobalISel] Handle non-multiples of the base type in narrowScalarAddSub.
Mar 26 2021, 10:54 AM · Restricted Project
bogner updated the diff for D97811: [GlobalISel] Handle non-multiples of the base type in narrowScalarAddSub.
Mar 26 2021, 10:53 AM · Restricted Project

Mar 2 2021

bogner requested review of D97811: [GlobalISel] Handle non-multiples of the base type in narrowScalarAddSub.
Mar 2 2021, 2:57 PM · Restricted Project
bogner added inline comments to D97791: [GlobalISel] Handle non-multiples of the base type in narrowScalarInsert.
Mar 2 2021, 1:00 PM · Restricted Project
bogner added a comment to D97791: [GlobalISel] Handle non-multiples of the base type in narrowScalarInsert.

I've been thinking we should just stop using G_INSERT/G_EXTRACT for generic legalization. They're weak abstractions over INSERT_SUBREG/EXTRACT_SUBREG, and they probably shouldn't form with illegal types/offsets.

Mar 2 2021, 11:56 AM · Restricted Project
bogner requested review of D97791: [GlobalISel] Handle non-multiples of the base type in narrowScalarInsert.
Mar 2 2021, 11:17 AM · Restricted Project

Feb 17 2021

bogner accepted D96207: [FuzzMutate] Fix getWeight of InstDeleterIRStrategy.
Feb 17 2021, 3:50 PM · Restricted Project
bogner accepted D96341: GlobalISel: Merge some AMDGPU ABI lowering code to generic code.
Feb 17 2021, 2:56 PM · Restricted Project

Feb 3 2021

bogner committed rG62ce4b048ff7: [GlobalISel] Combine narrowScalar of G_ADD and G_SUB. NFC (authored by bogner).
[GlobalISel] Combine narrowScalar of G_ADD and G_SUB. NFC
Feb 3 2021, 11:06 AM

Feb 2 2021

bogner accepted D94533: [clang] Add AddClang.cmake to the list of the CMake modules that are installed.

This seems reasonable

Feb 2 2021, 10:29 AM · Restricted Project, Restricted Project

Jan 26 2021

bogner added a comment to D94901: Add support for using BuildCache (CMake).

I'm not sure this (or the ccache variant) is really necessary any more with modern cmake. Does this do anything different from -DCMAKE_CXX_COMPILER_LAUNCHER=buildcache in practice at this point?

Jan 26 2021, 10:02 AM · Restricted Project

Jan 22 2021

bogner accepted D94905: [FuzzMutate] Add mutator to modify instruction flags..
Jan 22 2021, 2:02 PM · Restricted Project

Dec 21 2020

bogner accepted D93239: GlobalISel: Return APInt from getConstantVRegVal.
Dec 21 2020, 9:54 AM · Restricted Project

Dec 9 2020

bogner committed rGe6a1187dd867: Limit the recursion depth of SelectionDAG::isSplatValue() (authored by bogner).
Limit the recursion depth of SelectionDAG::isSplatValue()
Dec 9 2020, 10:35 AM
bogner closed D92421: Limit the recursion depth of SelectionDAG::isSplatValue().
Dec 9 2020, 10:35 AM · Restricted Project
bogner added a comment to D92421: Limit the recursion depth of SelectionDAG::isSplatValue().

Friendly ping. Can someone with commit privileges land this please?

Dec 9 2020, 10:06 AM · Restricted Project

Dec 3 2020

bogner added a reverting change for rGd5268ebe1925: [test] Add a triple to an x86 test: rG203748e76dae: Revert "[test] Add a triple to an x86 test".
Dec 3 2020, 2:22 PM
bogner committed rG203748e76dae: Revert "[test] Add a triple to an x86 test" (authored by bogner).
Revert "[test] Add a triple to an x86 test"
Dec 3 2020, 2:22 PM
bogner committed rGd5268ebe1925: [test] Add a triple to an x86 test (authored by bogner).
[test] Add a triple to an x86 test
Dec 3 2020, 2:10 PM

Dec 1 2020

bogner accepted D92421: Limit the recursion depth of SelectionDAG::isSplatValue().

LGTM once it actually compiles (we'll certainly need to call isSplatValue with a depth of zero somewhere)

Dec 1 2020, 2:07 PM · Restricted Project

Aug 20 2020

bogner committed rG1283dca0076b: [GISel] Correct the known bits of G_ANYEXT (authored by bogner).
[GISel] Correct the known bits of G_ANYEXT
Aug 20 2020, 5:17 PM
bogner closed D86323: [GISel] Correct the known bits of G_ANYEXT.
Aug 20 2020, 5:17 PM · Restricted Project
bogner requested review of D86323: [GISel] Correct the known bits of G_ANYEXT.
Aug 20 2020, 5:07 PM · Restricted Project

Jul 27 2020

bogner committed rG4b5412b5dbc8: Fix the move constructor of MMI to move MachineFunctions map (authored by sridhar_gopinath).
Fix the move constructor of MMI to move MachineFunctions map
Jul 27 2020, 2:10 PM
bogner closed D84274: Fixed move constructor of MMI to move MachineFunctions map.
Jul 27 2020, 2:10 PM · Restricted Project

Jul 24 2020

bogner accepted D84565: [Darwin] [Driver] Clang should invoke dsymutil for lto builds -g*.
Jul 24 2020, 4:36 PM · Restricted Project

Jul 22 2020

bogner accepted D84274: Fixed move constructor of MMI to move MachineFunctions map.

LGTM. Do you need me to commit this for you?

Jul 22 2020, 9:52 AM · Restricted Project

Jun 1 2020

bogner accepted D80960: Support other llc-like tools in update_llc_test_checks.py.

Seems straightforward enough. A couple of minor nitpicks.

Jun 1 2020, 3:43 PM · Restricted Project

Mar 3 2020

bogner committed rG831fe8dc4c70: Restore `REQUIRES: default_triple` to a test (authored by bogner).
Restore `REQUIRES: default_triple` to a test
Mar 3 2020, 9:57 AM

Feb 24 2020

bogner accepted D75032: [MachineVerifier] Doing ::calcRegsPassed in RPO: ~35% faster MV.
Feb 24 2020, 2:15 AM · Restricted Project

Jan 23 2020

bogner committed rGb81a337be7bc: [LoopUnroll] Avoid UB when converting from WeakVH to `Value *` (authored by bogner).
[LoopUnroll] Avoid UB when converting from WeakVH to `Value *`
Jan 23 2020, 10:38 AM
bogner closed D73280: [LoopUnroll] Avoid UB when converting from WeakVH to `Value *`.
Jan 23 2020, 10:38 AM · Restricted Project
bogner created D73280: [LoopUnroll] Avoid UB when converting from WeakVH to `Value *`.
Jan 23 2020, 10:30 AM · Restricted Project
bogner added inline comments to D71640: [docs] Remove `git llvm push` and `git llvm revert` from GettingStarted.
Jan 23 2020, 10:11 AM · Restricted Project

Dec 17 2019

bogner committed rGb6f5caa48f1f: [docs] Remove `git llvm push` and `git llvm revert` from GettingStarted (authored by bogner).
[docs] Remove `git llvm push` and `git llvm revert` from GettingStarted
Dec 17 2019, 5:19 PM
bogner closed D71640: [docs] Remove `git llvm push` and `git llvm revert` from GettingStarted.

b6f5caa48f1

Dec 17 2019, 5:19 PM · Restricted Project
bogner created D71640: [docs] Remove `git llvm push` and `git llvm revert` from GettingStarted.
Dec 17 2019, 5:19 PM · Restricted Project

Dec 9 2019

bogner accepted D71182: [NFC][llvm][MIRVRegNamerUtils] Making some stylistic changes to MIRVRegNamerUtils.cpp.

The std::transform better expresses the intent IMO. I think that it is definitely more idiomatic C++, so I think that is an improvement.

I agree with this. Was going through the changes in this util in my downtime and just saw some opportunities to spruce some things up. I find it really odd that you'd have a HashOperand lambda and not want to apply that to your collection of uses from a llvm::transform.

Dec 9 2019, 3:21 PM · Restricted Project
bogner accepted D70917: [NFC] Use EVT instead of bool for getSetCCInverse().

lgtm

Dec 9 2019, 2:44 PM · Restricted Project

Nov 14 2019

bogner accepted D70210: [MirNamer][Canonicalizer]: Perform instruction semantic based renaming .

LGTM once Puyan's feedback is addressed

Nov 14 2019, 6:09 PM · Restricted Project

Oct 14 2019

bogner accepted D68905: [update_mir_test_checks] Handle MI flags properly.

LGTM

Oct 14 2019, 10:15 AM · Restricted Project

Oct 9 2019

bogner accepted D68748: Add FMF to vector ops for phi.

Seems obviously correct to me.

Oct 9 2019, 5:35 PM · Restricted Project

Sep 24 2019

bogner committed rGa80048f3df29: Use double quotes for LDFLAGS in -DLLVM_BUILD_INSTRUMENTED_COVERAGE (authored by bogner).
Use double quotes for LDFLAGS in -DLLVM_BUILD_INSTRUMENTED_COVERAGE
Sep 24 2019, 4:56 PM
bogner committed rL372791: Use double quotes for LDFLAGS in -DLLVM_BUILD_INSTRUMENTED_COVERAGE.
Use double quotes for LDFLAGS in -DLLVM_BUILD_INSTRUMENTED_COVERAGE
Sep 24 2019, 4:54 PM

Sep 18 2019

bogner accepted D67601: TLI: Remove DAG argument from getRegisterByName.

Regardless of what we want to do with getRegisterByName (ie, rename it to something more targeted, generalize it, etc) this change on its own is a strict improvement. LGTM.

Sep 18 2019, 10:49 AM

Aug 30 2019

bogner committed rL370536: Request commit access for bogner.
Request commit access for bogner
Aug 30 2019, 2:40 PM

Aug 15 2019

bogner committed rGe7c220c0ef94: [cmake] install_symlink should obey DESTDIR unconditionally (authored by bogner).
[cmake] install_symlink should obey DESTDIR unconditionally
Aug 15 2019, 8:36 AM
bogner committed rL369011: [cmake] install_symlink should obey DESTDIR unconditionally.
[cmake] install_symlink should obey DESTDIR unconditionally
Aug 15 2019, 8:36 AM

Aug 14 2019

bogner accepted D39339: [CallGraph] Refine call graph for indirect calls with !callees metadata.

LGTM

Aug 14 2019, 2:23 PM · Restricted Project
bogner added inline comments to D39339: [CallGraph] Refine call graph for indirect calls with !callees metadata.
Aug 14 2019, 9:59 AM · Restricted Project
bogner added inline comments to D39339: [CallGraph] Refine call graph for indirect calls with !callees metadata.
Aug 14 2019, 9:40 AM · Restricted Project

Aug 12 2019

bogner accepted D66039: [GlobalISel]: Fix a bug in KnownBits where we should have been using SizeInBits.

Obvious bugfixes like this can generally be post-commit reviewed.

Aug 12 2019, 1:55 PM · Restricted Project

Jul 29 2019

bogner accepted D65298: [DivRemPairs] Handling for expanded-form rem - recomposition (PR42673).

LGTM

Jul 29 2019, 1:41 PM · Restricted Project

Jul 19 2019

bogner accepted D65011: Expand pseudo-components before embedding in llvm-config.

LGTM

Jul 19 2019, 1:34 PM · Restricted Project

Jul 16 2019

bogner committed rG418516c7b865: [TableGen] Generate offsets into a flat array for getOperandType (authored by bogner).
[TableGen] Generate offsets into a flat array for getOperandType
Jul 16 2019, 3:41 PM
bogner committed rL366278: [TableGen] Generate offsets into a flat array for getOperandType.
[TableGen] Generate offsets into a flat array for getOperandType
Jul 16 2019, 3:41 PM
bogner committed rGfe66fdb8f307: [TableGen] Add "getOperandType" to get operand types from opcode/opidx (authored by bogner).
[TableGen] Add "getOperandType" to get operand types from opcode/opidx
Jul 16 2019, 3:11 PM
bogner committed rL366274: [TableGen] Add "getOperandType" to get operand types from opcode/opidx.
[TableGen] Add "getOperandType" to get operand types from opcode/opidx
Jul 16 2019, 3:10 PM
bogner closed D63320: [TableGen] Add "getOperandType" to get operand types from opcode/opidx.
Jul 16 2019, 3:10 PM · Restricted Project

Jul 8 2019

bogner accepted D56265: [DebugInfo] MCP: collect and update DBG_VALUEs encountered in local block.

Seems reasonable to me

Jul 8 2019, 3:36 PM · Restricted Project

Jun 19 2019

bogner accepted D63496: [WIP] CodeGen: Prototype class for registers.
Jun 19 2019, 4:38 PM
bogner added inline comments to D63496: [WIP] CodeGen: Prototype class for registers.
Jun 19 2019, 4:38 PM

Jun 18 2019

bogner accepted D32628: Rename ExpandISelPseudo->FinalizeISel, delay register reservation.
Jun 18 2019, 4:00 PM · Restricted Project

Jun 17 2019

bogner added a comment to D61321: [globalisel] Allow SrcOp to convert an APInt and render it as an immediate operand (MO.isImm() == true).

How terrible would it be to use APInt as the interface type, but then store it as int64_t?

That seems like a good compromise to me.

Jun 17 2019, 12:01 PM · Restricted Project
bogner added a comment to D63205: Virtualize TargetInstrInfo::getRegClass().

Maybe I'm missing something, but the override implemented in D63204 looks like a subset of the default TII::getRegClass that falls through to TRI::getRegClass, just like the default does. Is this change actually necessary?

Jun 17 2019, 11:36 AM · Restricted Project

Jun 12 2019

bogner accepted D52369: [tblgen][disasm] Allow multiple encodings to disassemble to the same instruction.

Sorry for the delay! This LGTM

Jun 12 2019, 12:29 PM · Restricted Project

Jun 5 2019

bogner added a comment to D32628: Rename ExpandISelPseudo->FinalizeISel, delay register reservation.

So if I'm reading this right this just basically just delays TLI->finalizeLowering to the end of ExpandISelPseudos/FinalizeISel. Is there motivation to this other than it makes more logical sense to freeze registers as close to regalloc as possible?

Jun 5 2019, 4:38 PM · Restricted Project

May 30 2019

bogner accepted D62617: [MIR-Canon] Fixing case where MachineFunction is empty..
May 30 2019, 2:16 PM · Restricted Project
bogner added inline comments to D62617: [MIR-Canon] Fixing case where MachineFunction is empty..
May 30 2019, 11:41 AM · Restricted Project
bogner accepted D62693: Support codesigning bundles and forcing.

Seems straightforward enough

May 30 2019, 10:54 AM · Restricted Project, Restricted Project
bogner accepted D62438: Break a couple more false dependencies on target libraries.

For future reference, obvious follow ups like this are fine for post-commit review

May 30 2019, 10:34 AM · Restricted Project

May 29 2019

bogner added inline comments to D62617: [MIR-Canon] Fixing case where MachineFunction is empty..
May 29 2019, 12:28 PM · Restricted Project
bogner accepted D62543: [MIR-Canon] Add support for rewriting VRegs that are typed but don't have an RC..

lgtm once you've addressed compnerd's comments

May 29 2019, 12:25 PM · Restricted Project

May 23 2019

bogner accepted D62331: Break false dependencies on target libraries.

This looks great. Looking forward to faster incremental builds!

May 23 2019, 1:23 PM · Restricted Project

Apr 25 2019

bogner committed rGdf5d2b3846d9: [GlobalOpt] Swap the expensive check for cold calls with the cheap TTI check (authored by bogner).
[GlobalOpt] Swap the expensive check for cold calls with the cheap TTI check
Apr 25 2019, 5:11 PM