Page MenuHomePhabricator

zequanwu (Zequan Wu)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 31 2020, 4:54 PM (42 w, 4 d)

Recent Activity

Yesterday

zequanwu committed rG867bdfeff178: [InstCombine] remove incompatible attribute when simplifying some lib calls (authored by zequanwu).
[InstCombine] remove incompatible attribute when simplifying some lib calls
Fri, Jan 22, 5:28 PM
zequanwu closed D95278: [InstCombine] remove incompatible attribute when simplifying some lib calls.
Fri, Jan 22, 5:28 PM · Restricted Project
zequanwu updated the summary of D95278: [InstCombine] remove incompatible attribute when simplifying some lib calls.
Fri, Jan 22, 5:18 PM · Restricted Project
zequanwu requested review of D95278: [InstCombine] remove incompatible attribute when simplifying some lib calls.
Fri, Jan 22, 5:14 PM · Restricted Project

Thu, Jan 14

zequanwu committed rG4fffbc150cca: [clang][MSVC] Fix missing MSInheritanceAttr in template specialization. (authored by zequanwu).
[clang][MSVC] Fix missing MSInheritanceAttr in template specialization.
Thu, Jan 14, 10:38 AM
zequanwu closed D94646: [clang][MSVC] Fix missing MSInheritanceAttr in template specialization..
Thu, Jan 14, 10:38 AM · Restricted Project
zequanwu updated the diff for D94646: [clang][MSVC] Fix missing MSInheritanceAttr in template specialization..

Address comment.

Thu, Jan 14, 10:04 AM · Restricted Project
zequanwu added inline comments to D94646: [clang][MSVC] Fix missing MSInheritanceAttr in template specialization..
Thu, Jan 14, 9:57 AM · Restricted Project
zequanwu updated the diff for D94646: [clang][MSVC] Fix missing MSInheritanceAttr in template specialization..

Update test case.

Thu, Jan 14, 9:56 AM · Restricted Project

Wed, Jan 13

zequanwu added inline comments to D94646: [clang][MSVC] Fix missing MSInheritanceAttr in template specialization..
Wed, Jan 13, 7:18 PM · Restricted Project
zequanwu requested review of D94646: [clang][MSVC] Fix missing MSInheritanceAttr in template specialization..
Wed, Jan 13, 7:15 PM · Restricted Project

Tue, Jan 12

zequanwu committed rGe53bbd99516f: [IR] move nomerge attribute from function declaration/definition to callsites (authored by zequanwu).
[IR] move nomerge attribute from function declaration/definition to callsites
Tue, Jan 12, 12:11 PM
zequanwu closed D94537: [IR] move nomerge attribute from function declaration/definition to callsites.
Tue, Jan 12, 12:11 PM · Restricted Project
zequanwu requested review of D94537: [IR] move nomerge attribute from function declaration/definition to callsites.
Tue, Jan 12, 11:24 AM · Restricted Project

Dec 17 2020

zequanwu committed rGfb0f7288051e: [Clang] Make nomerge attribute a function attribute as well as a statement… (authored by zequanwu).
[Clang] Make nomerge attribute a function attribute as well as a statement…
Dec 17 2020, 7:46 AM
zequanwu closed D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute..
Dec 17 2020, 7:46 AM · Restricted Project, Restricted Project

Dec 16 2020

zequanwu added inline comments to D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute..
Dec 16 2020, 5:36 PM · Restricted Project, Restricted Project
zequanwu updated the diff for D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute..

address comments.

Dec 16 2020, 5:35 PM · Restricted Project, Restricted Project

Dec 15 2020

zequanwu added inline comments to D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute..
Dec 15 2020, 5:01 PM · Restricted Project, Restricted Project
zequanwu updated the diff for D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute..

address comments.

Dec 15 2020, 5:01 PM · Restricted Project, Restricted Project

Dec 14 2020

zequanwu committed rGb6b522c4db17: [NFC] cleanup cg-profile emission on TargetLowerinng (authored by zequanwu).
[NFC] cleanup cg-profile emission on TargetLowerinng
Dec 14 2020, 1:08 PM
zequanwu closed D93150: [NFC] cleanup cg-profile emission on TargetLowerinng.
Dec 14 2020, 1:08 PM · Restricted Project
zequanwu updated the diff for D93150: [NFC] cleanup cg-profile emission on TargetLowerinng.

address comment.

Dec 14 2020, 1:07 PM · Restricted Project

Dec 11 2020

zequanwu requested review of D93150: [NFC] cleanup cg-profile emission on TargetLowerinng.
Dec 11 2020, 5:35 PM · Restricted Project
zequanwu abandoned D92623: [inliner] Apply nomerge attribute to all call sites inside inlined function..
Dec 11 2020, 12:49 PM · Restricted Project

Dec 10 2020

zequanwu added inline comments to D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute..
Dec 10 2020, 4:37 PM · Restricted Project, Restricted Project
zequanwu updated the diff for D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute..

Add docs.

Dec 10 2020, 4:37 PM · Restricted Project, Restricted Project
zequanwu added inline comments to D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute..
Dec 10 2020, 3:41 PM · Restricted Project, Restricted Project
zequanwu added inline comments to D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute..
Dec 10 2020, 3:39 PM · Restricted Project, Restricted Project
zequanwu updated the diff for D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute..

Add test for virutal function.

Dec 10 2020, 3:39 PM · Restricted Project, Restricted Project
zequanwu committed rGb5216b295049: [PGO] Enable preinline and cleanup when optimize for size (authored by zequanwu).
[PGO] Enable preinline and cleanup when optimize for size
Dec 10 2020, 12:30 PM
zequanwu closed D91673: [PGO] Enable preinline and cleanup when optimize for size.
Dec 10 2020, 12:29 PM · Restricted Project, Restricted Project

Dec 9 2020

zequanwu updated the summary of D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute..
Dec 9 2020, 9:17 PM · Restricted Project, Restricted Project
zequanwu retitled D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute. from [Clang] Add disable-merge function attribute which generates nomerge function attribute in IR to [Clang] Make nomerge attribute a function attribute as well as a statement attribute..
Dec 9 2020, 9:16 PM · Restricted Project, Restricted Project
zequanwu updated the diff for D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute..

start a new diff to make nomerge attribute a function attribute as well as a statement attribute.

Dec 9 2020, 9:14 PM · Restricted Project, Restricted Project
zequanwu abandoned D92510: [lldb] set created function decl to public access in TypeSystemClang.

Adrian said he will work on this, so I abandoned this.

Dec 9 2020, 4:52 PM · Restricted Project
zequanwu updated the diff for D91673: [PGO] Enable preinline and cleanup when optimize for size.
  • fix existing failed testcase.
  • add new testcases for npm and lpm.
  • add comments.
Dec 9 2020, 12:45 PM · Restricted Project, Restricted Project

Dec 7 2020

zequanwu requested review of D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute..
Dec 7 2020, 4:53 PM · Restricted Project, Restricted Project
zequanwu added a comment to D92623: [inliner] Apply nomerge attribute to all call sites inside inlined function..

According to: https://clang.llvm.org/docs/AttributeReference.html#nomerge, the existance of the attribute should prevent call site merging, so the change makes sense.
However, in the test example then, if there was branching and two @f calls inside @bar, it would be correct to merge the @f call sites (no attribute preventing that inside) when processing @bar. But after inlining, that's no longer allowed if the attribute is distributed to all callsites inside the function.
This is a contradiction that needs clarification from folks more familiar with the Inliner.

Dec 7 2020, 2:06 PM · Restricted Project

Dec 3 2020

zequanwu requested review of D92623: [inliner] Apply nomerge attribute to all call sites inside inlined function..
Dec 3 2020, 5:29 PM · Restricted Project

Dec 2 2020

zequanwu requested review of D92510: [lldb] set created function decl to public access in TypeSystemClang.
Dec 2 2020, 2:18 PM · Restricted Project

Dec 1 2020

zequanwu updated the diff for D91673: [PGO] Enable preinline and cleanup when optimize for size.
  • sync NPM with LPM.
  • use PreInlineThreshold flag value instead of hardcode number.
Dec 1 2020, 4:18 PM · Restricted Project, Restricted Project
zequanwu added a comment to D92349: [libcxx] remove checks for __STDCPP_THREADS__ as it is defined by compiler.

@zequanwu In the future, please refrain from committing to libc++ or libc++abi unless you have approval of the libcxx or libcxxabi review group. There's a reason why that group is added as a "blocking reviewer", it's because you should wait for it to be green before proceeding.

Dec 1 2020, 10:31 AM · Restricted Project

Nov 30 2020

zequanwu committed rG871f96eed379: [libcxx] remove checks for __STDCPP_THREADS__ as it is defined by compiler (authored by zequanwu).
[libcxx] remove checks for __STDCPP_THREADS__ as it is defined by compiler
Nov 30 2020, 4:37 PM
zequanwu retitled D92349: [libcxx] remove checks for __STDCPP_THREADS__ as it is defined by compiler from [libcxxabi] remove checks for __STDCPP_THREADS__ as it is defined by compiler to [libcxx] remove checks for __STDCPP_THREADS__ as it is defined by compiler.
Nov 30 2020, 4:37 PM · Restricted Project
zequanwu closed D92349: [libcxx] remove checks for __STDCPP_THREADS__ as it is defined by compiler.
Nov 30 2020, 4:37 PM · Restricted Project
zequanwu updated the diff for D92349: [libcxx] remove checks for __STDCPP_THREADS__ as it is defined by compiler.

address comment.

Nov 30 2020, 2:45 PM · Restricted Project
zequanwu added a comment to D91673: [PGO] Enable preinline and cleanup when optimize for size.
In D91673#2401578, @xur wrote:

This is probably OK for -Os (SizeLevel == 1), but we need to be careful with Oz (SizeLevel == 2).
We already know that enabling preinliner in general will reduce size -- as the preinliner is pretty conservative. But there will be cases size will be increased.

I would like more test results (like bootstrap clang) before committing.

Nov 30 2020, 2:27 PM · Restricted Project, Restricted Project
zequanwu requested review of D92349: [libcxx] remove checks for __STDCPP_THREADS__ as it is defined by compiler.
Nov 30 2020, 2:09 PM · Restricted Project
zequanwu added a comment to D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros.
In D91747#2423960, @rnk wrote:

If we believe the standard says that the compiler is supposed to set __STDCPP_THREADS__, then I think the libc++ #error needs to be adjusted. libcxxabi, or any other client, should be able to define _LIBCPP_HAS_NO_THREADS, and it should work, even if the compiler thinks they are allowed.

Nov 30 2020, 1:37 PM · Restricted Project

Nov 22 2020

zequanwu committed rG15a3ae1ab1a6: [Clang] Add __STDCPP_THREADS__ to standard predefine macros (authored by zequanwu).
[Clang] Add __STDCPP_THREADS__ to standard predefine macros
Nov 22 2020, 4:06 PM
zequanwu closed D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros.
Nov 22 2020, 4:06 PM · Restricted Project

Nov 20 2020

zequanwu added inline comments to D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros.
Nov 20 2020, 2:05 PM · Restricted Project
zequanwu updated the diff for D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros.

Update tests.

Nov 20 2020, 2:04 PM · Restricted Project
zequanwu updated the diff for D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros.

Add ThreadModel to LangOptions and remove it from CodegenOption.

Nov 20 2020, 10:00 AM · Restricted Project

Nov 19 2020

zequanwu updated the diff for D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros.

Add a test case.

Nov 19 2020, 5:07 PM · Restricted Project

Nov 18 2020

zequanwu requested review of D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros.
Nov 18 2020, 3:29 PM · Restricted Project

Nov 17 2020

zequanwu updated the diff for D91673: [PGO] Enable preinline and cleanup when optimize for size.

update wrong diff.

Nov 17 2020, 6:06 PM · Restricted Project, Restricted Project
zequanwu requested review of D91673: [PGO] Enable preinline and cleanup when optimize for size.
Nov 17 2020, 6:03 PM · Restricted Project, Restricted Project
zequanwu abandoned D89590: [NPM][SimplifyCFGPass] For OptForFuzzing attribute, disable SimplifyCondBranch and FoldTwoEntryPHINode in NPM.
Nov 17 2020, 2:37 PM · Restricted Project
zequanwu abandoned D89917: Revert "SimplifyCFG: Clean up optforfuzzing implementation".
Nov 17 2020, 2:37 PM · Restricted Project

Nov 10 2020

zequanwu committed rG78b48426a282: [llvm-cov] Add a test for c75a0a1e (authored by zequanwu).
[llvm-cov] Add a test for c75a0a1e
Nov 10 2020, 2:26 PM

Nov 6 2020

zequanwu added inline comments to D89359: [llvm-cov] don't include all source files when provided source files are filtered out.
Nov 6 2020, 2:54 PM · Restricted Project
zequanwu committed rGc75a0a1e9dc2: [llvm-cov] Fix missing slash in -path-equivalence (authored by zequanwu).
[llvm-cov] Fix missing slash in -path-equivalence
Nov 6 2020, 2:54 PM

Oct 30 2020

zequanwu committed rG4348e0eee4dd: [lldb][NFC] Refactor getUUID functionality (authored by zequanwu).
[lldb][NFC] Refactor getUUID functionality
Oct 30 2020, 10:45 AM
zequanwu closed D90325: [lldb][NFC] Refactor getUUID functionality.
Oct 30 2020, 10:45 AM · Restricted Project
zequanwu updated the diff for D90325: [lldb][NFC] Refactor getUUID functionality.

Address comments.

Oct 30 2020, 10:44 AM · Restricted Project

Oct 29 2020

zequanwu updated the diff for D90325: [lldb][NFC] Refactor getUUID functionality.

Address comments.

Oct 29 2020, 11:17 AM · Restricted Project

Oct 28 2020

zequanwu updated the diff for D90325: [lldb][NFC] Refactor getUUID functionality.

include correct header

Oct 28 2020, 12:16 PM · Restricted Project
zequanwu requested review of D90325: [lldb][NFC] Refactor getUUID functionality.
Oct 28 2020, 11:24 AM · Restricted Project

Oct 26 2020

zequanwu added a comment to D89812: [lldb][PDB] Add ObjectFile PDB plugin.

load-pdb is still failing on the Windows bot. Can you please commit a fix soon or revert the change?

Oct 26 2020, 5:14 PM · Restricted Project
zequanwu committed rG779deb9750a4: [lldb][NativePDB] fix test load-pdb.cpp (authored by zequanwu).
[lldb][NativePDB] fix test load-pdb.cpp
Oct 26 2020, 5:13 PM
zequanwu added a comment to D89812: [lldb][PDB] Add ObjectFile PDB plugin.

load-pdb is still failing on the Windows bot. Can you please commit a fix soon or revert the change?

Oct 26 2020, 2:54 PM · Restricted Project
zequanwu added a reverting change for rGa2ac64dd9054: Revert "Ensure that checkInitIsICE is called exactly once for every variable": rGe56e7bd4698d: Revert "Revert "Ensure that checkInitIsICE is called exactly once for every….
Oct 26 2020, 12:09 PM
zequanwu committed rGe56e7bd4698d: Revert "Revert "Ensure that checkInitIsICE is called exactly once for every… (authored by zequanwu).
Revert "Revert "Ensure that checkInitIsICE is called exactly once for every…
Oct 26 2020, 12:09 PM
zequanwu added a reverting change for rG76c009266586: Ensure that checkInitIsICE is called exactly once for every variable: rGa2ac64dd9054: Revert "Ensure that checkInitIsICE is called exactly once for every variable".
Oct 26 2020, 12:00 PM
zequanwu committed rGa2ac64dd9054: Revert "Ensure that checkInitIsICE is called exactly once for every variable" (authored by zequanwu).
Revert "Ensure that checkInitIsICE is called exactly once for every variable"
Oct 26 2020, 12:00 PM
zequanwu added a comment to D89812: [lldb][PDB] Add ObjectFile PDB plugin.

It has regressed buildbots:

SymbolFile/NativePDB/load-pdb.cpp
lldb-x86_64-fedora: http://lab.llvm.org:8014/#/builders/14/builds/1006
lldb-x86_64-debian: http://lab.llvm.org:8011/#/builders/68/builds/782
Oct 26 2020, 11:39 AM · Restricted Project
zequanwu committed rG4b83747ab157: [lldb][NativePDB] fix test load-pdb.cpp (authored by zequanwu).
[lldb][NativePDB] fix test load-pdb.cpp
Oct 26 2020, 11:38 AM
zequanwu committed rG242e1e991044: [lldb][PDB] Add ObjectFile PDB plugin (authored by zequanwu).
[lldb][PDB] Add ObjectFile PDB plugin
Oct 26 2020, 10:29 AM
zequanwu closed D89812: [lldb][PDB] Add ObjectFile PDB plugin.
Oct 26 2020, 10:29 AM · Restricted Project
zequanwu updated the diff for D89812: [lldb][PDB] Add ObjectFile PDB plugin.

Address comments.

Oct 26 2020, 10:28 AM · Restricted Project

Oct 25 2020

zequanwu added a comment to rG76c009266586: Ensure that checkInitIsICE is called exactly once for every variable.

Hi, this seems like causing assertion failure: Assertion Result && "Could not evaluate expression"' failed. at https://bugs.chromium.org/p/chromium/issues/detail?id=1142009

Oct 25 2020, 3:14 PM

Oct 23 2020

zequanwu committed rGe92eeaf3c219: [llvm-cov] don't include all source files when provided source files are… (authored by zequanwu).
[llvm-cov] don't include all source files when provided source files are…
Oct 23 2020, 7:32 PM
zequanwu closed D89359: [llvm-cov] don't include all source files when provided source files are filtered out.
Oct 23 2020, 7:32 PM · Restricted Project
zequanwu updated the diff for D89359: [llvm-cov] don't include all source files when provided source files are filtered out.

Fix test cases which failed on Windows.

Oct 23 2020, 7:32 PM · Restricted Project
zequanwu reopened D89359: [llvm-cov] don't include all source files when provided source files are filtered out.
Oct 23 2020, 6:46 PM · Restricted Project
zequanwu added inline comments to D89812: [lldb][PDB] Add ObjectFile PDB plugin.
Oct 23 2020, 12:55 PM · Restricted Project
zequanwu updated the diff for D89812: [lldb][PDB] Add ObjectFile PDB plugin.

Address comments.

Oct 23 2020, 12:54 PM · Restricted Project

Oct 22 2020

zequanwu added inline comments to D89812: [lldb][PDB] Add ObjectFile PDB plugin.
Oct 22 2020, 6:28 PM · Restricted Project
zequanwu updated the diff for D89812: [lldb][PDB] Add ObjectFile PDB plugin.

Address some comments.

Oct 22 2020, 6:28 PM · Restricted Project

Oct 21 2020

zequanwu added inline comments to D89590: [NPM][SimplifyCFGPass] For OptForFuzzing attribute, disable SimplifyCondBranch and FoldTwoEntryPHINode in NPM.
Oct 21 2020, 5:14 PM · Restricted Project
zequanwu added a reverting change for rGcdd006eec940: SimplifyCFG: Clean up optforfuzzing implementation: D89917: Revert "SimplifyCFG: Clean up optforfuzzing implementation".
Oct 21 2020, 5:14 PM
zequanwu requested review of D89917: Revert "SimplifyCFG: Clean up optforfuzzing implementation".
Oct 21 2020, 5:14 PM · Restricted Project
zequanwu added a reverting change for rG716f7636e1ec: Revert "SimplifyCFG: Clean up optforfuzzing implementation": rG2f29341114ed: Revert "Revert "SimplifyCFG: Clean up optforfuzzing implementation"".
Oct 21 2020, 5:09 PM
zequanwu committed rG2f29341114ed: Revert "Revert "SimplifyCFG: Clean up optforfuzzing implementation"" (authored by zequanwu).
Revert "Revert "SimplifyCFG: Clean up optforfuzzing implementation""
Oct 21 2020, 5:09 PM
zequanwu added inline comments to D89812: [lldb][PDB] Add ObjectFile PDB plugin.
Oct 21 2020, 5:02 PM · Restricted Project
zequanwu updated the diff for D89812: [lldb][PDB] Add ObjectFile PDB plugin.
  • address comments.
  • add tests.
  • move loadPDBFile from SymbolFileNativePDB.cpp to ObjectFilePDB.cpp and use it to create unique_ptr of PDBFile so that we can move it around.
Oct 21 2020, 5:01 PM · Restricted Project
zequanwu added a reverting change for rGcdd006eec940: SimplifyCFG: Clean up optforfuzzing implementation: rG716f7636e1ec: Revert "SimplifyCFG: Clean up optforfuzzing implementation".
Oct 21 2020, 4:57 PM
zequanwu committed rG716f7636e1ec: Revert "SimplifyCFG: Clean up optforfuzzing implementation" (authored by zequanwu).
Revert "SimplifyCFG: Clean up optforfuzzing implementation"
Oct 21 2020, 4:57 PM