This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Propagate static extensions to LLVMExtensions object library
AbandonedPublic

Authored by tambre on Apr 5 2021, 8:58 AM.

Details

Summary

Since 43ceb74eb1a5801662419fb66a6bf0d5414f1ec5 llvm-shlib links against the object libraries instead of static libraries.
This causes build failures if building Polly statically into LLVM as the dependency on it isn't propagated through LLVMExtension's object library variant.

Simply attach the transitive dependency to the object variant to fix this.
Fixes PR 49843.

Diff Detail

Event Timeline

tambre created this revision.Apr 5 2021, 8:58 AM
tambre requested review of this revision.Apr 5 2021, 8:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2021, 8:58 AM
tambre added a comment.Apr 5 2021, 9:00 AM

@bjope Could you try without your workaround from https://reviews.llvm.org/rGd66f9c4f1e83e69abf75f97cb5f8fd1dc9422357 with this patch? I think this should fix the lack of include directory propagation that likely caused your issue.

bjope added a comment.Apr 5 2021, 9:07 AM

@bjope Could you try without your workaround from https://reviews.llvm.org/rGd66f9c4f1e83e69abf75f97cb5f8fd1dc9422357 with this patch? I think this should fix the lack of include directory propagation that likely caused your issue.

I've tried it but this does not help for the problem with Z3.

@bjope Could you try without your workaround from https://reviews.llvm.org/rGd66f9c4f1e83e69abf75f97cb5f8fd1dc9422357 with this patch? I think this should fix the lack of include directory propagation that likely caused your issue.

I'm planning to revert d66f9c4f1e along with 43ceb74eb. I"m just waiting for my test build to finish.

tambre abandoned this revision.Apr 5 2021, 9:11 AM

@bjope Could you try without your workaround from https://reviews.llvm.org/rGd66f9c4f1e83e69abf75f97cb5f8fd1dc9422357 with this patch? I think this should fix the lack of include directory propagation that likely caused your issue.

I'm planning to revert d66f9c4f1e along with 43ceb74eb. I"m just waiting for my test build to finish.

Thanks for the info. Abandoning this as a result.