This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC, test] Fix use of undef FileCheck var
ClosedPublic

Authored by thopre on Apr 5 2021, 3:37 AM.

Details

Summary

LLVM test CodeGen/PowerPC/ctrloops-softfloat.ll tries to check for the
absence of sequences of instructions with several CHECK-NOT with one of
those directives using a variable defined in another. However CHECK-NOT
are checked independently so that is using a variable defined in a
pattern that should not occur in the input.

This commit changes occurence of the variable for the regex used in its
definition, thereby making each CHECK-NOT independent.

Diff Detail

Event Timeline

thopre created this revision.Apr 5 2021, 3:37 AM
thopre requested review of this revision.Apr 5 2021, 3:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2021, 3:37 AM
nemanjai accepted this revision.Apr 9 2021, 4:17 AM

This makes sense. All the test really needs to check is that we are not producing a CTR loop, so probably a simple --implicit-check-not=mtctr would have sufficed. This change works though, thank you. LGTM.

This revision is now accepted and ready to land.Apr 9 2021, 4:17 AM
This revision was automatically updated to reflect the committed changes.