Page MenuHomePhabricator

abeserminji (Aleksandar Beserminji)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 25 2015, 7:32 AM (207 w, 5 d)

Recent Activity

Mon, Feb 4

abeserminji created D57677: [mips][micromips] Fix values in .gcc_except_table for -fPIC.
Mon, Feb 4, 2:54 AM · Restricted Project

Mon, Jan 28

abeserminji committed rL352385: [test-suite] Fix stdthreadbug when building static.
[test-suite] Fix stdthreadbug when building static
Mon, Jan 28, 8:53 AM
abeserminji committed rT352385: [test-suite] Fix stdthreadbug when building static.
[test-suite] Fix stdthreadbug when building static
Mon, Jan 28, 8:53 AM
abeserminji closed D52878: [test-suite] Add flags for stdthreadbug.cpp when building static.
Mon, Jan 28, 8:52 AM
abeserminji committed rL352370: [mips] Support for +abs2008 attribute.
[mips] Support for +abs2008 attribute
Mon, Jan 28, 7:00 AM
abeserminji closed D35983: [mips] Introducing option -mabs=[legacy/2008].
Mon, Jan 28, 7:00 AM

Thu, Jan 24

abeserminji updated the diff for D35983: [mips] Introducing option -mabs=[legacy/2008].

Rebased and updated the patch. Now it seems like the past issues are gone.

Thu, Jan 24, 2:41 AM
abeserminji abandoned D56836: [mips] Include whole lpthread when using both -pthread and -static.

Agreed on this solution D52878.

Thu, Jan 24, 2:19 AM

Mon, Jan 21

abeserminji updated the diff for D52878: [test-suite] Add flags for stdthreadbug.cpp when building static.

Updated the patch, so that the extra flags are added only when -static option is used.
Used @atanasyan 's solution for CMakeLists.txt from D56836#1362293.
Made equivalent for the Makefile.

Mon, Jan 21, 2:29 AM

Jan 18 2019

abeserminji added a comment to D56836: [mips] Include whole lpthread when using both -pthread and -static.

@atanasyan That looks good. I tried to make an equivalent for the Makefile

--- SingleSource/UnitTests/C++11/Makefile	(revision 351547)
+++ SingleSource/UnitTests/C++11/Makefile	(working copy)
@@ -4,6 +4,11 @@
Jan 18 2019, 5:03 AM

Jan 17 2019

abeserminji added a comment to D56836: [mips] Include whole lpthread when using both -pthread and -static.

I am not sure if -static option passed as --cflag to lnt runtest enters the LDFLAGS. I guess it doesn't.
But if there is a way to check which options are passed as --cflags, we might be able to add -Wl, -whole-archive -lpthread -Wl -no-whole-archive only in case when static is used.
That would be my preferable option in this situation, but I couldn't find any clues on how to do that.

Jan 17 2019, 7:00 AM
abeserminji added a comment to D52878: [test-suite] Add flags for stdthreadbug.cpp when building static.

I agree with Simons comment that it's not MIPS specific issue, but in that case I think it would be nice to get comments from other maintainers for other targets.
I didn't see Simons comment and created something similar here D56836, but with some additional checks.

Jan 17 2019, 2:50 AM
abeserminji created D56836: [mips] Include whole lpthread when using both -pthread and -static.
Jan 17 2019, 2:38 AM

Jan 14 2019

abeserminji committed rL351059: [mips] Optimize shifts for types larger than GPR size (mips2/mips3).
[mips] Optimize shifts for types larger than GPR size (mips2/mips3)
Jan 14 2019, 4:33 AM
abeserminji closed D56320: [mips] Optimize shifts for types larger than GPR size (mips2/mips3).
Jan 14 2019, 4:32 AM

Jan 10 2019

abeserminji updated the diff for D56320: [mips] Optimize shifts for types larger than GPR size (mips2/mips3).

Comments resolved.

Jan 10 2019, 4:25 AM
abeserminji closed D55323: [mips][micrompis] Emit 16bit NOPs by default.

Patch committed.
https://reviews.llvm.org/rL350733
Closing manually because of typo in the commit message.

Jan 10 2019, 3:27 AM

Jan 9 2019

abeserminji committed rL350733: [mips][micrompis] Emit 16bit NOPs by default.
[mips][micrompis] Emit 16bit NOPs by default
Jan 9 2019, 8:01 AM
abeserminji updated the diff for D56320: [mips] Optimize shifts for types larger than GPR size (mips2/mips3).

Update patch for context.

Jan 9 2019, 5:59 AM

Jan 4 2019

abeserminji created D56320: [mips] Optimize shifts for types larger than GPR size (mips2/mips3).
Jan 4 2019, 8:39 AM

Dec 5 2018

abeserminji created D55323: [mips][micrompis] Emit 16bit NOPs by default.
Dec 5 2018, 7:07 AM

Nov 14 2018

abeserminji added a comment to D52010: RegAllocFast: Rewrite and improve.

From what I found in rL336328, I believe that the idea was to mark registers as implicit-def which would prevent such an error.
One of the comments say:

Nov 14 2018, 12:20 AM

Nov 7 2018

abeserminji committed rL346302: [mips][msa] Fix msa_[st/ld] offset check.
[mips][msa] Fix msa_[st/ld] offset check
Nov 7 2018, 3:40 AM
abeserminji committed rC346302: [mips][msa] Fix msa_[st/ld] offset check.
[mips][msa] Fix msa_[st/ld] offset check
Nov 7 2018, 3:40 AM
abeserminji closed D54038: [mips][msa] Fix msa_[st/ld] offset check.
Nov 7 2018, 3:40 AM

Nov 5 2018

abeserminji committed rC346124: [mips][msa] Fix broken test.
[mips][msa] Fix broken test
Nov 5 2018, 2:25 AM
abeserminji committed rL346124: [mips][msa] Fix broken test.
[mips][msa] Fix broken test
Nov 5 2018, 2:25 AM
abeserminji closed D53984: [mips] Fix broken MSA test.
Nov 5 2018, 2:25 AM

Nov 2 2018

abeserminji created D54038: [mips][msa] Fix msa_[st/ld] offset check.
Nov 2 2018, 10:10 AM
abeserminji added a child revision for D53984: [mips] Fix broken MSA test: D54038: [mips][msa] Fix msa_[st/ld] offset check.
Nov 2 2018, 10:10 AM

Nov 1 2018

abeserminji updated the diff for D52878: [test-suite] Add flags for stdthreadbug.cpp when building static.

Added necessary flags for Mips only.

Nov 1 2018, 10:17 AM
abeserminji created D53984: [mips] Fix broken MSA test.
Nov 1 2018, 10:00 AM
abeserminji committed rL345830: [mips][micromips] Fix JmpLink to TargetExternalSymbol.
[mips][micromips] Fix JmpLink to TargetExternalSymbol
Nov 1 2018, 7:00 AM
abeserminji closed D53366: [mips][micromips] Add pattern for JmpLink to TargetExternalSymbol.
Nov 1 2018, 7:00 AM

Oct 29 2018

abeserminji updated the diff for D53366: [mips][micromips] Add pattern for JmpLink to TargetExternalSymbol.

Resolved some comments.

Oct 29 2018, 12:10 AM

Oct 24 2018

abeserminji added inline comments to D53366: [mips][micromips] Add pattern for JmpLink to TargetExternalSymbol.
Oct 24 2018, 3:04 AM

Oct 17 2018

abeserminji created D53366: [mips][micromips] Add pattern for JmpLink to TargetExternalSymbol.
Oct 17 2018, 4:07 AM

Oct 16 2018

abeserminji committed rL344591: [mips][micromips] Fix how values in .gcc_except_table are calculated.
[mips][micromips] Fix how values in .gcc_except_table are calculated
Oct 16 2018, 1:30 AM
abeserminji closed D52985: [mips][micromips] Fix how values in .gcc_except_table are calculated.
Oct 16 2018, 1:30 AM

Oct 15 2018

abeserminji committed rL344516: [mips][micromips] Fix overlaping FDEs error.
[mips][micromips] Fix overlaping FDEs error
Oct 15 2018, 7:41 AM
abeserminji committed rL344515: [mips][micromips] Revert "Fix overlaping FDEs error".
[mips][micromips] Revert "Fix overlaping FDEs error"
Oct 15 2018, 7:38 AM
abeserminji committed rL344511: [mips][micromips] Fix overlaping FDEs error.
[mips][micromips] Fix overlaping FDEs error
Oct 15 2018, 6:01 AM
abeserminji closed D52987: [mips][micromips] Fix overlaping FDEs error.
Oct 15 2018, 6:01 AM

Oct 12 2018

abeserminji added inline comments to D52878: [test-suite] Add flags for stdthreadbug.cpp when building static.
Oct 12 2018, 3:58 AM
abeserminji updated the diff for D52878: [test-suite] Add flags for stdthreadbug.cpp when building static.

Updated patch to show full context.

Oct 12 2018, 3:57 AM

Oct 9 2018

abeserminji updated the diff for D52985: [mips][micromips] Fix how values in .gcc_except_table are calculated.

Removed class forward declaration from MCExpr.cpp. It is not needed.

Oct 9 2018, 8:17 AM
abeserminji updated the diff for D52985: [mips][micromips] Fix how values in .gcc_except_table are calculated.

Comments addressed.
Test fixed. I have one other patch in progress which affects this test, and forgot to remove it before the submission.

Oct 9 2018, 7:05 AM

Oct 8 2018

abeserminji created D52987: [mips][micromips] Fix overlaping FDEs error.
Oct 8 2018, 7:58 AM
abeserminji created D52985: [mips][micromips] Fix how values in .gcc_except_table are calculated.
Oct 8 2018, 7:57 AM

Oct 4 2018

abeserminji created D52878: [test-suite] Add flags for stdthreadbug.cpp when building static.
Oct 4 2018, 3:53 AM

Sep 3 2018

xiangzhai awarded D50437: [mips] Implement pll.ps, plu.ps and some of the missing cvt.* instructions a Like token.
Sep 3 2018, 7:34 PM

Aug 29 2018

abeserminji accepted D50615: [mips] Fix microMIPS unconditional branch offset handling.

LGTM

Aug 29 2018, 6:40 AM
abeserminji accepted D50613: [mips] Involves microMIPS's jump in the analyzable branch set.

LGTM

Aug 29 2018, 6:32 AM
abeserminji committed rL340920: [mips] Add missing instructions.
[mips] Add missing instructions
Aug 29 2018, 4:36 AM
abeserminji closed D50437: [mips] Implement pll.ps, plu.ps and some of the missing cvt.* instructions.
Aug 29 2018, 4:36 AM

Aug 28 2018

abeserminji updated the diff for D50437: [mips] Implement pll.ps, plu.ps and some of the missing cvt.* instructions.

Removed unnecessary changes.
Description updated.

Aug 28 2018, 6:31 AM

Aug 24 2018

abeserminji updated the diff for D50437: [mips] Implement pll.ps, plu.ps and some of the missing cvt.* instructions.

Fix predicates and update tests.

Aug 24 2018, 1:19 AM

Aug 20 2018

abeserminji updated the diff for D50437: [mips] Implement pll.ps, plu.ps and some of the missing cvt.* instructions.

Removed instruction definitions for FP32, which would, by the statement in the instruction manual, cause an unpredictable results.

Aug 20 2018, 7:36 AM
abeserminji planned changes to D50437: [mips] Implement pll.ps, plu.ps and some of the missing cvt.* instructions.

After reviewing the instruction manual again, I noticed the following in the Restrictions section:
The result of this instruction is UNPREDICTABLE if the processor is executing in the FR=0 32-bit FPU register model; it is predictable if executing on a 64-bit FPU in the FR=1 mode, but not with FR=0, and not on a 32-bit FPU.
Which makes some of the definitions in the patch wrong. Should fix that.

Aug 20 2018, 3:54 AM

Aug 9 2018

abeserminji updated the diff for D50437: [mips] Implement pll.ps, plu.ps and some of the missing cvt.* instructions.

Fix forgotten TODOs.

Aug 9 2018, 2:53 AM

Aug 8 2018

abeserminji created D50437: [mips] Implement pll.ps, plu.ps and some of the missing cvt.* instructions.
Aug 8 2018, 4:27 AM

Aug 7 2018

abeserminji committed rL339126: [mips] Handle branch expansion corner cases.
[mips] Handle branch expansion corner cases
Aug 7 2018, 3:46 AM
abeserminji closed D48019: [mips] Handle branch expansion corner cases.
Aug 7 2018, 3:46 AM

Aug 1 2018

abeserminji committed rT338581: [mips] Fix compile options for tramp3d-v4 test.
[mips] Fix compile options for tramp3d-v4 test
Aug 1 2018, 9:23 AM
abeserminji committed rL338581: [mips] Fix compile options for tramp3d-v4 test.
[mips] Fix compile options for tramp3d-v4 test
Aug 1 2018, 9:22 AM
abeserminji closed D49487: [mips] Fix compile options for tramp3d-v4 test.
Aug 1 2018, 9:22 AM
abeserminji updated the diff for D49487: [mips] Fix compile options for tramp3d-v4 test.

Comments addressed.

Aug 1 2018, 8:08 AM
abeserminji committed rT338515: Make Misc-C++-EH test to compiple with -static.
Make Misc-C++-EH test to compiple with -static
Aug 1 2018, 4:16 AM
abeserminji committed rL338515: Make Misc-C++-EH test to compiple with -static.
Make Misc-C++-EH test to compiple with -static
Aug 1 2018, 4:15 AM
abeserminji closed D49538: Add -pthread to LDFLAGS.
Aug 1 2018, 4:15 AM
abeserminji updated the diff for D49538: Add -pthread to LDFLAGS.

Comments addressed.

Aug 1 2018, 3:07 AM

Jul 19 2018

abeserminji abandoned D43238: Add types to HwMode.

No need for this, now when D43283 is closed.

Jul 19 2018, 6:28 AM
abeserminji abandoned D43283: Variable register class using HwMode.

I guess there is no need to keep this alive any longer.

Jul 19 2018, 6:25 AM
abeserminji accepted D49533: [mips] Move out the WrapperPat declaration from the NotInMicroMips predicate.

LGTM

Jul 19 2018, 6:23 AM
abeserminji created D49538: Add -pthread to LDFLAGS.
Jul 19 2018, 4:22 AM
abeserminji added inline comments to D49487: [mips] Fix compile options for tramp3d-v4 test.
Jul 19 2018, 3:57 AM

Jul 18 2018

abeserminji created D49487: [mips] Fix compile options for tramp3d-v4 test.
Jul 18 2018, 8:08 AM
abeserminji added inline comments to D48019: [mips] Handle branch expansion corner cases.
Jul 18 2018, 12:18 AM
abeserminji updated the diff for D48019: [mips] Handle branch expansion corner cases.

Comments addressed.

Jul 18 2018, 12:17 AM

Jul 9 2018

abeserminji accepted D17036: [mips] Addition of the [d]rem and [d]remu instructions.
Jul 9 2018, 3:21 AM

Jul 5 2018

abeserminji committed rL336328: [mips] Fix atomic operations at O0, v3.
[mips] Fix atomic operations at O0, v3
Jul 5 2018, 2:32 AM
abeserminji closed D31287: [mips] Fix atomic operations at O0, v3.
Jul 5 2018, 2:32 AM

Jul 4 2018

abeserminji added a comment to D17036: [mips] Addition of the [d]rem and [d]remu instructions.

LGTM

Jul 4 2018, 7:51 AM

Jul 3 2018

abeserminji added reviewers for D48019: [mips] Handle branch expansion corner cases: smaksimovic, atanasyan.
Jul 3 2018, 6:29 AM

Jun 19 2018

abeserminji accepted D48320: [mips] Mark microMIPS64 as being unsupported..

LGTM

Jun 19 2018, 6:38 AM
abeserminji updated the diff for D48019: [mips] Handle branch expansion corner cases.

Comments addressed.

Jun 19 2018, 6:18 AM

Jun 13 2018

abeserminji updated the diff for D48019: [mips] Handle branch expansion corner cases.

Comments addressed.

Jun 13 2018, 4:10 AM

Jun 12 2018

abeserminji committed rL334490: [mips] Extend LONG_BRANCH_LUi/ADDiu with extra parameter.
[mips] Extend LONG_BRANCH_LUi/ADDiu with extra parameter
Jun 12 2018, 3:28 AM
abeserminji closed D47941: [mips] Add additional parameter to LONG_BRANCH_LUi/ADDiu pseudo instructions.
Jun 12 2018, 3:28 AM

Jun 11 2018

abeserminji committed rL334419: [mips] Fix spill slot for mips3, n64 abi.
[mips] Fix spill slot for mips3, n64 abi
Jun 11 2018, 9:54 AM
abeserminji closed D47938: [mips] Fix spill slot for mips3, n64 abi.
Jun 11 2018, 9:54 AM
abeserminji updated the diff for D47941: [mips] Add additional parameter to LONG_BRANCH_LUi/ADDiu pseudo instructions.

Comment addressed.

Jun 11 2018, 8:25 AM
abeserminji updated the diff for D47938: [mips] Fix spill slot for mips3, n64 abi.

Comments addressed.

Jun 11 2018, 8:05 AM
abeserminji updated the summary of D47938: [mips] Fix spill slot for mips3, n64 abi.
Jun 11 2018, 6:07 AM
abeserminji created D48019: [mips] Handle branch expansion corner cases.
Jun 11 2018, 5:54 AM

Jun 8 2018

abeserminji updated the summary of D47941: [mips] Add additional parameter to LONG_BRANCH_LUi/ADDiu pseudo instructions.
Jun 8 2018, 6:14 AM
abeserminji created D47941: [mips] Add additional parameter to LONG_BRANCH_LUi/ADDiu pseudo instructions.
Jun 8 2018, 6:12 AM
abeserminji created D47938: [mips] Fix spill slot for mips3, n64 abi.
Jun 8 2018, 4:28 AM

May 22 2018

abeserminji updated the diff for D46641: [mips] Merge MipsLongBranch and MipsHazardSchedule passes.

Updated the patch, so that buildbots do not fail.
The problem was in forcing the extension to long branches in every iteration,
which causes infinite loop.

May 22 2018, 6:40 AM
abeserminji committed rL332977: [mips] Merge MipsLongBranch and MipsHazardSchedule passes.
[mips] Merge MipsLongBranch and MipsHazardSchedule passes
May 22 2018, 6:31 AM