User Details
- User Since
- Feb 25 2015, 7:32 AM (447 w, 6 d)
Feb 4 2019
Jan 28 2019
Jan 24 2019
Rebased and updated the patch. Now it seems like the past issues are gone.
Agreed on this solution D52878.
Jan 21 2019
Updated the patch, so that the extra flags are added only when -static option is used.
Used @atanasyan 's solution for CMakeLists.txt from D56836#1362293.
Made equivalent for the Makefile.
Jan 18 2019
@atanasyan That looks good. I tried to make an equivalent for the Makefile
--- SingleSource/UnitTests/C++11/Makefile (revision 351547) +++ SingleSource/UnitTests/C++11/Makefile (working copy) @@ -4,6 +4,11 @@
Jan 17 2019
I am not sure if -static option passed as --cflag to lnt runtest enters the LDFLAGS. I guess it doesn't.
But if there is a way to check which options are passed as --cflags, we might be able to add -Wl, -whole-archive -lpthread -Wl -no-whole-archive only in case when static is used.
That would be my preferable option in this situation, but I couldn't find any clues on how to do that.
I agree with Simons comment that it's not MIPS specific issue, but in that case I think it would be nice to get comments from other maintainers for other targets.
I didn't see Simons comment and created something similar here D56836, but with some additional checks.
Jan 14 2019
Jan 10 2019
Comments resolved.
Patch committed.
https://reviews.llvm.org/rL350733
Closing manually because of typo in the commit message.
Jan 9 2019
Update patch for context.
Jan 4 2019
Dec 5 2018
Nov 14 2018
From what I found in rL336328, I believe that the idea was to mark registers as implicit-def which would prevent such an error.
One of the comments say:
Nov 7 2018
Nov 5 2018
Nov 2 2018
Nov 1 2018
Added necessary flags for Mips only.
Oct 29 2018
Resolved some comments.
Oct 24 2018
Oct 17 2018
Oct 16 2018
Oct 15 2018
Oct 12 2018
Updated patch to show full context.
Oct 9 2018
Removed class forward declaration from MCExpr.cpp. It is not needed.
Comments addressed.
Test fixed. I have one other patch in progress which affects this test, and forgot to remove it before the submission.
Oct 8 2018
Oct 4 2018
Sep 3 2018
Aug 29 2018
LGTM
LGTM
Aug 28 2018
Removed unnecessary changes.
Description updated.
Aug 24 2018
Fix predicates and update tests.
Aug 20 2018
Removed instruction definitions for FP32, which would, by the statement in the instruction manual, cause an unpredictable results.
After reviewing the instruction manual again, I noticed the following in the Restrictions section:
The result of this instruction is UNPREDICTABLE if the processor is executing in the FR=0 32-bit FPU register model; it is predictable if executing on a 64-bit FPU in the FR=1 mode, but not with FR=0, and not on a 32-bit FPU.
Which makes some of the definitions in the patch wrong. Should fix that.
Aug 9 2018
Fix forgotten TODOs.
Aug 8 2018
Aug 7 2018
Aug 1 2018
Comments addressed.
Comments addressed.
Jul 19 2018
No need for this, now when D43283 is closed.
I guess there is no need to keep this alive any longer.
LGTM
Jul 18 2018
Comments addressed.
Jul 9 2018
Jul 5 2018
Jul 4 2018
LGTM
Jul 3 2018
Jun 19 2018
Comments addressed.
Jun 13 2018
Comments addressed.
Jun 12 2018
Jun 11 2018
Comment addressed.
Comments addressed.
Jun 8 2018
May 22 2018
Updated the patch, so that buildbots do not fail.
The problem was in forcing the extension to long branches in every iteration,
which causes infinite loop.