Commit 6ad3d05b681b36f6ecc98523257d154053e4116d disables the definition
of CSR that a follow-up CHECK-NOT directive depends on. This commit
replaces the undefined CSR variable use by the regex used to define it.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Event Timeline
Comment Actions
Disable directive since it actually fails with current fix
llvm/test/CodeGen/PowerPC/ppc-shrink-wrapping.ll | ||
---|---|---|
682 | This CHECK-NOT is way too generic. For instance here it matches align 4 in the .p2align 4 assembly. What are PowerPC's CSR? Even the following (which enforce the first non whitespace to not be a dot and register to have a least 2 digits) fails: CHECK-NOT: {{^ [a-z] [0-9][0-9]}} due to addis 10, 2, .LC3@toc@ha in the function body. |
Comment Actions
Looks like when the original test was disabled, this was just omitted. Thanks for fixing it.
This CHECK-NOT is way too generic. For instance here it matches align 4 in the .p2align 4 assembly. What are PowerPC's CSR?
Even the following (which enforce the first non whitespace to not be a dot and register to have a least 2 digits) fails:
CHECK-NOT: {{^ [a-z] [0-9][0-9]}}
due to addis 10, 2, .LC3@toc@ha in the function body.