Page MenuHomePhabricator
People sidbav

sidbav (Sidharth Baveja)
User

Projects

User does not belong to any projects.

User Details

User Since
May 20 2020, 7:11 AM (116 w, 3 d)

Recent Activity
View All

May 6 2021

sidbav accepted D94717: [LoopNest] Consider loop nest with inner loop guard using outer loop induction variable to be perfect .

LGTM

May 6 2021, 5:42 PM · Restricted Project

Apr 30 2021

sidbav updated the diff for D94717: [LoopNest] Consider loop nest with inner loop guard using outer loop induction variable to be perfect .

The previous Solution to bug was more of a hack rather than a fix. This patch actually resolves the bug

Apr 30 2021, 2:51 PM · Restricted Project
sidbav updated the diff for D94717: [LoopNest] Consider loop nest with inner loop guard using outer loop induction variable to be perfect .

address review comments

Apr 30 2021, 2:32 PM · Restricted Project
sidbav added a comment to D101178: [XCOFF][AIX] Add Global Variables Directly to TOC for 32 bit AIX.

Addressed the all of the remaining comments in the commit.

Apr 30 2021, 8:03 AM · Restricted Project
sidbav committed rG70c433a184a5: [XCOFF][AIX] Add Global Variables Directly to TOC for 32 bit AIX (authored by sidbav).
[XCOFF][AIX] Add Global Variables Directly to TOC for 32 bit AIX
Apr 30 2021, 7:49 AM
sidbav closed D101178: [XCOFF][AIX] Add Global Variables Directly to TOC for 32 bit AIX.
Apr 30 2021, 7:49 AM · Restricted Project

Apr 29 2021

sidbav added inline comments to D94717: [LoopNest] Consider loop nest with inner loop guard using outer loop induction variable to be perfect .
Apr 29 2021, 4:42 PM · Restricted Project
sidbav updated the diff for D94717: [LoopNest] Consider loop nest with inner loop guard using outer loop induction variable to be perfect .

Modify skipEmptyBlockUntil to also consider unique predecessors.

Apr 29 2021, 4:38 PM · Restricted Project
sidbav updated the diff for D101470: [XCOFF][AIX] Peephole optimization in 32-bit TocData transformation.

fix some formatting issues

Apr 29 2021, 2:24 PM · Restricted Project, Restricted Project
sidbav updated the diff for D101470: [XCOFF][AIX] Peephole optimization in 32-bit TocData transformation.

Address Review comments

Apr 29 2021, 2:22 PM · Restricted Project, Restricted Project
sidbav updated the diff for D101178: [XCOFF][AIX] Add Global Variables Directly to TOC for 32 bit AIX.

replacing some of the asserts with report_fatal_error, renaming some of the lit tests, and create a new one for local linkage

Apr 29 2021, 12:15 PM · Restricted Project
sidbav updated the diff for D94717: [LoopNest] Consider loop nest with inner loop guard using outer loop induction variable to be perfect .

Ensure the chain of BBs are empty blocks.

Apr 29 2021, 9:59 AM · Restricted Project

Apr 28 2021

sidbav requested review of D101470: [XCOFF][AIX] Peephole optimization in 32-bit TocData transformation.
Apr 28 2021, 9:28 AM · Restricted Project, Restricted Project

Apr 27 2021

sidbav updated the diff for D101178: [XCOFF][AIX] Add Global Variables Directly to TOC for 32 bit AIX.

Addressing Sean's comments

Apr 27 2021, 12:59 PM · Restricted Project

Apr 26 2021

sidbav updated the diff for D101178: [XCOFF][AIX] Add Global Variables Directly to TOC for 32 bit AIX.

Addressing Review Comments

Apr 26 2021, 5:04 PM · Restricted Project

Apr 23 2021

sidbav requested review of D101178: [XCOFF][AIX] Add Global Variables Directly to TOC for 32 bit AIX.
Apr 23 2021, 9:23 AM · Restricted Project

Apr 12 2021

sidbav added a comment to D94619: [SplitEdge] Update SplitCriticalEdge to return a nullptr only when the edge is not critical.
In D94619#2673338, @lebedev.ri wrote:
In D94619#2672562, @sidbav wrote:
In D94619#2672518, @lebedev.ri wrote:

Could use an IR test. Is only CoroFrame.cpp affected?

Decided to use a unit test for this patch since I modified the functionality of SplitCriticalEdge and SplitEdge, and these functions are tested with unit tests. Used a unit test to be consistent.
CoroFrame.cpp, and BasicBlockUtils and BreakCriticalEdges are modified as well.

This doesn't really answer my question, sorry.
Which transformation passes benefit from this change?
Can there not be a lit test for that for them?

Apr 12 2021, 7:13 AM · Restricted Project

Apr 6 2021

sidbav added a comment to D94619: [SplitEdge] Update SplitCriticalEdge to return a nullptr only when the edge is not critical.
In D94619#2672518, @lebedev.ri wrote:

Could use an IR test. Is only CoroFrame.cpp affected?

Apr 6 2021, 2:39 PM · Restricted Project
sidbav committed rGd81d9e8b8604: [SplitEdge] Update SplitCriticalEdge to return a nullptr only when the edge is… (authored by sidbav).
[SplitEdge] Update SplitCriticalEdge to return a nullptr only when the edge is…
Apr 6 2021, 2:26 PM
sidbav closed D94619: [SplitEdge] Update SplitCriticalEdge to return a nullptr only when the edge is not critical.
Apr 6 2021, 2:26 PM · Restricted Project
sidbav added a comment to D94619: [SplitEdge] Update SplitCriticalEdge to return a nullptr only when the edge is not critical.

I am going to commit this change since no one else seems to be reviewing it... will welcome any post commit reviews.

Apr 6 2021, 2:17 PM · Restricted Project

Apr 5 2021

sidbav accepted D99716: [LoopFusion] Bails out if only the second candidate is guarded (PR48060).

LGTM

Apr 5 2021, 9:07 AM · Restricted Project

Mar 31 2021

sidbav added a comment to D94619: [SplitEdge] Update SplitCriticalEdge to return a nullptr only when the edge is not critical.

Ping!

Mar 31 2021, 8:29 AM · Restricted Project

Mar 15 2021

sidbav added a reviewer for D94619: [SplitEdge] Update SplitCriticalEdge to return a nullptr only when the edge is not critical: dpaoliello.
Mar 15 2021, 10:13 AM · Restricted Project

Mar 3 2021

sidbav added a comment to D94619: [SplitEdge] Update SplitCriticalEdge to return a nullptr only when the edge is not critical.

Ping

Mar 3 2021, 9:22 AM · Restricted Project
sidbav retitled D94619: [SplitEdge] Update SplitCriticalEdge to return a nullptr only when the edge is not critical from [SplitEdge] Update to handle cases which were not previously considered when the edge is critical. to [SplitEdge] Update SplitCriticalEdge to return a nullptr only when the edge is not critical.
Mar 3 2021, 9:21 AM · Restricted Project

Feb 17 2021

sidbav added a comment to D94619: [SplitEdge] Update SplitCriticalEdge to return a nullptr only when the edge is not critical.

ping

Feb 17 2021, 7:07 AM · Restricted Project
sidbav committed rGcb2876800cc8: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX. (authored by sidbav).
[PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX.
Feb 17 2021, 6:56 AM
sidbav closed D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..
Feb 17 2021, 6:56 AM · Restricted Project
sidbav updated the diff for D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..

Address comments

Feb 17 2021, 6:52 AM · Restricted Project

Feb 16 2021

sidbav updated the diff for D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..

Address Comments

Feb 16 2021, 8:43 AM · Restricted Project

Feb 12 2021

sidbav updated the diff for D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..

Updates based on feedback.

Feb 12 2021, 1:27 PM · Restricted Project
sidbav updated the diff for D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..

Update ppc64-sibcall-shrinkwrap.ll to currently fail since tail calling is not implemented yet.

Feb 12 2021, 7:17 AM · Restricted Project

Feb 10 2021

sidbav updated the diff for D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..

Address Comments, remove redundant checks.

Feb 10 2021, 3:10 PM · Restricted Project
sidbav updated the diff for D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..

Remove trailing whitespace

Feb 10 2021, 7:47 AM · Restricted Project

Feb 9 2021

sidbav added a comment to D94619: [SplitEdge] Update SplitCriticalEdge to return a nullptr only when the edge is not critical.

Ping

Feb 9 2021, 8:27 AM · Restricted Project
sidbav added a comment to D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..

Ping

Feb 9 2021, 8:27 AM · Restricted Project

Feb 5 2021

sidbav added inline comments to D95806: [LoopUnrollAndJam] Do not allows loops which have no exit(ing) blocks or multiple exit(ing) blocks.
Feb 5 2021, 8:17 AM · Restricted Project
sidbav committed rG22ebbc476557: LoopUnrollAndJam] Only allow loops with single exit(ing) blocks (authored by sidbav).
LoopUnrollAndJam] Only allow loops with single exit(ing) blocks
Feb 5 2021, 8:16 AM
sidbav closed D95806: [LoopUnrollAndJam] Do not allows loops which have no exit(ing) blocks or multiple exit(ing) blocks.
Feb 5 2021, 8:15 AM · Restricted Project

Feb 4 2021

sidbav added inline comments to D95806: [LoopUnrollAndJam] Do not allows loops which have no exit(ing) blocks or multiple exit(ing) blocks.
Feb 4 2021, 8:02 AM · Restricted Project

Feb 3 2021

sidbav added inline comments to D95806: [LoopUnrollAndJam] Do not allows loops which have no exit(ing) blocks or multiple exit(ing) blocks.
Feb 3 2021, 1:48 PM · Restricted Project
sidbav added inline comments to D95806: [LoopUnrollAndJam] Do not allows loops which have no exit(ing) blocks or multiple exit(ing) blocks.
Feb 3 2021, 10:28 AM · Restricted Project
sidbav updated the diff for D95806: [LoopUnrollAndJam] Do not allows loops which have no exit(ing) blocks or multiple exit(ing) blocks.

Updates based on feedback

Feb 3 2021, 10:23 AM · Restricted Project

Feb 2 2021

sidbav updated the diff for D95806: [LoopUnrollAndJam] Do not allows loops which have no exit(ing) blocks or multiple exit(ing) blocks.

Update the test case such that it is not specific to a target.

Feb 2 2021, 2:49 PM · Restricted Project
sidbav added inline comments to D95806: [LoopUnrollAndJam] Do not allows loops which have no exit(ing) blocks or multiple exit(ing) blocks.
Feb 2 2021, 11:05 AM · Restricted Project
sidbav updated the diff for D95806: [LoopUnrollAndJam] Do not allows loops which have no exit(ing) blocks or multiple exit(ing) blocks.

Update test case as per feedback

Feb 2 2021, 11:02 AM · Restricted Project
sidbav added a comment to D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..

Ping!

Feb 2 2021, 7:08 AM · Restricted Project

Feb 1 2021

sidbav updated the diff for D95806: [LoopUnrollAndJam] Do not allows loops which have no exit(ing) blocks or multiple exit(ing) blocks.

Minor updates from the previous diff

Feb 1 2021, 12:05 PM · Restricted Project
sidbav updated the diff for D95806: [LoopUnrollAndJam] Do not allows loops which have no exit(ing) blocks or multiple exit(ing) blocks.

Forgot to add testcase

Feb 1 2021, 11:47 AM · Restricted Project
sidbav requested review of D95806: [LoopUnrollAndJam] Do not allows loops which have no exit(ing) blocks or multiple exit(ing) blocks.
Feb 1 2021, 11:14 AM · Restricted Project
sidbav added a reviewer for D94619: [SplitEdge] Update SplitCriticalEdge to return a nullptr only when the edge is not critical: asbirlea.
Feb 1 2021, 6:38 AM · Restricted Project

Jan 27 2021

sidbav added a comment to D94619: [SplitEdge] Update SplitCriticalEdge to return a nullptr only when the edge is not critical.

Ping

Jan 27 2021, 9:06 AM · Restricted Project

Jan 26 2021

sidbav updated the diff for D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..

Add test cases for 32 and 64 bit AIX

Jan 26 2021, 12:41 PM · Restricted Project

Jan 20 2021

sidbav updated the diff for D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..
Jan 20 2021, 2:28 PM · Restricted Project
sidbav requested review of D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..
Jan 20 2021, 2:19 PM · Restricted Project
sidbav added a comment to D94619: [SplitEdge] Update SplitCriticalEdge to return a nullptr only when the edge is not critical.

Ping!

Jan 20 2021, 6:31 AM · Restricted Project

Jan 14 2021

sidbav requested review of D94717: [LoopNest] Consider loop nest with inner loop guard using outer loop induction variable to be perfect .
Jan 14 2021, 1:37 PM · Restricted Project

Jan 13 2021

sidbav requested review of D94619: [SplitEdge] Update SplitCriticalEdge to return a nullptr only when the edge is not critical.
Jan 13 2021, 11:02 AM · Restricted Project

Jan 7 2021

sidbav committed rG048f184ee488: [SplitEdge] Add new parameter to SplitEdge to name the newly created basic block (authored by sidbav).
[SplitEdge] Add new parameter to SplitEdge to name the newly created basic block
Jan 7 2021, 6:51 AM
sidbav closed D94176: [SplitEdge] Add new parameter to SplitEdge to name the newly created basic block.
Jan 7 2021, 6:51 AM · Restricted Project

Jan 6 2021

sidbav updated the diff for D94176: [SplitEdge] Add new parameter to SplitEdge to name the newly created basic block.

Made a small error in the previous diff, updated the minor typo.

Jan 6 2021, 8:58 AM · Restricted Project
sidbav updated the diff for D94176: [SplitEdge] Add new parameter to SplitEdge to name the newly created basic block.

Pass in the BBName Parameter to the critical edge case as well.

Jan 6 2021, 8:39 AM · Restricted Project
sidbav requested review of D94176: [SplitEdge] Add new parameter to SplitEdge to name the newly created basic block.
Jan 6 2021, 7:01 AM · Restricted Project

Aug 1 2020

sidbav added a comment to D83056: Separate the Loop Peeling Utilities from the Loop Unrolling Utilities .

Hey @sckmodifier, please take a look at some comments after that one you just quoted. I added the NFC tag, but then in later discussion, it was determined it is best to remove the NFC tag since this change is in somewhat in a grey area.

Aug 1 2020, 6:08 AM · Restricted Project

Jul 31 2020

sidbav committed rGb7cfa6ca9283: [Loop Peeling] Separate the Loop Peeling Utilities from the Loop Unrolling… (authored by sidbav).
[Loop Peeling] Separate the Loop Peeling Utilities from the Loop Unrolling…
Jul 31 2020, 11:32 AM
sidbav closed D83056: Separate the Loop Peeling Utilities from the Loop Unrolling Utilities .
Jul 31 2020, 11:32 AM · Restricted Project

Jul 30 2020

sidbav added a comment to D83056: Separate the Loop Peeling Utilities from the Loop Unrolling Utilities .

Ping!

Jul 30 2020, 8:15 AM · Restricted Project

Jul 23 2020

sidbav committed rG38a82179315c: [Loop Fusion] Integrate Loop Peeling into Loop Fusion (re-land after fixing… (authored by sidbav).
[Loop Fusion] Integrate Loop Peeling into Loop Fusion (re-land after fixing…
Jul 23 2020, 2:04 PM
sidbav closed D82927: Intergerate Loop Peeling into Loop Fusion.
Jul 23 2020, 2:04 PM · Restricted Project
sidbav updated the diff for D82927: Intergerate Loop Peeling into Loop Fusion.

Missed one comment from Bardia, address that comment.

Jul 23 2020, 1:14 PM · Restricted Project
sidbav updated the diff for D82927: Intergerate Loop Peeling into Loop Fusion.

Address review comments

Jul 23 2020, 1:11 PM · Restricted Project
sidbav added inline comments to D83056: Separate the Loop Peeling Utilities from the Loop Unrolling Utilities .
Jul 23 2020, 8:29 AM · Restricted Project
sidbav updated the diff for D83056: Separate the Loop Peeling Utilities from the Loop Unrolling Utilities .

Include all of the includes from before, and update patch based on changes in D82927

Jul 23 2020, 8:28 AM · Restricted Project
sidbav added inline comments to D82927: Intergerate Loop Peeling into Loop Fusion.
Jul 23 2020, 5:52 AM · Restricted Project
sidbav updated the diff for D82927: Intergerate Loop Peeling into Loop Fusion.

Address the ASAN build failures (major change is around line 795 in LoopFuse.cpp file). Also address some issues @MaskRay pointed out in lit tests.

Jul 23 2020, 5:48 AM · Restricted Project

Jul 21 2020

sidbav committed rGbb8850d34d60: [Loop Fusion] Integrate Loop Peeling into Loop Fusion Summary: This patch adds… (authored by sidbav).
[Loop Fusion] Integrate Loop Peeling into Loop Fusion Summary: This patch adds…
Jul 21 2020, 9:01 AM
sidbav closed D82927: Intergerate Loop Peeling into Loop Fusion.
Jul 21 2020, 9:01 AM · Restricted Project

Jul 20 2020

sidbav retitled D83056: Separate the Loop Peeling Utilities from the Loop Unrolling Utilities from [NFC] Separate the Loop Peeling Utilities from the Loop Unrolling Utilities to Separate the Loop Peeling Utilities from the Loop Unrolling Utilities .
Jul 20 2020, 7:08 AM · Restricted Project

Jul 17 2020

sidbav updated the diff for D83056: Separate the Loop Peeling Utilities from the Loop Unrolling Utilities .

Address Florian 's comments.

Jul 17 2020, 11:34 AM · Restricted Project
sidbav updated the diff for D82927: Intergerate Loop Peeling into Loop Fusion.

Address Bardia's comments

Jul 17 2020, 10:17 AM · Restricted Project
sidbav added a comment to D82927: Intergerate Loop Peeling into Loop Fusion.

Ping @ reviewers! Thanks!

Jul 17 2020, 6:34 AM · Restricted Project
sidbav added a comment to D83056: Separate the Loop Peeling Utilities from the Loop Unrolling Utilities .

Ping @ reviewers! Thanks!

Jul 17 2020, 6:34 AM · Restricted Project

Jul 16 2020

sidbav updated the diff for D83869: [Loop Simplify] Resolve an issue where metadata is not applied to a loop latch..

Address review comments

Jul 16 2020, 8:19 AM · Restricted Project

Jul 15 2020

sidbav updated the diff for D83869: [Loop Simplify] Resolve an issue where metadata is not applied to a loop latch..

Address Bardia's comments

Jul 15 2020, 8:48 AM · Restricted Project
Herald added a project to D83869: [Loop Simplify] Resolve an issue where metadata is not applied to a loop latch.: Restricted Project.
Jul 15 2020, 6:51 AM · Restricted Project

Jul 10 2020

sidbav updated the diff for D83056: Separate the Loop Peeling Utilities from the Loop Unrolling Utilities .

Minor update after making some modifications to D80580

Jul 10 2020, 2:17 PM · Restricted Project
sidbav updated the diff for D80580: [NFC] Separate Peeling Properties into its own struct.

Applying the patch in its previous state resulted in build failures. Updated patch to resolve all build failures. Major change is in the file llvm/lib/Transforms/Scalar/LoopUnrollPass.cpp in the gatherPeelingPreferences function.

Jul 10 2020, 7:12 AM · Restricted Project

Jul 8 2020

sidbav updated the diff for D82927: Intergerate Loop Peeling into Loop Fusion.

Address Bardia's comments.

Jul 8 2020, 7:08 AM · Restricted Project

Jul 7 2020

sidbav added inline comments to D83056: Separate the Loop Peeling Utilities from the Loop Unrolling Utilities .
Jul 7 2020, 2:49 PM · Restricted Project
sidbav updated the diff for D82927: Intergerate Loop Peeling into Loop Fusion.

Address Bardia's comments, major change is removing the loop-fusion-peel option.

Jul 7 2020, 2:43 PM · Restricted Project
sidbav added inline comments to D82927: Intergerate Loop Peeling into Loop Fusion.
Jul 7 2020, 2:00 PM · Restricted Project
sidbav retitled D80580: [NFC] Separate Peeling Properties into its own struct from Separate Peeling Properties into its own struct to [NFC] Separate Peeling Properties into its own struct.
Jul 7 2020, 10:44 AM · Restricted Project
sidbav retitled D83056: Separate the Loop Peeling Utilities from the Loop Unrolling Utilities from Separate the Loop Peeling Utilities from the Loop Unrolling Utilities to [NFC] Separate the Loop Peeling Utilities from the Loop Unrolling Utilities .
Jul 7 2020, 10:44 AM · Restricted Project

Jul 2 2020

sidbav updated the summary of D82927: Intergerate Loop Peeling into Loop Fusion.
Jul 2 2020, 8:40 AM · Restricted Project
sidbav updated the diff for D82927: Intergerate Loop Peeling into Loop Fusion.

Address @Meinersbur comments. Remove the Loop Peeling files since it is unrelated to fusion. The Loop Peeling changes revision is here: D83056

Jul 2 2020, 8:37 AM · Restricted Project
sidbav created D83056: Separate the Loop Peeling Utilities from the Loop Unrolling Utilities .
Jul 2 2020, 8:37 AM · Restricted Project

Jun 30 2020

sidbav added a comment to D80580: [NFC] Separate Peeling Properties into its own struct.

@fhahn added the followup patch D82927. Also ping at reviewers of this patch! Thanks!

Jun 30 2020, 7:00 PM · Restricted Project
sidbav created D82927: Intergerate Loop Peeling into Loop Fusion.
Jun 30 2020, 7:00 PM · Restricted Project
sidbav updated the diff for D80580: [NFC] Separate Peeling Properties into its own struct.

Some NFC modifications.

Jun 30 2020, 6:59 PM · Restricted Project