User Details
- User Since
- May 20 2020, 7:11 AM (116 w, 3 d)
May 6 2021
LGTM
Apr 30 2021
The previous Solution to bug was more of a hack rather than a fix. This patch actually resolves the bug
address review comments
Addressed the all of the remaining comments in the commit.
Apr 29 2021
Modify skipEmptyBlockUntil to also consider unique predecessors.
fix some formatting issues
Address Review comments
replacing some of the asserts with report_fatal_error, renaming some of the lit tests, and create a new one for local linkage
Ensure the chain of BBs are empty blocks.
Apr 28 2021
Apr 27 2021
Addressing Sean's comments
Apr 26 2021
Addressing Review Comments
Apr 23 2021
Apr 12 2021
Apr 6 2021
I am going to commit this change since no one else seems to be reviewing it... will welcome any post commit reviews.
Apr 5 2021
LGTM
Mar 31 2021
Ping!
Mar 15 2021
Mar 3 2021
Ping
Feb 17 2021
ping
Address comments
Feb 16 2021
Address Comments
Feb 12 2021
Updates based on feedback.
Update ppc64-sibcall-shrinkwrap.ll to currently fail since tail calling is not implemented yet.
Feb 10 2021
Address Comments, remove redundant checks.
Remove trailing whitespace
Feb 9 2021
Ping
Ping
Feb 5 2021
Feb 4 2021
Feb 3 2021
Updates based on feedback
Feb 2 2021
Update the test case such that it is not specific to a target.
Update test case as per feedback
Ping!
Feb 1 2021
Minor updates from the previous diff
Forgot to add testcase
Jan 27 2021
Ping
Jan 26 2021
Add test cases for 32 and 64 bit AIX
Jan 20 2021
Ping!
Jan 14 2021
Jan 13 2021
Jan 7 2021
Jan 6 2021
Made a small error in the previous diff, updated the minor typo.
Pass in the BBName Parameter to the critical edge case as well.
Aug 1 2020
Hey @sckmodifier, please take a look at some comments after that one you just quoted. I added the NFC tag, but then in later discussion, it was determined it is best to remove the NFC tag since this change is in somewhat in a grey area.
Jul 31 2020
Jul 30 2020
Ping!
Jul 23 2020
Missed one comment from Bardia, address that comment.
Address review comments
Include all of the includes from before, and update patch based on changes in D82927
Address the ASAN build failures (major change is around line 795 in LoopFuse.cpp file). Also address some issues @MaskRay pointed out in lit tests.
Jul 21 2020
Jul 20 2020
Jul 17 2020
Address Florian 's comments.
Address Bardia's comments
Ping @ reviewers! Thanks!
Ping @ reviewers! Thanks!
Jul 16 2020
Address review comments
Jul 15 2020
Address Bardia's comments
Jul 10 2020
Minor update after making some modifications to D80580
Applying the patch in its previous state resulted in build failures. Updated patch to resolve all build failures. Major change is in the file llvm/lib/Transforms/Scalar/LoopUnrollPass.cpp in the gatherPeelingPreferences function.
Jul 8 2020
Address Bardia's comments.
Jul 7 2020
Address Bardia's comments, major change is removing the loop-fusion-peel option.
Jul 2 2020
Address @Meinersbur comments. Remove the Loop Peeling files since it is unrelated to fusion. The Loop Peeling changes revision is here: D83056
Jun 30 2020
Some NFC modifications.