Page MenuHomePhabricator

[M68k] Mark public functions with the LLVM_EXTERNAL_VISIBILITY macro
ClosedPublic

Authored by glaubitz on Apr 4 2021, 4:06 PM.

Details

Summary

In 0dbcb3639451, most most target symbols were made hidden by default
with the public ones marked with LLVM_EXTERNAL_VISIBILITY. When the
M68k target was added, this particular change was forgotten so that
external tools cannot make use of the public M68k target functions
in libLLVM.so. Thus, add the missing LLVM_EXTERNAL_VISIBILITY macro
to all public target functions in the M68k backend.

Diff Detail

Event Timeline

glaubitz created this revision.Apr 4 2021, 4:06 PM
glaubitz requested review of this revision.Apr 4 2021, 4:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2021, 4:06 PM
ricky26 added a subscriber: ricky26.Apr 4 2021, 4:33 PM
myhsu accepted this revision.Apr 4 2021, 11:06 PM

LGTM. Thanks
I don't think we need a second LGTM since this is a minor change

This revision is now accepted and ready to land.Apr 4 2021, 11:06 PM

LGTM. Thanks
I don't think we need a second LGTM since this is a minor change

Thanks. This was caught while working on the first Debian packages. Once this has been merged here, I can drop the patch in Debian again.

This revision was landed with ongoing or failed builds.Apr 5 2021, 9:25 AM
This revision was automatically updated to reflect the committed changes.