This is an archive of the discontinued LLVM Phabricator instance.

Differential D99775

[OpenMP, test] Fix use of undef VAR_PRIV FileCheck var
ClosedPublic

Authored by thopre on Apr 1 2021, 4:34 PM.

Details

Reviewers
ABataev
mikerice
jdoerfert
MaskRay
Commits
rG2c3db73341ae: [OpenMP, test] Fix use of undef VAR_PRIV FileCheck var
Summary

Remove the CHECK-NOT directive referring to as-of-yet undefined VAR_PRIV
variable since the pattern of the following CHECK-NOT in the same
CHECK-NOT block covers a superset of the case caught by the first
CHECK-NOT.

Diff Detail

Event Timeline

thopre created this revision.Apr 1 2021, 4:34 PM
Herald added subscribers: guansong, yaxunl. · View Herald TranscriptApr 1 2021, 4:34 PM
thopre requested review of this revision.Apr 1 2021, 4:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2021, 4:34 PM
Herald added subscribers: cfe-commits, sstefan1. · View Herald Transcript
ABataev accepted this revision.Apr 1 2021, 4:35 PM

LG

This revision is now accepted and ready to land.Apr 1 2021, 4:35 PM
This revision was landed with ongoing or failed builds.Apr 1 2021, 4:39 PM
Closed by commit rG2c3db73341ae: [OpenMP, test] Fix use of undef VAR_PRIV FileCheck var (authored by thopre). · Explain Why
This revision was automatically updated to reflect the committed changes.
thopre added a commit: rG2c3db73341ae: [OpenMP, test] Fix use of undef VAR_PRIV FileCheck var.
Harbormaster completed remote builds in B96828: Diff 334849.Apr 1 2021, 5:17 PM

Revision Contents

PathSize
clang/
test/
OpenMP/
1 line

Diff 334852

clang/test/OpenMP/sections_reduction_codegen.cpp

Show First 20 Lines • Show All 204 Lines • ▼ Show 20 Lines
// CHECK: alloca [[S_FLOAT_TY]], // CHECK: alloca [[S_FLOAT_TY]],
// CHECK: alloca float, // CHECK: alloca float,
// CHECK: store i{{[0-9]+}}* [[GTID_ADDR]], i{{[0-9]+}}** [[GTID_ADDR_ADDR:%.+]], // CHECK: store i{{[0-9]+}}* [[GTID_ADDR]], i{{[0-9]+}}** [[GTID_ADDR_ADDR:%.+]],
// CHECK: [[GTID_REF:%.+]] = load i{{[0-9]+}}*, i{{[0-9]+}}** [[GTID_ADDR_ADDR]] // CHECK: [[GTID_REF:%.+]] = load i{{[0-9]+}}*, i{{[0-9]+}}** [[GTID_ADDR_ADDR]]
// CHECK: [[GTID:%.+]] = load i{{[0-9]+}}, i{{[0-9]+}}* [[GTID_REF]] // CHECK: [[GTID:%.+]] = load i{{[0-9]+}}, i{{[0-9]+}}* [[GTID_REF]]
// CHECK-NOT: call {{.*}} [[S_FLOAT_TY_DESTR]]([[S_FLOAT_TY]]* [[VAR_PRIV]])
// CHECK-NOT: call {{.*}} [[S_FLOAT_TY_DESTR]]([[S_FLOAT_TY]]* // CHECK-NOT: call {{.*}} [[S_FLOAT_TY_DESTR]]([[S_FLOAT_TY]]*
// CHECK: call void @__kmpc_for_static_init_4( // CHECK: call void @__kmpc_for_static_init_4(
// CHECK: call void @__kmpc_for_static_fini( // CHECK: call void @__kmpc_for_static_fini(
// CHECK: call void @__kmpc_barrier( // CHECK: call void @__kmpc_barrier(
// CHECK: ret void // CHECK: ret void
▲ Show 20 Lines • Show All 239 Lines • Show Last 20 Lines