Page MenuHomePhabricator

[mlir][Linalg] Drop spurious error message
ClosedPublic

Authored by mravishankar on Mar 28 2021, 10:27 PM.

Details

Summary

Drop usage of emitRemark and use notifyMatchFailure instead to
avoid unnecessary spew during compilation.

Diff Detail

Event Timeline

mravishankar created this revision.Mar 28 2021, 10:27 PM
mravishankar requested review of this revision.Mar 28 2021, 10:27 PM
hanchung accepted this revision.Mar 29 2021, 8:04 AM

nice cleanup!

mlir/test/Dialect/Linalg/reshape_linearization_fusion.mlir
1

I think we can also delete -verify-diagnostics because the below one is the only expected-* in this file. (I think we should only use -verify-diagnostics in invalid.mlir tests)

This revision is now accepted and ready to land.Mar 29 2021, 8:04 AM

Remove unnecessary flag from test.

This revision was landed with ongoing or failed builds.Mar 29 2021, 9:17 AM
This revision was automatically updated to reflect the committed changes.