Page MenuHomePhabricator

[SROA] Avoid splitting loads/stores with irregular type
ClosedPublic

Authored by LemonBoy on Mar 26 2021, 12:31 PM.

Details

Summary

Upon encountering loads/stores on types whose size is not a multiple of 8 bits the SROA pass would either trip an assertion or use logic that was not meant to work with such irregularly-sized types.

Diff Detail

Event Timeline

LemonBoy created this revision.Mar 26 2021, 12:31 PM
LemonBoy requested review of this revision.Mar 26 2021, 12:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 26 2021, 12:31 PM
LemonBoy updated this revision to Diff 333667.Mar 27 2021, 3:46 AM

Run clang-format on the modified line.

aeubanks accepted this revision.Tue, Jun 8, 3:01 PM

lgtm

This revision is now accepted and ready to land.Tue, Jun 8, 3:01 PM
This revision was automatically updated to reflect the committed changes.

Sorry for the noise, the test got stale since I first uploaded it. I'll push again once this is sorted out.