Details
- Reviewers
mikeurbach nicolasvasilache
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Looks great, thanks for adding this. I had just one question as I read through this.
mlir/docs/Bindings/Python.md | ||
---|---|---|
525 |
There seems to be some subtlety here (I'm not sure myself, I need to review it). Is it worth calling out when this doesn't hold? |
LGTM
Thanks for more doc :)
This is complex to read, but I suspect it describes a complex mechanism in itself... (i.e. the complexity may be inherent)
Added a note: "Note that this is a rather complex mechanism and this section errs on the side
of explicitness. Users are encouraged to find an example and duplicate it if
they don't feel the need to understand the subtlety. The builtin dialect
provides some relatively simple examples."
I struggled with the level to write it. Open to revisions!
mlir/docs/Bindings/Python.md | ||
---|---|---|
525 | Added a note. The caveats are not something that regular use should ever hit. More of a cautionary tale to avoid pushing the edges of the abstraction. |
There seems to be some subtlety here (I'm not sure myself, I need to review it). Is it worth calling out when this doesn't hold?