This is an archive of the discontinued LLVM Phabricator instance.

Differential D99090

[llvm-readobj] Add XMC_UL in the enum entry of CsectStorageMapping class
AbandonedPublic

Authored by NeHuang on Mar 22 2021, 10:17 AM.

Details

Reviewers
jasonliu
DiggerLin
power-llvm-team
jhenderson
Summary

Add XMC_UL in the enum entry of CsectStorageMapping class to print the string while reading the symbol properties for TLS variables.

Diff Detail

Event Timeline

NeHuang created this revision.Mar 22 2021, 10:17 AM
Herald added a reviewer: jhenderson. · View Herald TranscriptMar 22 2021, 10:17 AM
Herald added a subscriber: rupprecht. · View Herald Transcript
NeHuang requested review of this revision.Mar 22 2021, 10:17 AM
Herald added subscribers: llvm-commits, MaskRay. · View Herald TranscriptMar 22 2021, 10:17 AM
NeHuang edited the summary of this revision. (Show Details)Mar 22 2021, 10:29 AM
DiggerLin accepted this revision.Mar 22 2021, 10:29 AM

LGTM

This revision is now accepted and ready to land.Mar 22 2021, 10:29 AM
NeHuang removed a reviewer: jhenderson.Mar 22 2021, 10:29 AM
Herald added a reviewer: jhenderson. · View Herald TranscriptMar 22 2021, 10:29 AM
NeHuang abandoned this revision.Mar 22 2021, 10:36 AM

Thanks Digger! I will integrate the fix to D98946 with test cases added and abandon this one

Harbormaster completed remote builds in B95031: Diff 332348.Mar 22 2021, 11:15 AM

Revision Contents

PathSize
llvm/
tools/
llvm-readobj/
2 lines

Diff 332348

llvm/tools/llvm-readobj/XCOFFDumper.cpp

Show First 20 Lines • Show All 176 Lines • ▼ Show 20 Linesvoid XCOFFDumper::printFileAuxEnt(const XCOFFFileAuxEnt *AuxEntPtr) {
W.printEnum("Type", static_cast<uint8_t>(AuxEntPtr->Type), W.printEnum("Type", static_cast<uint8_t>(AuxEntPtr->Type),
makeArrayRef(FileStringType)); makeArrayRef(FileStringType));
} }
static const EnumEntry<XCOFF::StorageMappingClass> CsectStorageMappingClass[] = static const EnumEntry<XCOFF::StorageMappingClass> CsectStorageMappingClass[] =
{ {
#define ECase(X) \ #define ECase(X) \
{ #X, XCOFF::X } { #X, XCOFF::X }
ECase(XMC_PR), ECase(XMC_RO), ECase(XMC_DB), ECase(XMC_PR), ECase(XMC_RO), ECase(XMC_DB),
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-        ECase(XMC_PR),   ECase(XMC_RO),     ECase(XMC_DB),
-        ECase(XMC_GL),   ECase(XMC_XO),     ECase(XMC_SV),
-        ECase(XMC_SV64), ECase(XMC_SV3264), ECase(XMC_TI),
-        ECase(XMC_TB),   ECase(XMC_RW),     ECase(XMC_TC0),
-        ECase(XMC_TC),   ECase(XMC_TD),     ECase(XMC_DS),
-        ECase(XMC_UA),   ECase(XMC_BS),     ECase(XMC_UC),
-        ECase(XMC_TL),   ECase(XMC_UL),     ECase(XMC_TE)
+        ECase(XMC_PR), ECase(XMC_RO), ECase(XMC_DB),   ECase(XMC_GL),
+        ECase(XMC_XO), ECase(XMC_SV), ECase(XMC_SV64), ECase(XMC_SV3264),
+        ECase(XMC_TI), ECase(XMC_TB), ECase(XMC_RW),   ECase(XMC_TC0),

3 diff lines are omitted. See full path.

Lint: Pre-merge checks: clang-format: please reformat the code ``` - ECase(XMC_PR), ECase(XMC_RO), ECase…
ECase(XMC_GL), ECase(XMC_XO), ECase(XMC_SV), ECase(XMC_GL), ECase(XMC_XO), ECase(XMC_SV),
ECase(XMC_SV64), ECase(XMC_SV3264), ECase(XMC_TI), ECase(XMC_SV64), ECase(XMC_SV3264), ECase(XMC_TI),
ECase(XMC_TB), ECase(XMC_RW), ECase(XMC_TC0), ECase(XMC_TB), ECase(XMC_RW), ECase(XMC_TC0),
ECase(XMC_TC), ECase(XMC_TD), ECase(XMC_DS), ECase(XMC_TC), ECase(XMC_TD), ECase(XMC_DS),
ECase(XMC_UA), ECase(XMC_BS), ECase(XMC_UC), ECase(XMC_UA), ECase(XMC_BS), ECase(XMC_UC),
ECase(XMC_TL), ECase(XMC_TE) ECase(XMC_TL), ECase(XMC_UL), ECase(XMC_TE)
#undef ECase #undef ECase
}; };
static const EnumEntry<XCOFF::SymbolType> CsectSymbolTypeClass[] = { static const EnumEntry<XCOFF::SymbolType> CsectSymbolTypeClass[] = {
#define ECase(X) \ #define ECase(X) \
{ #X, XCOFF::X } { #X, XCOFF::X }
ECase(XTY_ER), ECase(XTY_SD), ECase(XTY_LD), ECase(XTY_CM) ECase(XTY_ER), ECase(XTY_SD), ECase(XTY_LD), ECase(XTY_CM)
#undef ECase #undef ECase
▲ Show 20 Lines • Show All 322 Lines • Show Last 20 Lines