This is an archive of the discontinued LLVM Phabricator instance.

Differential D99049

[clangd] Fix linker error when linking clang-index-server with shared libraries
ClosedPublic

Authored by nridge on Mar 21 2021, 10:30 PM.

Details

Reviewers
kadircet
Commits
rG2e58226d8d7e: [clangd] Fix linker error when linking clang-index-server with shared libraries
Summary

Fixes https://github.com/clangd/clangd/issues/723

Diff Detail

Event Timeline

nridge created this revision.Mar 21 2021, 10:30 PM
Herald added subscribers: usaxena95, kadircet, arphaman, mgorny. · View Herald TranscriptMar 21 2021, 10:30 PM
nridge requested review of this revision.Mar 21 2021, 10:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 21 2021, 10:30 PM
Herald added subscribers: MaskRay, ilya-biryukov. · View Herald Transcript
nridge edited the summary of this revision. (Show Details)Mar 21 2021, 10:31 PM
Harbormaster completed remote builds in B94930: Diff 332195.Mar 21 2021, 11:19 PM
kadircet accepted this revision.Mar 21 2021, 11:36 PM

thanks, lgtm!

This revision is now accepted and ready to land.Mar 21 2021, 11:36 PM
Closed by commit rG2e58226d8d7e: [clangd] Fix linker error when linking clang-index-server with shared libraries (authored by nridge). · Explain WhyMar 21 2021, 11:39 PM
This revision was automatically updated to reflect the committed changes.
nridge added a commit: rG2e58226d8d7e: [clangd] Fix linker error when linking clang-index-server with shared libraries.

Revision Contents

PathSize
clang-tools-extra/
clangd/
index/
remote/
server/
1 line

Diff 332195

clang-tools-extra/clangd/index/remote/server/CMakeLists.txt

set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
Support Support
) )
add_clang_executable(clangd-index-server add_clang_executable(clangd-index-server
Server.cpp Server.cpp
DEPENDS DEPENDS
RemoteIndexProto RemoteIndexProto
RemoteIndexServiceProto RemoteIndexServiceProto
) )
target_link_libraries(clangd-index-server target_link_libraries(clangd-index-server
PRIVATE PRIVATE
clangDaemon clangDaemon
clangdSupport clangdSupport
MonitoringServiceProto
RemoteIndexProto RemoteIndexProto
RemoteIndexServiceProto RemoteIndexServiceProto
clangdRemoteMarshalling clangdRemoteMarshalling
${REFLECTION_LIBRARY} ${REFLECTION_LIBRARY}
) )