This is an archive of the discontinued LLVM Phabricator instance.

[mlir][affine] Deduplicate affine min/max op expressions
ClosedPublic

Authored by antiagainst on Mar 20 2021, 7:37 AM.

Details

Summary

If there are multiple identical expressions in an affine
min/max op's map, we can just keep one.

Depends On D99014

Diff Detail

Event Timeline

antiagainst created this revision.Mar 20 2021, 7:37 AM
antiagainst requested review of this revision.Mar 20 2021, 7:37 AM
mravishankar requested changes to this revision.Mar 23 2021, 11:35 AM
mravishankar added a subscriber: mravishankar.
mravishankar added inline comments.
mlir/lib/Dialect/Affine/IR/AffineOps.cpp
2371

Why not just add it for Max too?

This revision now requires changes to proceed.Mar 23 2021, 11:35 AM
antiagainst added inline comments.Mar 23 2021, 12:07 PM
mlir/lib/Dialect/Affine/IR/AffineOps.cpp
2371

Isn't that at L2388? Am I missing something?

antiagainst marked an inline comment as done.

Rebase

mravishankar accepted this revision.Mar 24 2021, 2:55 PM
mravishankar added inline comments.
mlir/lib/Dialect/Affine/IR/AffineOps.cpp
2371

Oh right. Misread it.

This revision is now accepted and ready to land.Mar 24 2021, 2:55 PM
This revision was landed with ongoing or failed builds.Mar 24 2021, 3:19 PM
This revision was automatically updated to reflect the committed changes.