This is an archive of the discontinued LLVM Phabricator instance.

[NFC][ValueTypes] Align code by column
ClosedPublic

Authored by achieveartificialintelligence on Mar 19 2021, 11:37 AM.

Details

Summary

I adjusted some whitespaces.

Diff Detail

Event Timeline

achieveartificialintelligence requested review of this revision.Mar 19 2021, 11:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 19 2021, 11:37 AM

Resume some whitespaces.

craig.topper accepted this revision.Mar 19 2021, 11:55 AM

Why does this have RISCV in its title?

Otherwise LGTM

This revision is now accepted and ready to land.Mar 19 2021, 11:55 AM
achieveartificialintelligence retitled this revision from [NFC][ValueTypes][RISCV]Align code by column to [NFC][ValueTypes] Align code by column.Mar 19 2021, 12:09 PM

Why does this have RISCV in its title?

Otherwise LGTM

Thanks, I've revised the title.

craig.topper added inline comments.Mar 19 2021, 12:16 PM
llvm/include/llvm/CodeGen/ValueTypes.td
150–151

Should this after a space after the comma?

150–151

Maybe align all the colons in this group with the colon from externref?

211

Should we be aligning the : and the start of ValueType rather than the 251?

craig.topper requested changes to this revision.Mar 19 2021, 12:16 PM
This revision now requires changes to proceed.Mar 19 2021, 12:16 PM
This revision is now accepted and ready to land.Mar 19 2021, 6:29 PM
This revision was landed with ongoing or failed builds.Mar 19 2021, 10:43 PM
This revision was automatically updated to reflect the committed changes.
achieveartificialintelligence marked 3 inline comments as done.