Page MenuHomePhabricator

[AMDGPU][GlobalISel] Fix unable to legalize G_FSHL error
Needs RevisionPublic

Authored by matejam on Mar 17 2021, 8:20 AM.

Details

Summary

Add implementation for lowering G_FSHL instruction in
LegalizerHelper::lower().

Diff Detail

Event Timeline

matejam created this revision.Mar 17 2021, 8:20 AM
matejam requested review of this revision.Mar 17 2021, 8:20 AM
arsenm requested changes to this revision.Mar 17 2021, 3:38 PM

Needs tests. Also I have this implemented already in https://reviews.llvm.org/D76500 (IIRC I think I didn't do the promotion/narrowing parts)

llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
2925

This is not an immediate operand

2929

This isn't the equivalent operation

This revision now requires changes to proceed.Mar 17 2021, 3:38 PM
foad added a comment.Apr 8 2021, 3:31 AM

D76500 has landed now, so maybe abandon this review?