[clang] Add fixit for Wreorder-ctor

[njames93]

Summary

Create fix-it hints to fix the order of constructors.
To make this a lot simpler, I've grouped all the warnings for each out of order initializer into 1.
This is necessary as fixing one initializer would often interfere with other initializers.

[njames93]

Fix formatting issues

[njames93]

Arc got confused

[aaron.ballman]

clang/include/clang/Basic/DiagnosticSemaKinds.td

8611 ↗

(On Diff #331582)

Hmmm, how about initializer order does not match the declaration order or something along those lines? The "some" and "in the correct order" feel a bit hand-wavy for a warning.

clang/lib/Sema/SemaDeclCXX.cpp

5242 ↗

(On Diff #331582)

5247 ↗

(On Diff #331582)

5304 ↗

(On Diff #331582)

[njames93]

clang/lib/Sema/SemaDeclCXX.cpp

5242 ↗

(On Diff #331582)

This was copied from the old impl, Not sure it this is going to change behaviour though.
No tests needed to be updated though,

[njames93]

Address nits.

[aaron.ballman]

Thanks for this! The changes LGTM, but wait to land it for a day or two in case @rsmith has concerns.

clang/lib/Sema/SemaDeclCXX.cpp

5242 ↗

(On Diff #331582)

The diagnostic engine knows how to format anything that's a NamedDecl (including quoting it properly, etc), but it does the same work for DeclarationName. There shouldn't be a change in behavior in this case, just a slight simplification of code.

clang/test/SemaCXX/constructor-initializer.cpp

struct Derived : Base, Base1, virtual V {
   Derived ();
 };
 
 struct Current : Derived {
   int Derived;
   Current() : Derived(1), ::Derived(), // expected-warning {{some initializers aren't given in the correct order}} \
                                        // expected-note {{field 'Derived' will be initialized after base '::Derived'}} \
                                        // expected-note {{base class '::Derived' will be initialized after base 'Derived::V'}}
-                          ::Derived::Base(), // expected-error {{type '::Derived::Base' is not a direct or virtual base of 'Current'}}
-                           Derived::Base1(), // expected-error {{type 'Derived::Base1' is not a direct or virtual base of 'Current'}}
-                           Derived::V(),
-                           ::NonExisting(), // expected-error {{member initializer 'NonExisting' does not name a non-static data member or}}
-                           INT::NonExisting()  {} // expected-error {{'INT' (aka 'int') is not a class, namespace, or enumeration}} \
+              ::Derived::Base(),       // expected-error {{type '::Derived::Base' is not a direct or virtual base of 'Current'}}
+              Derived::Base1(),        // expected-error {{type 'Derived::Base1' is not a direct or virtual base of 'Current'}}
+              ::NonExisting(),      // expected-error {{member initializer 'NonExisting' does not name a non-static data member or}}
+              INT::NonExisting() {} // expected-error {{'INT' (aka 'int') is not a class, namespace, or enumeration}} \
                                                   // expected-error {{member initializer 'NonExisting' does not name a non-static data member or}}
 };
 
 struct M {              // expected-note 2 {{candidate constructor (the implicit copy constructor)}}
 #if __cplusplus >= 201103L // C++11 or later
 // expected-note@-2 2 {{candidate constructor (the implicit move constructor) not viable}}
 #endif
 // expected-note@-4 2 {{'M' declared here}}

clang/test/SemaCXX/warn-reorder-ctor-initialization.cpp

 // RUN: %clang_cc1  -fsyntax-only -Wreorder -verify %s
 
 struct BB {};
 
 struct BB1 {};
 
 class complex : public BB, BB1 { 
-public: 
+public:
   complex()
       : s2(1), // expected-warning {{some initializers aren't given in the correct order}} expected-note {{field 's2' will be initialized after field 's1'}}
         s1(1),
-      s3(3), // expected-note {{field 's3' will be initialized after base 'BB1'}} 
+        s3(3), // expected-note {{field 's3' will be initialized after base 'BB1'}}
         BB1(), // expected-note {{base class 'BB1' will be initialized after base 'BB'}}
-      BB()
-  {}
+        BB() {}
   int s1;
   int s2;
   int s3;
 }; 
 
 
 // testing virtual bases.