Page MenuHomePhabricator

[AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore-xcoff-visibility by default.
ClosedPublic

Authored by DiggerLin on Mar 15 2021, 1:48 PM.

Details

Summary

because we enable -mignore-xcoff-visibility by default when there is no -fvisibility option in the clang in AIX OS
it will cause some test case fail at aix os. in order to let the -mignore-xcoff-visibility to be disable, we need to add the -fvisibility=default for those test case.

Diff Detail

Event Timeline

DiggerLin created this revision.Mar 15 2021, 1:48 PM
DiggerLin requested review of this revision.Mar 15 2021, 1:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 15 2021, 1:48 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
daltenty added inline comments.Mar 15 2021, 1:58 PM
clang/test/CodeGen/hidden-visibility.c
1

dunno if this is also accepted, but I think we prefer an equal sign here:

clang/test/CodeGen/private-extern.c
1

ditto the earlier comment

LGTM (with the equal sign form as @daltenty requested if it works).

This revision is now accepted and ready to land.Mar 15 2021, 2:01 PM
DiggerLin marked an inline comment as done.Mar 15 2021, 2:05 PM
DiggerLin added inline comments.
clang/test/CodeGen/hidden-visibility.c
1

I do not think clang -cc1 support -fvisibility=default

daltenty accepted this revision.Mar 15 2021, 2:06 PM
daltenty added inline comments.
clang/test/CodeGen/hidden-visibility.c
1

I guess the cc1 argument form maybe different for some reason, so feel free to disregard.

DiggerLin marked 2 inline comments as done.Mar 15 2021, 2:06 PM
This revision was landed with ongoing or failed builds.Mar 15 2021, 2:34 PM
This revision was automatically updated to reflect the committed changes.