This is an archive of the discontinued LLVM Phabricator instance.

Differential D98660

[AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore-xcoff-visibility by default.
ClosedPublic

Authored by DiggerLin on Mar 15 2021, 1:48 PM.

Details

Reviewers
hubert.reinterpretcast
jasonliu
sfertile
daltenty
Commits
rGd1f1bff81bd9: [AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore…
Summary

because we enable -mignore-xcoff-visibility by default when there is no -fvisibility option in the clang in AIX OS
it will cause some test case fail at aix os. in order to let the -mignore-xcoff-visibility to be disable, we need to add the -fvisibility=default for those test case.

Diff Detail

Event Timeline

DiggerLin created this revision.Mar 15 2021, 1:48 PM
Herald added a subscriber: arphaman. · View Herald TranscriptMar 15 2021, 1:48 PM
DiggerLin requested review of this revision.Mar 15 2021, 1:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 15 2021, 1:48 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
daltenty added inline comments.Mar 15 2021, 1:58 PM
clang/test/CodeGen/hidden-visibility.c
1

dunno if this is also accepted, but I think we prefer an equal sign here:

clang/test/CodeGen/private-extern.c
1

ditto the earlier comment

hubert.reinterpretcast accepted this revision.Mar 15 2021, 2:01 PM

LGTM (with the equal sign form as @daltenty requested if it works).

This revision is now accepted and ready to land.Mar 15 2021, 2:01 PM
DiggerLin marked an inline comment as done.Mar 15 2021, 2:05 PM
DiggerLin added inline comments.
clang/test/CodeGen/hidden-visibility.c
1

I do not think clang -cc1 support -fvisibility=default

daltenty accepted this revision.Mar 15 2021, 2:06 PM
daltenty added inline comments.
clang/test/CodeGen/hidden-visibility.c
1

I guess the cc1 argument form maybe different for some reason, so feel free to disregard.

DiggerLin marked 2 inline comments as done.Mar 15 2021, 2:06 PM
This revision was landed with ongoing or failed builds.Mar 15 2021, 2:34 PM
Closed by commit rGd1f1bff81bd9: [AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore… (authored by DiggerLin). · Explain Why
This revision was automatically updated to reflect the committed changes.
DiggerLin added a commit: rGd1f1bff81bd9: [AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore….
Harbormaster completed remote builds in B93908: Diff 330796.Mar 15 2021, 3:48 PM

Revision Contents

PathSize
clang/
test/
CodeGen/
2 lines
2 lines
Index/
2 lines

Diff 330813

clang/test/CodeGen/hidden-visibility.c

// RUN: %clang_cc1 %s -emit-llvm -o - | FileCheck %s // RUN: %clang_cc1 %s -fvisibility default -emit-llvm -o - | FileCheck %s
daltentyUnsubmitted
Done
ReplyInline Actions
- // RUN: %clang_cc1 %s -fvisibility default -emit-llvm -o - | FileCheck %s
+ // RUN: %clang_cc1 %s -fvisibility=default -emit-llvm -o - | FileCheck %s
// CHECK: hidden global

dunno if this is also accepted, but I think we prefer an equal sign here:

daltenty: dunno if this is also accepted, but I think we prefer an equal sign here:
DiggerLinAuthorUnsubmitted
Done
ReplyInline Actions

I do not think clang -cc1 support -fvisibility=default

DiggerLin: I do not think clang -cc1 support -fvisibility=default
daltentyUnsubmitted
Not Done
ReplyInline Actions

I guess the cc1 argument form maybe different for some reason, so feel free to disregard.

daltenty: I guess the cc1 argument form maybe different for some reason, so feel free to disregard.
// CHECK: hidden global // CHECK: hidden global
int X __attribute__ ((__visibility__ ("hidden"))) = 123; int X __attribute__ ((__visibility__ ("hidden"))) = 123;

clang/test/CodeGen/private-extern.c

// RUN: %clang_cc1 -emit-llvm -o - %s | FileCheck %s // RUN: %clang_cc1 -fvisibility default -emit-llvm -o - %s | FileCheck %s
daltentyUnsubmitted
Done
ReplyInline Actions

ditto the earlier comment

daltenty: ditto the earlier comment
// CHECK-DAG: @g0 = external hidden constant i32 // CHECK-DAG: @g0 = external hidden constant i32
// CHECK-DAG: @g1 = hidden constant i32 1 // CHECK-DAG: @g1 = hidden constant i32 1
__private_extern__ const int g0; __private_extern__ const int g0;
__private_extern__ const int g1 = 1; __private_extern__ const int g1 = 1;
int f0(void) { int f0(void) {
return g0; return g0;
} }

clang/test/Index/symbol-visibility.c

// RUN: c-index-test -test-print-visibility %s | FileCheck %s // RUN: c-index-test -test-print-visibility -fvisibility=default %s | FileCheck %s
__attribute__ ((visibility ("default"))) void foo1(); __attribute__ ((visibility ("default"))) void foo1();
__attribute__ ((visibility ("hidden"))) void foo2(); __attribute__ ((visibility ("hidden"))) void foo2();
// CHECK: FunctionDecl=foo1:3:47visibility=Default // CHECK: FunctionDecl=foo1:3:47visibility=Default
// CHECK: FunctionDecl=foo2:4:46visibility=Hidden // CHECK: FunctionDecl=foo2:4:46visibility=Hidden