Page MenuHomePhabricator

[AMDGPU, NFC] Refactor FP/BP spill index code in emitPrologue/emitEpilogue

Authored by RamNalamothu on Mar 14 2021, 10:22 PM.

Diff Detail

Event Timeline

RamNalamothu created this revision.Mar 14 2021, 10:22 PM
RamNalamothu requested review of this revision.Mar 14 2021, 10:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 14 2021, 10:22 PM

This LGTM, thank you!

I have a few further suggestions while you are already cleaning things up. If you like them feel free to commit without updating the review.


Can be FI


I'd either change the FI above to FramePointerFI or change this BasePtrFI to FI. I'd lean towards the first choice, as I think the scope for the if gives enough context.

scott.linder accepted this revision.Mar 15 2021, 3:51 PM
This revision is now accepted and ready to land.Mar 15 2021, 3:51 PM

Address review comments.

RamNalamothu marked an inline comment as done.

Address feedback as suggested.

RamNalamothu marked an inline comment as done.Mar 16 2021, 4:01 AM

Incorporated the suggestions. Thank you.