This is an archive of the discontinued LLVM Phabricator instance.

Differential D98566

[AArch64] Parse "rng" feature flag in .arch directive
ClosedPublic

Authored by mcgrathr on Mar 12 2021, 4:16 PM.

Details

Reviewers
phosek
MarkMurrayARM
Commits
rGd5df500ab83b: [AArch64] Parse "rng" feature flag in .arch directive

Diff Detail

Unit TestsFailed

TimeTest
40 msx64 debian > Flang.Semantics::omp-do05.f90
60 msx64 debian > Flang.Semantics::omp-do13.f90
40 msx64 debian > Flang.Semantics::omp-nested01.f90
50 msx64 debian > Flang.Semantics::omp-reduction07.f90
200 msx64 windows > lld.MachO/invalid::range-check.s

Event Timeline

mcgrathr created this revision.Mar 12 2021, 4:16 PM
Herald added subscribers: danielkiss, hiraditya, kristof.beyls. · View Herald TranscriptMar 12 2021, 4:16 PM
mcgrathr requested review of this revision.Mar 12 2021, 4:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 12 2021, 4:16 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B93624: Diff 330397.Mar 12 2021, 5:55 PM
phosek accepted this revision.Mar 16 2021, 12:58 PM

LGTM

This revision is now accepted and ready to land.Mar 16 2021, 12:58 PM
This revision was landed with ongoing or failed builds.Mar 16 2021, 2:10 PM
Closed by commit rGd5df500ab83b: [AArch64] Parse "rng" feature flag in .arch directive (authored by mcgrathr). · Explain Why
This revision was automatically updated to reflect the committed changes.
mcgrathr added a commit: rGd5df500ab83b: [AArch64] Parse "rng" feature flag in .arch directive.

Revision Contents

PathSize
llvm/
lib/
Target/
AArch64/
AsmParser/
1 line
test/
MC/
AArch64/
6 lines

Diff 330397

llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp

Show First 20 Lines • Show All 2,903 Lines • ▼ Show 20 Lines const FeatureBitset Features;
{"predres", {AArch64::FeaturePredRes}}, {"predres", {AArch64::FeaturePredRes}},
{"ccdp", {AArch64::FeatureCacheDeepPersist}}, {"ccdp", {AArch64::FeatureCacheDeepPersist}},
{"mte", {AArch64::FeatureMTE}}, {"mte", {AArch64::FeatureMTE}},
{"memtag", {AArch64::FeatureMTE}}, {"memtag", {AArch64::FeatureMTE}},
{"tlb-rmi", {AArch64::FeatureTLB_RMI}}, {"tlb-rmi", {AArch64::FeatureTLB_RMI}},
{"pan-rwv", {AArch64::FeaturePAN_RWV}}, {"pan-rwv", {AArch64::FeaturePAN_RWV}},
{"ccpp", {AArch64::FeatureCCPP}}, {"ccpp", {AArch64::FeatureCCPP}},
{"rcpc", {AArch64::FeatureRCPC}}, {"rcpc", {AArch64::FeatureRCPC}},
{"rng", {AArch64::FeatureRandGen}},
{"sve", {AArch64::FeatureSVE}}, {"sve", {AArch64::FeatureSVE}},
{"sve2", {AArch64::FeatureSVE2}}, {"sve2", {AArch64::FeatureSVE2}},
{"sve2-aes", {AArch64::FeatureSVE2AES}}, {"sve2-aes", {AArch64::FeatureSVE2AES}},
{"sve2-sm4", {AArch64::FeatureSVE2SM4}}, {"sve2-sm4", {AArch64::FeatureSVE2SM4}},
{"sve2-sha3", {AArch64::FeatureSVE2SHA3}}, {"sve2-sha3", {AArch64::FeatureSVE2SHA3}},
{"sve2-bitperm", {AArch64::FeatureSVE2BitPerm}}, {"sve2-bitperm", {AArch64::FeatureSVE2BitPerm}},
{"ls64", {AArch64::FeatureLS64}}, {"ls64", {AArch64::FeatureLS64}},
{"xs", {AArch64::FeatureXS}}, {"xs", {AArch64::FeatureXS}},
▲ Show 20 Lines • Show All 3,429 Lines • Show Last 20 Lines

llvm/test/MC/AArch64/directive-arch.s

Show All 11 Lines
// Add an unrelated feature to accept the directive. // Add an unrelated feature to accept the directive.
.arch armv8.1-a+crypto .arch armv8.1-a+crypto
casa w5, w7, [x20] casa w5, w7, [x20]
# CHECK: casa w5, w7, [x20] # CHECK: casa w5, w7, [x20]
.arch armv8-a+lse .arch armv8-a+lse
casa w5, w7, [x20] casa w5, w7, [x20]
# CHECK: casa w5, w7, [x20] # CHECK: casa w5, w7, [x20]
.arch armv8.5-a+rng
mrs x0, rndr
mrs x0, rndrrs
# CHECK: mrs x0, RNDR
# CHECK: mrs x0, RNDRRS