This is an archive of the discontinued LLVM Phabricator instance.

[OpenCL] Set target as spir for c-index-test for OpenCL
ClosedPublic

Authored by azabaznov on Mar 12 2021, 10:57 AM.

Details

Summary

Otherwise (for other targets) testing may be non-determistic as
targets support different extension/feature set, but SPIR target
support all extensions/features by default

Diff Detail

Event Timeline

azabaznov created this revision.Mar 12 2021, 10:57 AM
azabaznov requested review of this revision.Mar 12 2021, 10:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 12 2021, 10:57 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Anastasia accepted this revision.Mar 12 2021, 11:10 AM

LGTM! I can't see why we would need to tests anything target-specific here anyway, so I think the change is reasonable.

This revision is now accepted and ready to land.Mar 12 2021, 11:10 AM

Can we get this landed asap please?

This revision was landed with ongoing or failed builds.Mar 12 2021, 12:14 PM
This revision was automatically updated to reflect the committed changes.

Can we get this landed asap please?

Done! Sorry for the noise.

@Anastasia, thanks for landing this! Sorry for delay, I though that this can wait until Monday