This is an archive of the discontinued LLVM Phabricator instance.

Differential D98451

[AMDGPU] Remove dead MTBUF patterns
ClosedPublic

Authored by rampitec on Mar 11 2021, 1:56 PM.

Details

Reviewers
arsenm
dstuttard
critson
Commits
rG6e8a0213a342: [AMDGPU] Remove dead MTBUF patterns
Summary

These patterns are obviously dead, they are using format
operand which is not selected and we have no corresponding
SelectMUBUF() function.

Diff Detail

Event Timeline

rampitec created this revision.Mar 11 2021, 1:56 PM
Herald added subscribers: kerbowa, hiraditya, t-tye and 5 others. · View Herald TranscriptMar 11 2021, 1:57 PM
rampitec requested review of this revision.Mar 11 2021, 1:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 11 2021, 1:57 PM
Herald added a subscriber: wdng. · View Herald Transcript
arsenm accepted this revision.Mar 11 2021, 2:09 PM
This revision is now accepted and ready to land.Mar 11 2021, 2:09 PM
This revision was landed with ongoing or failed builds.Mar 11 2021, 2:13 PM
Closed by commit rG6e8a0213a342: [AMDGPU] Remove dead MTBUF patterns (authored by rampitec). · Explain Why
This revision was automatically updated to reflect the committed changes.
rampitec added a commit: rG6e8a0213a342: [AMDGPU] Remove dead MTBUF patterns.
Harbormaster completed remote builds in B93368: Diff 330064.Mar 11 2021, 7:04 PM

Revision Contents

PathSize
llvm/
lib/
Target/
AMDGPU/
24 lines

Diff 330064

llvm/lib/Target/AMDGPU/BUFInstructions.td

Show First 20 Lines • Show All 219 Lines • ▼ Show 20 Linesclass MTBUF_Load_Pseudo <string opName,
let mayStore = 0; let mayStore = 0;
let elements = elems; let elements = elems;
} }
multiclass MTBUF_Pseudo_Loads<string opName, RegisterClass vdataClass, multiclass MTBUF_Pseudo_Loads<string opName, RegisterClass vdataClass,
int elems, ValueType load_vt = i32, int elems, ValueType load_vt = i32,
SDPatternOperator ld = null_frag> { SDPatternOperator ld = null_frag> {
def _OFFSET : MTBUF_Load_Pseudo <opName, BUFAddrKind.Offset, vdataClass, elems, def _OFFSET : MTBUF_Load_Pseudo <opName, BUFAddrKind.Offset, vdataClass, elems>,
[(set load_vt:$vdata,
(ld (MUBUFOffset v4i32:$srsrc, i32:$soffset, i16:$offset, i8:$format,
i1:$glc, i1:$slc, i1:$tfe, i1:$dlc, i1:$swz)))]>,
MTBUFAddr64Table<0, NAME>; MTBUFAddr64Table<0, NAME>;
def _ADDR64 : MTBUF_Load_Pseudo <opName, BUFAddrKind.Addr64, vdataClass, elems, def _ADDR64 : MTBUF_Load_Pseudo <opName, BUFAddrKind.Addr64, vdataClass, elems>,
[(set load_vt:$vdata,
(ld (MUBUFAddr64 v4i32:$srsrc, i64:$vaddr, i32:$soffset, i16:$offset,
i8:$format, i1:$glc, i1:$slc, i1:$tfe, i1:$dlc, i1:$swz)))]>,
MTBUFAddr64Table<1, NAME>; MTBUFAddr64Table<1, NAME>;
def _OFFEN : MTBUF_Load_Pseudo <opName, BUFAddrKind.OffEn, vdataClass, elems>; def _OFFEN : MTBUF_Load_Pseudo <opName, BUFAddrKind.OffEn, vdataClass, elems>;
def _IDXEN : MTBUF_Load_Pseudo <opName, BUFAddrKind.IdxEn, vdataClass, elems>; def _IDXEN : MTBUF_Load_Pseudo <opName, BUFAddrKind.IdxEn, vdataClass, elems>;
def _BOTHEN : MTBUF_Load_Pseudo <opName, BUFAddrKind.BothEn, vdataClass, elems>; def _BOTHEN : MTBUF_Load_Pseudo <opName, BUFAddrKind.BothEn, vdataClass, elems>;
let DisableWQM = 1 in { let DisableWQM = 1 in {
def _OFFSET_exact : MTBUF_Load_Pseudo <opName, BUFAddrKind.Offset, vdataClass, elems>; def _OFFSET_exact : MTBUF_Load_Pseudo <opName, BUFAddrKind.Offset, vdataClass, elems>;
def _OFFEN_exact : MTBUF_Load_Pseudo <opName, BUFAddrKind.OffEn, vdataClass, elems>; def _OFFEN_exact : MTBUF_Load_Pseudo <opName, BUFAddrKind.OffEn, vdataClass, elems>;
Show All 21 Linesclass MTBUF_Store_Pseudo <string opName,
let mayStore = 1; let mayStore = 1;
let elements = elems; let elements = elems;
} }
multiclass MTBUF_Pseudo_Stores<string opName, RegisterClass vdataClass, multiclass MTBUF_Pseudo_Stores<string opName, RegisterClass vdataClass,
int elems, ValueType store_vt = i32, int elems, ValueType store_vt = i32,
SDPatternOperator st = null_frag> { SDPatternOperator st = null_frag> {
def _OFFSET : MTBUF_Store_Pseudo <opName, BUFAddrKind.Offset, vdataClass, elems, def _OFFSET : MTBUF_Store_Pseudo <opName, BUFAddrKind.Offset, vdataClass, elems>,
[(st store_vt:$vdata, (MUBUFOffset v4i32:$srsrc, i32:$soffset,
i16:$offset, i8:$format, i1:$glc,
i1:$slc, i1:$tfe, i1:$dlc, i1:$swz))]>,
MTBUFAddr64Table<0, NAME>; MTBUFAddr64Table<0, NAME>;
def _ADDR64 : MTBUF_Store_Pseudo <opName, BUFAddrKind.Addr64, vdataClass, elems, def _ADDR64 : MTBUF_Store_Pseudo <opName, BUFAddrKind.Addr64, vdataClass, elems>,
[(st store_vt:$vdata, (MUBUFAddr64 v4i32:$srsrc, i64:$vaddr, i32:$soffset,
i16:$offset, i8:$format, i1:$glc,
i1:$slc, i1:$tfe, i1:$dlc, i1:$swz))]>,
MTBUFAddr64Table<1, NAME>; MTBUFAddr64Table<1, NAME>;
def _OFFEN : MTBUF_Store_Pseudo <opName, BUFAddrKind.OffEn, vdataClass, elems>; def _OFFEN : MTBUF_Store_Pseudo <opName, BUFAddrKind.OffEn, vdataClass, elems>;
def _IDXEN : MTBUF_Store_Pseudo <opName, BUFAddrKind.IdxEn, vdataClass, elems>; def _IDXEN : MTBUF_Store_Pseudo <opName, BUFAddrKind.IdxEn, vdataClass, elems>;
def _BOTHEN : MTBUF_Store_Pseudo <opName, BUFAddrKind.BothEn, vdataClass, elems>; def _BOTHEN : MTBUF_Store_Pseudo <opName, BUFAddrKind.BothEn, vdataClass, elems>;
let DisableWQM = 1 in { let DisableWQM = 1 in {
def _OFFSET_exact : MTBUF_Store_Pseudo <opName, BUFAddrKind.Offset, vdataClass, elems>; def _OFFSET_exact : MTBUF_Store_Pseudo <opName, BUFAddrKind.Offset, vdataClass, elems>;
▲ Show 20 Lines • Show All 2,347 Lines • Show Last 20 Lines