Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Talked with @eugenis offline. I'm going to look into getting rid of "base tags" by only storing the changeable bits in shadow.
compiler-rt/lib/hwasan/hwasan_linux.cpp | ||
---|---|---|
225 | Is this still needed if we mask out the higher non-tag bits? |
compiler-rt/lib/hwasan/hwasan_linux.cpp | ||
---|---|---|
225 | Yes, tag bits are in userspace, so non-heap pointers are unlikely to have 0 there. |
Comment Actions
LGTM
compiler-rt/lib/hwasan/hwasan_linux.cpp | ||
---|---|---|
225 | ah, it's not because of the "base tag", it's because some app memory is outside of the aliased / taggable range. |
InTaggableRegion should be the first as likely the cheepest of those checks