Page MenuHomePhabricator

[OpenMP] Restore backwards compatibility for libomptarget
ClosedPublic

Authored by jhuber6 on Mar 10 2021, 8:30 AM.

Details

Summary

The changes introduced in D87946 changed the API for libomptarget
functions. __kmpc_push_target_tripcount was a function in Clang 11.x
but was not given a backward-compatible interface accidentally. This
will make it backwards compatible, but will require Clang 12 to recompile.

Diff Detail

Event Timeline

jhuber6 created this revision.Mar 10 2021, 8:30 AM
jhuber6 requested review of this revision.Mar 10 2021, 8:30 AM
Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptMar 10 2021, 8:30 AM
jdoerfert accepted this revision.Mar 10 2021, 8:47 AM

LG. We should have a test that references the entire interface so we realize if something breaks.

This revision is now accepted and ready to land.Mar 10 2021, 8:47 AM
cchen added a subscriber: cchen.Mar 10 2021, 9:16 AM

I think some existing Clang OpenMP codegen tests will break if they are testing against __kmpc_push_target_tripcount.

I think some existing Clang OpenMP codegen tests will break if they are testing against __kmpc_push_target_tripcount.

I'm working on fixing the tests, I also forgot to include it in the exports

jhuber6 updated this revision to Diff 329709.Mar 10 2021, 10:28 AM

Updating tests and adding the new function to the exports.

cchen accepted this revision.Mar 10 2021, 11:17 AM

LGTM.

This revision was landed with ongoing or failed builds.Mar 11 2021, 6:52 AM
This revision was automatically updated to reflect the committed changes.