verifyCompatibleShapes is not transitive. Create an n-ary version and
update SameOperandShapes and SameOperandAndResultShapes traits to use
it.
Details
Details
- Reviewers
frgossen rriddle - Commits
- rG25a20b8aa68e: [mlir] Correct verifyCompatibleShapes
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
A test case that would have passed before and fails now would be nice:
%2 = some_same_shape_op %0, %1 : tensor<?xf32>, tensor<4xf32> -> tensor<7xf32>
mlir/lib/IR/TypeUtilities.cpp | ||
---|---|---|
118 | nit: extra line? | |
122 | Should the same comment exists twice? I think it would be enough in the header. | |
130 | any_of? | |
147–149 | If you extract this, it'd be easier to read, I feel. |
nit: extra line?