This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Simplify toplevel arm/thumb checks
AbandonedPublic

Authored by mstorsjo on Mar 9 2021, 10:47 PM.

Details

Summary

Mapping of arm*hf to armhf is done in construct_compiler_rt_default_triple
now after D98173 (making it available for builds that target
compiler-rt/lib/builtins directly, too). Do the check for thumb for any arm
target, not only armhf.

Diff Detail

Event Timeline

mstorsjo created this revision.Mar 9 2021, 10:47 PM
mstorsjo requested review of this revision.Mar 9 2021, 10:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2021, 10:47 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
mstorsjo edited subscribers, added: llvm-commits; removed: libcxx-commits.Mar 9 2021, 10:48 PM
phosek accepted this revision.Mar 11 2021, 1:19 AM

LGTM

This revision is now accepted and ready to land.Mar 11 2021, 1:19 AM
mstorsjo abandoned this revision.Mar 11 2021, 12:47 PM

The bit of D98173 that this relies on was reverted, so this does't make sense as such now.