This is an archive of the discontinued LLVM Phabricator instance.

Fix Dialect doc generation to special case for the Builtin dialect empty name
ClosedPublic

Authored by mehdi_amini on Mar 5 2021, 1:08 PM.

Details

Summary

This should fix the issue with an empty entry for the builtin dialect on
the website.

Diff Detail

Event Timeline

mehdi_amini created this revision.Mar 5 2021, 1:08 PM
mehdi_amini requested review of this revision.Mar 5 2021, 1:08 PM
rriddle accepted this revision.Mar 5 2021, 1:16 PM
rriddle added inline comments.
mlir/tools/mlir-tblgen/OpDocGen.cpp
226

Don't wrap the Builtin in quotes, it gives the wrong impression given that this isn't the namespace of the dialect.

This revision is now accepted and ready to land.Mar 5 2021, 1:16 PM

Do not put "Builtin" in quotes

jpienaar accepted this revision.Mar 5 2021, 1:44 PM
jpienaar added a subscriber: jpienaar.

Thanks :)

This revision was landed with ongoing or failed builds.Mar 5 2021, 3:48 PM
This revision was automatically updated to reflect the committed changes.