This is an archive of the discontinued LLVM Phabricator instance.

NFC: Glob all python sources in the MLIR Python bindings.
ClosedPublic

Authored by stellaraccident on Mar 4 2021, 8:50 PM.

Details

Summary
  • Also switches to use symlinks vs copy as that enables edit-and-continue python development.
  • Broken out of https://reviews.llvm.org/D97995 per request from reviewer.

Diff Detail

Event Timeline

stellaraccident created this revision.Mar 4 2021, 8:50 PM
stellaraccident requested review of this revision.Mar 4 2021, 8:50 PM

Break out cmake changes and rebase.

Push to the right diff.

mehdi_amini accepted this revision.Mar 4 2021, 10:40 PM

Thanks!

Also switches to use symlinks vs copy as that enables edit-and-continue python development.

Ah that was bugging me recently!

This revision is now accepted and ready to land.Mar 4 2021, 10:40 PM
This revision was landed with ongoing or failed builds.Mar 5 2021, 10:22 AM
This revision was automatically updated to reflect the committed changes.

It looks like this change to create symlinks in the build area also results in those symlinks getting installed in the install area... This seems like a bad idea, since the install area ends up having symlinks back to the source tree. However, I don't see a simple way to change the install action to fix that. Any ideas here?

I think we should restore copy_if_different.