This is an archive of the discontinued LLVM Phabricator instance.

[llvm][support] Fix unused variable bug caused by D97504
AbandonedPublic

Authored by oontvoo on Mar 4 2021, 8:35 AM.

Details

Reviewers
mgorny
ondrasej
Summary

Detail: In D97504, I replaced the first getX86CpuIDAndInfo() call in getHhostCpuName() with getVendorSignature() (because the purpose of that was to get the vendor signature), but I hadn't noticed that it was also using the EAX (MaxLeaf) value.

Diff Detail

Event Timeline

oontvoo created this revision.Mar 4 2021, 8:35 AM
oontvoo requested review of this revision.Mar 4 2021, 8:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 4 2021, 8:35 AM
oontvoo updated this revision to Diff 328190.Mar 4 2021, 8:40 AM

updated comment

ondrasej accepted this revision.Mar 4 2021, 8:42 AM
This revision is now accepted and ready to land.Mar 4 2021, 8:42 AM
oontvoo abandoned this revision.Mar 4 2021, 8:52 AM

The original patch caused a failure and was reverted. So I'll move this fix to the roll-forward patch