This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] fix bug in reduction chain
ClosedPublic

Authored by aartbik on Mar 3 2021, 1:20 PM.

Details

Summary

Found with exhaustive testing, it is possible that a while loop
appears in between chainable for loops. As long as we don't
scalarize reductions in while loops, this means we need to
terminate the chain at the while. This also refactors the
reduction code into more readable helper methods.

Diff Detail

Event Timeline

aartbik created this revision.Mar 3 2021, 1:20 PM
aartbik requested review of this revision.Mar 3 2021, 1:20 PM
bixia accepted this revision.Mar 3 2021, 5:21 PM

Thank you for fixing this!

This revision is now accepted and ready to land.Mar 3 2021, 5:21 PM
This revision was landed with ongoing or failed builds.Mar 3 2021, 5:38 PM
This revision was automatically updated to reflect the committed changes.