This is an archive of the discontinued LLVM Phabricator instance.

Differential D97777

Add __builtin_isnan(__fp16) testcase
ClosedPublic

Authored by thopre on Mar 2 2021, 9:06 AM.

Details

Reviewers
mibintc
kpn
efriedma
sepavloff
rjmccall
jonpa
Commits
rG52bfe6605ab7: Add __builtin_isnan(__fp16) testcase
rGe77b5c40d576: Add __builtin_isnan(__fp16) testcase

Diff Detail

Unit TestsFailed

TimeTest
40 msx64 windows > LLVM.ExecutionEngine/JITLink/AArch64::MachO_arm64_ehframe.test
50 msx64 windows > LLVM.ExecutionEngine/JITLink/AArch64::MachO_arm64_relocations.s
50 msx64 windows > LLVM.ExecutionEngine/JITLink/X86::ELF_skip_debug_sections.s
80 msx64 windows > LLVM.ExecutionEngine/JITLink/X86::ELF_weak_definitions.s
50 msx64 windows > LLVM.ExecutionEngine/JITLink/X86::ELF_x86-64_common.s
View Full Test Results (19 Failed)

Event Timeline

thopre requested review of this revision.Mar 2 2021, 9:06 AM
thopre created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 2 2021, 9:06 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B91592: Diff 327480.Mar 2 2021, 10:46 AM
rjmccall accepted this revision.Mar 2 2021, 11:03 AM

LGTM

This revision is now accepted and ready to land.Mar 2 2021, 11:03 AM
This revision was landed with ongoing or failed builds.Mar 2 2021, 1:01 PM
Closed by commit rGe77b5c40d576: Add __builtin_isnan(__fp16) testcase (authored by thopre). · Explain Why
This revision was automatically updated to reflect the committed changes.
thopre added a commit: rGe77b5c40d576: Add __builtin_isnan(__fp16) testcase.
thopre added a reverting change: rG6d6e7132f9c7: Revert "Add __builtin_isnan(__fp16) testcase".Mar 4 2021, 4:18 AM
thopre reopened this revision.Mar 4 2021, 5:02 AM
This revision is now accepted and ready to land.Mar 4 2021, 5:02 AM
thopre updated this revision to Diff 328130.Mar 4 2021, 5:03 AM

Adapt to revert of __builtin_isinf

This revision was landed with ongoing or failed builds.Mar 4 2021, 5:03 AM
Closed by commit rG52bfe6605ab7: Add __builtin_isnan(__fp16) testcase (authored by thopre). · Explain Why
This revision was automatically updated to reflect the committed changes.
thopre added a commit: rG52bfe6605ab7: Add __builtin_isnan(__fp16) testcase.
Harbormaster completed remote builds in B92043: Diff 328130.Mar 4 2021, 3:52 PM

Revision Contents

PathSize
clang/
test/
CodeGen/
19 lines

Diff 327480

clang/test/CodeGen/strictfp_builtins.c

Show First 20 Lines • Show All 123 Lines • ▼ Show 20 Lines
// CHECK-NEXT: ret void // CHECK-NEXT: ret void
// //
void test_isinf_sign(double d) { void test_isinf_sign(double d) {
P(isinf_sign, (d)); P(isinf_sign, (d));
return; return;
} }
// CHECK-LABEL: @test_fp16_isnan(
// CHECK-NEXT: entry:
// CHECK-NEXT: [[H_ADDR:%.*]] = alloca half, align 2
// CHECK-NEXT: store half [[H:%.*]], half* [[H_ADDR]], align 2
// CHECK-NEXT: [[TMP0:%.*]] = load half, half* [[H_ADDR]], align 2
// CHECK-NEXT: [[BITCAST:%.*]] = bitcast half [[TMP0]] to i16
// CHECK-NEXT: [[ABS:%.*]] = and i16 [[BITCAST]], [[#%u,0x7FFF]]
// CHECK-NEXT: [[TMP1:%.*]] = sub i16 [[#%u,0x7C00]], [[ABS]]
// CHECK-NEXT: [[ISNAN:%.*]] = lshr i16 [[TMP1]], 15
// CHECK-NEXT: [[RES:%.*]] = zext i16 [[ISNAN]] to i32
// CHECK-NEXT: call void @p(i8* getelementptr inbounds ([9 x i8], [9 x i8]* @.str.[[#STRID:STRID+1]], i64 0, i64 0), i32 [[RES]]) [[ATTR4]]
// CHECK-NEXT: ret void
//
void test_fp16_isnan(__fp16 h) {
P(isnan, (h));
return;
}
// CHECK-LABEL: @test_float_isnan( // CHECK-LABEL: @test_float_isnan(
// CHECK-NEXT: entry: // CHECK-NEXT: entry:
// CHECK-NEXT: [[F_ADDR:%.*]] = alloca float, align 4 // CHECK-NEXT: [[F_ADDR:%.*]] = alloca float, align 4
// CHECK-NEXT: store float [[F:%.*]], float* [[F_ADDR]], align 4 // CHECK-NEXT: store float [[F:%.*]], float* [[F_ADDR]], align 4
// CHECK-NEXT: [[TMP0:%.*]] = load float, float* [[F_ADDR]], align 4 // CHECK-NEXT: [[TMP0:%.*]] = load float, float* [[F_ADDR]], align 4
// CHECK-NEXT: [[BITCAST:%.*]] = bitcast float [[TMP0]] to i32 // CHECK-NEXT: [[BITCAST:%.*]] = bitcast float [[TMP0]] to i32
// CHECK-NEXT: [[ABS:%.*]] = and i32 [[BITCAST]], [[#%u,0x7FFFFFFF]] // CHECK-NEXT: [[ABS:%.*]] = and i32 [[BITCAST]], [[#%u,0x7FFFFFFF]]
// CHECK-NEXT: [[TMP1:%.*]] = sub i32 [[#%u,0x7F800000]], [[ABS]] // CHECK-NEXT: [[TMP1:%.*]] = sub i32 [[#%u,0x7F800000]], [[ABS]]
▲ Show 20 Lines • Show All 49 Lines • Show Last 20 Lines