This is an archive of the discontinued LLVM Phabricator instance.

[cte][NFC] Remove all references to stdlib stream headers.
ClosedPublic

Authored by njames93 on Mar 2 2021, 7:32 AM.

Details

Summary

Inclusion of iostream is frobidden and using other stream classes from standard library is discouraged as per https://llvm.org/docs/CodingStandards.html#include-iostream-is-forbidden

Diff Detail

Event Timeline

njames93 created this revision.Mar 2 2021, 7:32 AM
njames93 requested review of this revision.Mar 2 2021, 7:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 2 2021, 7:32 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
aaron.ballman added inline comments.Mar 2 2021, 7:56 AM
clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp
38
sammccall accepted this revision.Mar 2 2021, 8:23 AM

LGTM (apart from Aaron's comment!)

This revision is now accepted and ready to land.Mar 2 2021, 8:23 AM
njames93 added inline comments.Mar 2 2021, 8:35 AM
clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp
38

Duh 🙄

This revision was landed with ongoing or failed builds.Mar 2 2021, 1:57 PM
This revision was automatically updated to reflect the committed changes.
njames93 marked an inline comment as done.