Fix DecisionForestBenchmark.cpp compile errors

[poelmanc]

Summary

clang-tools-extra/clangd/benchmarks/CompletionModel/DecisionForestBenchmark.cpp fails to compile since "CompletionModel.h" is auto-generated from clang-tools-extra/clangd/quality/model/features.json, which was changed in https://reviews.llvm.org/D94697 to remove setFilterLength and setIsForbidden, rename setFileProximityDistance and setSymbolScopeDistance, and add setNumNameInContext and setFractionNameInContext. This patch removes calls to the two removed functions, updates calls to the two renamed functions, and adds calls to the two new functions. (20 is an arbitrary choice for the setNumNameInContext argument.) It also changes the FlipCoin argument from float to double to silence lossy conversion warnings.

Note: I don't use this tool but encountered the build errors and took a shot at fixing them. Please holler if there's another recommended solution. Thanks!

[poelmanc]

Shorten comment and add period.

[usaxena95]

LG. Thanks for noticing and fixing it!

clang-tools-extra/clangd/benchmarks/CompletionModel/DecisionForestBenchmark.cpp

41–42

s/keys()/size().

[poelmanc]

Fix comment.

[poelmanc]

Fixed comment as requested (keys()->size().) I don't have commit access so if you can push it that would be great, thanks!

clang-tools-extra/clangd/benchmarks/CompletionModel/DecisionForestBenchmark.cpp

 #include "llvm/ADT/StringRef.h"
 
 #include <random>
 
 namespace clang {
 namespace clangd {
 namespace {
 std::vector<Example> generateRandomDataset(int NumExamples) {
-  auto FlipCoin = [&](float Probability) {
+  auto FlipCoin = [&](double Probability) {
     return rand() % 1000 <= Probability * 1000;
   };
   auto RandInt = [&](int Max) { return rand() % Max; };
   auto RandFloat = [&](float Max = 1.0) {
     return rand() % 1000 / 1000.0 * Max;
   };
 
   std::vector<Example> Examples;
   Examples.reserve(NumExamples);
   for (int I = 0; I < NumExamples; ++I) {
     Example E;
     E.setIsDeprecated(FlipCoin(0.1));           // Boolean.
     E.setIsReservedName(FlipCoin(0.1));         // Boolean.
     E.setIsImplementationDetail(FlipCoin(0.3)); // Boolean.
     E.setNumReferences(RandInt(10000));         // Can be large integer.
     E.setSymbolCategory(RandInt(10));           // 10 Symbol Category.
-
+    E.setNumNameInContext(RandInt(20));         // 0 to ContextWords->size().
+    E.setFractionNameInContext(RandFloat(1.0)); // Float in range [0,1].
     E.setIsNameInContext(FlipCoin(0.5)); // Boolean.
-    E.setIsForbidden(FlipCoin(0.1));     // Boolean.
     E.setIsInBaseClass(FlipCoin(0.3));   // Boolean.
-    E.setFileProximityDistance(
+    E.setFileProximityDistanceCost(
         FlipCoin(0.1) ? 999999 // Sometimes file distance is not available.
                       : RandInt(20));
     E.setSemaFileProximityScore(RandFloat(1)); // Float in range [0,1].
-    E.setSymbolScopeDistance(
+    E.setSymbolScopeDistanceCost(
         FlipCoin(0.1) ? 999999 // Sometimes scope distance is not available.
                       : RandInt(20));
     E.setSemaSaysInScope(FlipCoin(0.5));      // Boolean.
     E.setScope(RandInt(4));                   // 4 Scopes.
     E.setContextKind(RandInt(32));            // 32 Context kinds.
     E.setIsInstanceMember(FlipCoin(0.5));     // Boolean.
     E.setHadContextType(FlipCoin(0.6));       // Boolean.
     E.setHadSymbolType(FlipCoin(0.6));        // Boolean.
     E.setTypeMatchesPreferred(FlipCoin(0.5)); // Boolean.
-    E.setFilterLength(RandInt(15));
     Examples.push_back(E);
   }
   return Examples;
 }
 
 void runDecisionForestPrediciton(const std::vector<Example> Examples) {
   for (const Example &E : Examples)
     Evaluate(E);