- User Since
- Sep 11 2019, 11:23 AM (5 w, 2 d)
Fri, Oct 11
Wed, Oct 9
Thanks for the prompt review and feedback! MyDeveloperDay, your "drive-by" comments are quite welcome as the goal is to make clang-tidy and clang-format work better in tandem. You are correct that my prior version could have thwarted someone's chang-tidy checker that adds whitespace, which was an oversight on my part. I've updated the patch to change isWhitespace( RemovalText ) to RemovalText.isBlank(). Now this only applies to Removals that remove all non-blank text from a line. I also updated the Title and Summary accordingly, adding the example that most confounded me of ": a()\n", which readability-redundant-member-init makes blank with a combination of two separate removals: one for the ":" and one for the "a()".
Tue, Oct 8
Fri, Oct 4
Hi @alexfh, @jonathanmeier has reviewed my pull request but lacks commit access. It changes ~30 lines of code isolated to modernize-use-using.cpp and adds ~60 lines of tests. If you have time I'd greatly appreciate it if you could provide any feedback or commit it. Alternatively can you suggest someone else who can review it? Thanks!
Sep 12 2019
Sorry one more test at the end to make sure a multi-typedef with all that Variadic stuff still doesn't get changed to using.
Nice catch, that simplifies the code quite a bit! I added two more nested, complex multiple-template-argument tests and am happy to add more.
Thanks for the stressing test cases. I reverted to your original test case with a single >, added a separate one with a single <, and expanded the final case to have a non-balanced number of > and <. I added all your new cases, with variations for non-fixed (multiple typedef) and fixed (single typedef) examples.
Sep 11 2019
Wow, thanks for the super-quick testing, feedback and a new test case! I added a slightly enhanced version of your test case to the modernize-use-using.cpp test file and got it passing by treating tok::less and tok::right as AngleBrackets only when ParenLevel == 0. See updated patch above. Holler if you think of any other stressing cases!