Page MenuHomePhabricator

[AIX] Disable $ORIGIN rpath
Changes PlannedPublic

Authored by daltenty on Feb 26 2021, 3:01 PM.

Details

Summary

The AIX loader doesn't support relative libpaths, so this mechanism
doesn't work and just messes up the resulting libpath. Also make sure
BUILD_WITH_INSTALL_RPATH is set, since we can't change the rpath on
install.

Diff Detail

Event Timeline

daltenty created this revision.Feb 26 2021, 3:01 PM
daltenty requested review of this revision.Feb 26 2021, 3:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 26 2021, 3:01 PM
DiggerLin added inline comments.Mar 3 2021, 9:31 AM
llvm/cmake/modules/AddLLVM.cmake
2112

in the following

  1. Enable BUILD_WITH_INSTALL_RPATH unless CMAKE_BUILD_RPATH is set. if("${CMAKE_BUILD_RPATH}" STREQUAL "") set_property(TARGET ${name} PROPERTY BUILD_WITH_INSTALL_RPATH ON) endif()

we enable the PROPERTY BUILD_WITH_INSTALL_RPATH anyway?

https://reviews.llvm.org/D93177 [CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build rpath

daltenty planned changes to this revision.Mar 18 2021, 11:01 AM