This is an archive of the discontinued LLVM Phabricator instance.

[llvm] Mark Transforms/Attributor/ArgumentPromotion/crash.ll as unsupported on Windows
AbandonedPublic

Authored by stella.stamenova on Feb 26 2021, 2:52 PM.

Details

Summary

The test actually passes in Release and fails in Debug, but there's no way to disable it for just some flavors and not others. The failure is due to https://reviews.llvm.org/rGd13daa4018faf6a3427d80ed17e10f5913fee1b5 and it is expected that it will eventually be fixed but in the mean time this disables the failures

Diff Detail

Event Timeline

stella.stamenova requested review of this revision.Feb 26 2021, 2:52 PM
Herald added a reviewer: baziotis. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
This revision is now accepted and ready to land.Feb 27 2021, 10:07 AM
jdoerfert accepted this revision.Feb 27 2021, 2:15 PM

LG, could you check if this is necessary after D97238 ?

LG, could you check if this is necessary after D97238 ?

It looks like it is no longer necessary! Thanks!

stella.stamenova abandoned this revision.Mar 1 2021, 2:12 PM

Apologies again that this took so long to be fixed.