This is an archive of the discontinued LLVM Phabricator instance.

[WIP][RGT] Rotten Green Test checking for LLVM and Clang unittests
Needs ReviewPublic

Authored by probinson on Feb 26 2021, 10:33 AM.

Details

Reviewers
MaskRay
dblaikie
Summary

This is an enhancement of the 'googletest' support code, to report
test assertions (EXPECT_* and ASSERT_* macros) that are not executed.
An un-executed assertion looks like it tests something, and passes (so
is "green") but actually does nothing (so is "rotten").

Due to the number of false positives (for example, all DISABLED tests
will be reported as rotten), running the unittests under lit will
*not* report rotten tests; however, running a unittest program
manually (not under lit) will report these by default.

The RGT support has been tried on Linux using both Clang and GCC as
build compilers, and on Windows with MSVC. MachO has not been tried.

The intent is to clean up more of the false positives before seeking
to commit the RGT support. Some of this work has been done already.

This is a Work-In-Progress, not ready for final review, but it seems
mature enough to present to the community in its current form.

Diff Detail

Event Timeline

probinson created this revision.Feb 26 2021, 10:33 AM
probinson requested review of this revision.Feb 26 2021, 10:33 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 26 2021, 10:33 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Orlando added a subscriber: Orlando.Mar 1 2021, 1:04 AM