By default gRPC has no idletimeout and some firewalls might drop idle
connections after a certain period. This results in idle clients
shouting into void until server resets the connection.
Details
- Reviewers
sammccall - Commits
- rG1a5dfb7db23e: [clangd][remote] Add flag to set idletimeout
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang-tools-extra/clangd/index/remote/server/Server.cpp | ||
---|---|---|
84 | 10 seems much too low, maybe set this to 5 min or so? |
Change 10 seconds to 600 seconds.
clang-tools-extra/clangd/index/remote/server/Server.cpp | ||
---|---|---|
84 | oops this was meant to be 10 minutes, not seconds :D |
clang-tools-extra/clangd/index/remote/server/Server.cpp | ||
---|---|---|
84 | Haha, makes more sense :-) Setting this to exactly the gcp timeout seems tempting fate with hard to debug races. Maybe 8 min? |
clang-tools-extra/clangd/index/remote/server/Server.cpp | ||
---|---|---|
84 | fair point, done! |
clang-tidy: error: 'Index.pb.h' file not found [clang-diagnostic-error]
not useful