In https://reviews.llvm.org/D92789 PPC64 checks were added that disallowed most
VSX pattern matching. We enable some safe ones for 32bit in this patch.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Disable BSWAP custom lowering in 32bit mode on Power9 since there currently isn't a safe way to do it.
Rebase.
llvm/lib/Target/PowerPC/PPCInstrVSX.td | ||
---|---|---|
4241 | This doesn't match the actual predicates for this block (i.e. doesn't match line 4095). | |
4244 | Why do we start another block here that is exactly the same set of predicates as line 4095? | |
llvm/test/CodeGen/PowerPC/aix-insert-extract.ll | ||
2 | Please use the script to produce the CHECK directives. |
llvm/lib/Target/PowerPC/PPCInstrVSX.td | ||
---|---|---|
4244 | Sorry about this, it was caused by me trying incorrectly resolving a merge failure. |
The patch is functionally fine but please address the pattern ordering nit on the commit.
llvm/lib/Target/PowerPC/PPCInstrVSX.td | ||
---|---|---|
4189 | The new ordering is weird. We used to have handling for i64/f64 followed by f128. Now it seems that we have i64/f64, then f64 then f128 then i64 then f128. Please just leave these here, and put all the existing and new i64/f64 above. |
The new ordering is weird. We used to have handling for i64/f64 followed by f128. Now it seems that we have i64/f64, then f64 then f128 then i64 then f128.
Please just leave these here, and put all the existing and new i64/f64 above.