Page MenuHomePhabricator

[flang][fir] Upstream utility function valueHasFirAttribute()
ClosedPublic

Authored by schweitz on Feb 25 2021, 2:35 PM.

Details

Diff Detail

Event Timeline

schweitz created this revision.Feb 25 2021, 2:35 PM
schweitz requested review of this revision.Feb 25 2021, 2:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 25 2021, 2:35 PM

LGTM. This will be tested in the subsequent usage.

flang/lib/Optimizer/Dialect/FIROps.cpp
1978

Should function arguments always be block arguments?

1992

Nit: AddOfOp -> AddrOfOp

2000–2002

Nit: globlaOp-> globalOp

This revision is now accepted and ready to land.Feb 26 2021, 2:15 PM
schweitz added inline comments.Feb 26 2021, 6:14 PM
flang/lib/Optimizer/Dialect/FIROps.cpp
1978

There is always an association, I believe.

1992

+1

2000–2002

+1

This revision was landed with ongoing or failed builds.Feb 26 2021, 6:32 PM
This revision was automatically updated to reflect the committed changes.