This is an archive of the discontinued LLVM Phabricator instance.

Differential D97418

[PowerPC] Disable more extended mne on AIX
ClosedPublic

Authored by jsji on Feb 24 2021, 2:48 PM.

Details

Reviewers
sfertile
steven.zhang
shchenz
Group Reviewers
Restricted Project
Commits
rG7967221a7263: [PowerPC] Disable more extended mne on AIX
Summary

To avoid assembler errors.

Diff Detail

Event Timeline

jsji created this revision.Feb 24 2021, 2:48 PM
Herald added subscribers: kbarton, hiraditya, nemanjai. · View Herald TranscriptFeb 24 2021, 2:48 PM
jsji requested review of this revision.Feb 24 2021, 2:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 24 2021, 2:48 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B90690: Diff 326211.Feb 24 2021, 5:13 PM
jsji added a comment.Mar 4 2021, 8:57 AM

Ping.

sfertile accepted this revision as: sfertile.Mar 4 2021, 12:24 PM

LGTM.

This revision is now accepted and ready to land.Mar 4 2021, 12:24 PM
Closed by commit rG7967221a7263: [PowerPC] Disable more extended mne on AIX (authored by jsji). · Explain WhyMar 4 2021, 1:13 PM
This revision was automatically updated to reflect the committed changes.
jsji added a commit: rG7967221a7263: [PowerPC] Disable more extended mne on AIX.

Revision Contents

PathSize
llvm/
lib/
Target/
PowerPC/
8 lines
14 lines
test/
MC/
Disassembler/
PowerPC/
12 lines

Diff 328288

llvm/lib/Target/PowerPC/PPCInstr64Bit.td

Show First 20 Lines • Show All 983 Lines • ▼ Show 20 Lines
def : InstAlias<"cntlzw $rA, $rS", (CNTLZW8 g8rc:$rA, g8rc:$rS)>; def : InstAlias<"cntlzw $rA, $rS", (CNTLZW8 g8rc:$rA, g8rc:$rS)>;
def : InstAlias<"cntlzw. $rA, $rS", (CNTLZW8_rec g8rc:$rA, g8rc:$rS)>; def : InstAlias<"cntlzw. $rA, $rS", (CNTLZW8_rec g8rc:$rA, g8rc:$rS)>;
def : InstAlias<"mtxer $Rx", (MTSPR8 1, g8rc:$Rx)>; def : InstAlias<"mtxer $Rx", (MTSPR8 1, g8rc:$Rx)>;
def : InstAlias<"mfxer $Rx", (MFSPR8 g8rc:$Rx, 1)>; def : InstAlias<"mfxer $Rx", (MFSPR8 g8rc:$Rx, 1)>;
//Disable this alias on AIX for now because as does not support them. //Disable this alias on AIX for now because as does not support them.
let Predicates = [ModernAs] in { let Predicates = [ModernAs] in {
def : InstAlias<"mtudscr $Rx", (MTSPR8 3, g8rc:$Rx)>; def : InstAlias<"mtudscr $Rx", (MTSPR8 3, g8rc:$Rx)>;
def : InstAlias<"mfudscr $Rx", (MFSPR8 g8rc:$Rx, 3)>; def : InstAlias<"mfudscr $Rx", (MFSPR8 g8rc:$Rx, 3)>;
}
def : InstAlias<"mfrtcu $Rx", (MFSPR8 g8rc:$Rx, 4)>; def : InstAlias<"mfrtcu $Rx", (MFSPR8 g8rc:$Rx, 4)>;
def : InstAlias<"mfrtcl $Rx", (MFSPR8 g8rc:$Rx, 5)>; def : InstAlias<"mfrtcl $Rx", (MFSPR8 g8rc:$Rx, 5)>;
def : InstAlias<"mtlr $Rx", (MTSPR8 8, g8rc:$Rx)>; def : InstAlias<"mtlr $Rx", (MTSPR8 8, g8rc:$Rx)>;
def : InstAlias<"mflr $Rx", (MFSPR8 g8rc:$Rx, 8)>; def : InstAlias<"mflr $Rx", (MFSPR8 g8rc:$Rx, 8)>;
def : InstAlias<"mtctr $Rx", (MTSPR8 9, g8rc:$Rx)>; def : InstAlias<"mtctr $Rx", (MTSPR8 9, g8rc:$Rx)>;
▲ Show 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
def : InstAlias<"mttbl $Rx", (MTSPR8 284, g8rc:$Rx)>; def : InstAlias<"mttbl $Rx", (MTSPR8 284, g8rc:$Rx)>;
def : InstAlias<"mttbu $Rx", (MTSPR8 285, g8rc:$Rx)>; def : InstAlias<"mttbu $Rx", (MTSPR8 285, g8rc:$Rx)>;
def : InstAlias<"mfpvr $RT", (MFSPR8 g8rc:$RT, 287)>; def : InstAlias<"mfpvr $RT", (MFSPR8 g8rc:$RT, 287)>;
def : InstAlias<"mfspefscr $Rx", (MFSPR8 g8rc:$Rx, 512)>; def : InstAlias<"mfspefscr $Rx", (MFSPR8 g8rc:$Rx, 512)>;
def : InstAlias<"mtspefscr $Rx", (MTSPR8 512, g8rc:$Rx)>; def : InstAlias<"mtspefscr $Rx", (MTSPR8 512, g8rc:$Rx)>;
}
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Load/Store instructions. // Load/Store instructions.
// //
// Sign extending loads. // Sign extending loads.
let PPC970_Unit = 2 in { let PPC970_Unit = 2 in {
let Interpretation64Bit = 1, isCodeGenOnly = 1 in let Interpretation64Bit = 1, isCodeGenOnly = 1 in
▲ Show 20 Lines • Show All 575 Lines • Show Last 20 Lines

llvm/lib/Target/PowerPC/PPCInstrInfo.td

Show First 20 Lines • Show All 4,640 Lines • ▼ Show 20 Lines
def : InstAlias<"crnot $bx, $by", (CRNOR crbitrc:$bx, crbitrc:$by, crbitrc:$by)>; def : InstAlias<"crnot $bx, $by", (CRNOR crbitrc:$bx, crbitrc:$by, crbitrc:$by)>;
def : InstAlias<"mftb $Rx", (MFTB gprc:$Rx, 268)>; def : InstAlias<"mftb $Rx", (MFTB gprc:$Rx, 268)>;
def : InstAlias<"mftbl $Rx", (MFTB gprc:$Rx, 268)>; def : InstAlias<"mftbl $Rx", (MFTB gprc:$Rx, 268)>;
def : InstAlias<"mftbu $Rx", (MFTB gprc:$Rx, 269)>; def : InstAlias<"mftbu $Rx", (MFTB gprc:$Rx, 269)>;
def : InstAlias<"xnop", (XORI R0, R0, 0)>; def : InstAlias<"xnop", (XORI R0, R0, 0)>;
def : InstAlias<"mtxer $Rx", (MTSPR 1, gprc:$Rx)>;
def : InstAlias<"mfxer $Rx", (MFSPR gprc:$Rx, 1)>;
//Disable this alias on AIX for now because as does not support them.
let Predicates = [ModernAs] in {
foreach BR = 0-7 in { foreach BR = 0-7 in {
def : InstAlias<"mfbr"#BR#" $Rx", def : InstAlias<"mfbr"#BR#" $Rx",
(MFDCR gprc:$Rx, !add(BR, 0x80))>, (MFDCR gprc:$Rx, !add(BR, 0x80))>,
Requires<[IsPPC4xx]>; Requires<[IsPPC4xx]>;
def : InstAlias<"mtbr"#BR#" $Rx", def : InstAlias<"mtbr"#BR#" $Rx",
(MTDCR gprc:$Rx, !add(BR, 0x80))>, (MTDCR gprc:$Rx, !add(BR, 0x80))>,
Requires<[IsPPC4xx]>; Requires<[IsPPC4xx]>;
} }
def : InstAlias<"mtmsrd $RS", (MTMSRD gprc:$RS, 0)>; def : InstAlias<"mtmsrd $RS", (MTMSRD gprc:$RS, 0)>;
def : InstAlias<"mtmsr $RS", (MTMSR gprc:$RS, 0)>; def : InstAlias<"mtmsr $RS", (MTMSR gprc:$RS, 0)>;
def : InstAlias<"mtxer $Rx", (MTSPR 1, gprc:$Rx)>;
def : InstAlias<"mfxer $Rx", (MFSPR gprc:$Rx, 1)>;
//Disable this alias on AIX for now because as does not support them.
let Predicates = [ModernAs] in {
def : InstAlias<"mtudscr $Rx", (MTSPR 3, gprc:$Rx)>; def : InstAlias<"mtudscr $Rx", (MTSPR 3, gprc:$Rx)>;
def : InstAlias<"mfudscr $Rx", (MFSPR gprc:$Rx, 3)>; def : InstAlias<"mfudscr $Rx", (MFSPR gprc:$Rx, 3)>;
}
def : InstAlias<"mfrtcu $Rx", (MFSPR gprc:$Rx, 4)>; def : InstAlias<"mfrtcu $Rx", (MFSPR gprc:$Rx, 4)>;
def : InstAlias<"mfrtcl $Rx", (MFSPR gprc:$Rx, 5)>; def : InstAlias<"mfrtcl $Rx", (MFSPR gprc:$Rx, 5)>;
def : InstAlias<"mtlr $Rx", (MTSPR 8, gprc:$Rx)>; def : InstAlias<"mtlr $Rx", (MTSPR 8, gprc:$Rx)>;
def : InstAlias<"mflr $Rx", (MFSPR gprc:$Rx, 8)>; def : InstAlias<"mflr $Rx", (MFSPR gprc:$Rx, 8)>;
def : InstAlias<"mtctr $Rx", (MTSPR 9, gprc:$Rx)>; def : InstAlias<"mtctr $Rx", (MTSPR 9, gprc:$Rx)>;
▲ Show 20 Lines • Show All 113 Lines • ▼ Show 20 Lines
def : InstAlias<"mfsrr3 $Rx", (MFSPR gprc:$Rx, 991)>, Requires<[IsPPC4xx]>; def : InstAlias<"mfsrr3 $Rx", (MFSPR gprc:$Rx, 991)>, Requires<[IsPPC4xx]>;
def : InstAlias<"mtdccr $Rx", (MTSPR 1018, gprc:$Rx)>, Requires<[IsPPC4xx]>; def : InstAlias<"mtdccr $Rx", (MTSPR 1018, gprc:$Rx)>, Requires<[IsPPC4xx]>;
def : InstAlias<"mfdccr $Rx", (MFSPR gprc:$Rx, 1018)>, Requires<[IsPPC4xx]>; def : InstAlias<"mfdccr $Rx", (MFSPR gprc:$Rx, 1018)>, Requires<[IsPPC4xx]>;
def : InstAlias<"mticcr $Rx", (MTSPR 1019, gprc:$Rx)>, Requires<[IsPPC4xx]>; def : InstAlias<"mticcr $Rx", (MTSPR 1019, gprc:$Rx)>, Requires<[IsPPC4xx]>;
def : InstAlias<"mficcr $Rx", (MFSPR gprc:$Rx, 1019)>, Requires<[IsPPC4xx]>; def : InstAlias<"mficcr $Rx", (MFSPR gprc:$Rx, 1019)>, Requires<[IsPPC4xx]>;
}
def : InstAlias<"tlbie $RB", (TLBIE R0, gprc:$RB)>; def : InstAlias<"tlbie $RB", (TLBIE R0, gprc:$RB)>;
def : InstAlias<"tlbrehi $RS, $A", (TLBRE2 gprc:$RS, gprc:$A, 0)>, def : InstAlias<"tlbrehi $RS, $A", (TLBRE2 gprc:$RS, gprc:$A, 0)>,
Requires<[IsPPC4xx]>; Requires<[IsPPC4xx]>;
def : InstAlias<"tlbrelo $RS, $A", (TLBRE2 gprc:$RS, gprc:$A, 1)>, def : InstAlias<"tlbrelo $RS, $A", (TLBRE2 gprc:$RS, gprc:$A, 1)>,
Requires<[IsPPC4xx]>; Requires<[IsPPC4xx]>;
def : InstAlias<"tlbwehi $RS, $A", (TLBWE2 gprc:$RS, gprc:$A, 0)>, def : InstAlias<"tlbwehi $RS, $A", (TLBWE2 gprc:$RS, gprc:$A, 0)>,
▲ Show 20 Lines • Show All 529 Lines • Show Last 20 Lines

llvm/test/MC/Disassembler/PowerPC/ppc64-encoding-ext.txt

Show First 20 Lines • Show All 2,229 Lines • ▼ Show 20 Lines
0x7c 0x48 0x02 0xa6 0x7c 0x48 0x02 0xa6
# CHECK: mtctr 2 # CHECK: mtctr 2
0x7c 0x49 0x03 0xa6 0x7c 0x49 0x03 0xa6
# CHECK: mfctr 2 # CHECK: mfctr 2
0x7c 0x49 0x02 0xa6 0x7c 0x49 0x02 0xa6
# CHECK: mtuamr 2 # MODERN: mtuamr 2
# OLD: mtspr 13, 2
0x7c 0x4d 0x03 0xa6 0x7c 0x4d 0x03 0xa6
# CHECK: mfuamr 2 # MODERN: mfuamr 2
# OLD: mfspr 2, 13
0x7c 0x4d 0x02 0xa6 0x7c 0x4d 0x02 0xa6
# CHECK: mtppr 2 # MODERN: mtppr 2
# OLD: mtspr 896, 2
0x7c 0x40 0xe3 0xa6 0x7c 0x40 0xe3 0xa6
# CHECK: mfppr 2 # MODERN: mfppr 2
# OLD: mfspr 2, 896
0x7c 0x40 0xe2 0xa6 0x7c 0x40 0xe2 0xa6
# CHECK: nop # CHECK: nop
0x60 0x00 0x00 0x00 0x60 0x00 0x00 0x00
# CHECK: xnop # CHECK: xnop
0x68 0x00 0x00 0x00 0x68 0x00 0x00 0x00
▲ Show 20 Lines • Show All 65 Lines • Show Last 20 Lines