[NFC] Switch to auto marshalling infrastructure for `-fsanitize-address-destructor-kind=` flag.

[delcypher]

Summary

This change simplifies clang/lib/Frontend/CompilerInvocation.cpp
because we no longer need to manually parse the flag and set codegen
options in the frontend. However, we still need to manually parse the
flag in the driver because:

• The marshalling infrastructure doesn't operate there.
• We need to do some platform specific checks in the driver that will likely never be supported by any kind of marshalling infrastructure.

rdar://71609176

[yln]

LGTM, cleanup only, right?

[jansvoboda11]

LGTM.

If you don't get around committing this today, please rebase this on top of D97375 that I'm going to commit tomorrow.

[delcypher]

In D97327#2585410, @jansvoboda11 wrote:

LGTM.

If you don't get around committing this today, please rebase this on top of D97375 that I'm going to commit tomorrow.

@jansvoboda11 This doesn't build anymore because https://reviews.llvm.org/D97375 removed AutoNormalizeEnum. Based on skim reading the patch it looks like I should remove the AutoNormalizeEnum mixin and replace MarshallingInfoString with MarshallingInfoEnum. Does that sound right?

[delcypher]

In D97327#2582981, @yln wrote:

LGTM, cleanup only, right?

Yes. This is just a small clean up.

[jansvoboda11]

In D97327#2588222, @delcypher wrote:

@jansvoboda11 This doesn't build anymore because https://reviews.llvm.org/D97375 removed AutoNormalizeEnum. Based on skim reading the patch it looks like I should remove the AutoNormalizeEnum mixin and replace MarshallingInfoString with MarshallingInfoEnum. Does that sound right?

That's exactly right.

[delcypher]

• Fix build.

clang/include/clang/Driver/Options.td

def fsanitize_address_globals_dead_stripping : Flag<["-"], "fsanitize-address-globals-dead-stripping">,
   Group<f_clang_Group>, HelpText<"Enable linker dead stripping of globals in AddressSanitizer">,
   MarshallingInfoFlag<CodeGenOpts<"SanitizeAddressGlobalsDeadStripping">, "false">;
 defm sanitize_address_use_odr_indicator : BoolOption<"f", "sanitize-address-use-odr-indicator",
   CodeGenOpts<"SanitizeAddressUseOdrIndicator">, DefaultFalse,
   PosFlag<SetTrue, [], "Enable ODR indicator globals to avoid false ODR violation"
             " reports in partially sanitized programs at the cost of an increase in binary size">,
   NegFlag<SetFalse, [], "Disable ODR indicator globals">>,
   Group<f_clang_Group>;
-def sanitize_address_destructor_kind_EQ : Joined<["-"], "fsanitize-address-destructor-kind=">,
+def sanitize_address_destructor_kind_EQ
+    : Joined<["-"], "fsanitize-address-destructor-kind=">,
       MetaVarName<"<kind>">,
       Flags<[CC1Option]>,
       HelpText<"Set destructor type used in ASan instrumentation">,
-  Group<f_clang_Group>;
+      Group<f_clang_Group>,
+      Values<"none,global">,
+      NormalizedValuesScope<"llvm::AsanDtorKind">,
+      NormalizedValues<["None", "Global"]>,
+      MarshallingInfoString<CodeGenOpts<"SanitizeAddressDtorKind">, "Global">,
+      AutoNormalizeEnum;
 // Note: This flag was introduced when it was necessary to distinguish between
 //       ABI for correct codegen.  This is no longer needed, but the flag is
 //       not removed since targeting either ABI will behave the same.
 //       This way we cause no disturbance to existing scripts & code, and if we
 //       want to use this flag in the future we will cause no disturbance then
 //       either.
 def fsanitize_hwaddress_abi_EQ
     : Joined<["-"], "fsanitize-hwaddress-abi=">,

clang/lib/Frontend/CompilerInvocation.cpp

parseSanitizerKinds("-fsanitize-recover=",
                       Args.getAllArgValues(OPT_fsanitize_recover_EQ), Diags,
                       Opts.SanitizeRecover);
   parseSanitizerKinds("-fsanitize-trap=",
                       Args.getAllArgValues(OPT_fsanitize_trap_EQ), Diags,
                       Opts.SanitizeTrap);
 
   Opts.EmitVersionIdentMetadata = Args.hasFlag(OPT_Qy, OPT_Qn, true);
 
-  if (LangOptsRef.Sanitize.has(SanitizerKind::Address)) {
-    if (Arg *A =
-            Args.getLastArg(options::OPT_sanitize_address_destructor_kind_EQ)) {
-      auto destructorKind = AsanDtorKindFromString(A->getValue());
-      if (destructorKind == llvm::AsanDtorKind::Invalid) {
-        Diags.Report(clang::diag::err_drv_unsupported_option_argument)
-            << A->getOption().getName() << A->getValue();
-      } else {
-        Opts.setSanitizeAddressDtorKind(destructorKind);
-      }
-    }
-  }
-
   if (Args.hasArg(options::OPT_ffinite_loops))
     Opts.FiniteLoops = CodeGenOptions::FiniteLoopsKind::Always;
   else if (Args.hasArg(options::OPT_fno_finite_loops))
     Opts.FiniteLoops = CodeGenOptions::FiniteLoopsKind::Never;
 
   return Success && Diags.getNumErrors() == NumErrorsBefore;
 }
 

clang/test/CodeGen/asan-destructor-kind.cpp

 // Frontend rejects invalid option
 // RUN: not %clang_cc1 -fsanitize=address \
 // RUN:   -fsanitize-address-destructor-kind=bad_arg -emit-llvm -o - \
 // RUN:   -triple x86_64-apple-macosx10.15 %s 2>&1 | \
 // RUN:   FileCheck %s --check-prefixes=CHECK-BAD-ARG
-// CHECK-BAD-ARG: unsupported argument 'bad_arg' to option 'fsanitize-address-destructor-kind='
+// CHECK-BAD-ARG: invalid value 'bad_arg' in '-fsanitize-address-destructor-kind=bad_arg'
 
 // Default is global dtor
 // RUN: %clang_cc1 -fsanitize=address -emit-llvm -o - -triple x86_64-apple-macosx10.15 \
 // RUN:   -fno-legacy-pass-manager %s \
 // RUN:   | FileCheck %s --check-prefixes=CHECK-GLOBAL-DTOR
 //
 // RUN: %clang_cc1 -fsanitize=address -emit-llvm -o - -triple x86_64-apple-macosx10.15 \
 // RUN:   -flegacy-pass-manager %s \