Implements parts of:
- P0898R3 Standard Library Concepts
- P1754 Rename concepts to standard_case for C++20, while we still can
Depends on D96660
Paths
| Differential D97176
[libcxx] adds concepts std::equality_comparable[_with] ClosedPublic Authored by cjdb on Feb 21 2021, 8:12 PM.
Details
Summary Implements parts of:
Depends on D96660
Diff Detail
Unit TestsFailed Event TimelineComment Actions I like the extensive set of tests you added! I'd like to see the build pass before accepting.
This revision is now accepted and ready to land.Mar 2 2021, 9:05 AM Comment Actions fixes GCC build errors:
Comment Actions Just some nits on tests. The concept definition looks like a straightforward transliteration of
cjdb marked 3 inline comments as done. Comment Actions
Comment Actions LGTM! Comment Actions
auto operator==(...) = default is ill-formed (it must be bool), but auto operator<=>(...) = default is allowed (the compiler will do magic to work out which of the three blessed types it'll be). Closed by commit rGe63ddcccf8db: [libcxx] adds concepts std::equality_comparable[_with] (authored by cjdb). · Explain WhyMar 4 2021, 6:24 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 327580 libcxx/include/concepts
libcxx/test/std/concepts/comparison/concepts.equalitycomparable/equality_comparable.compile.pass.cpp
libcxx/test/std/concepts/comparison/concepts.equalitycomparable/equality_comparable_with.compile.pass.cpp
libcxx/test/std/concepts/comparison/types.h
|
t -> __t and u -> __u